public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 0/1] Fix union member access specifiers
@ 2021-03-15 16:04 Giuliano Procida
  2021-03-15 16:04 ` [PATCH 1/1] abidw: Treat union members as public by default Giuliano Procida
  0 siblings, 1 reply; 3+ messages in thread
From: Giuliano Procida @ 2021-03-15 16:04 UTC (permalink / raw)
  To: libabigail; +Cc: dodji, kernel-team, gprocida, maennich

Hi Dodji.

I found a few places in the code that that appeared to be doing the
wrong things for unions which (like structs) should have members as
public by default.

Each of the 3 changes affected some tests. Only one of them affected a
small test case I put together, so I've omitted that from the patch.

FTR it's:

union U {
  int public_0;
  void public_1() { }
 public:
  int public_2;
  void public_3() { }
 protected:
  int protected_4;
  void protected_5() { }
 private:
  int private_6;
  void private_7() { }
};

struct S {
  int public_0;
  void public_1() { }
 public:
  int public_2;
  void public_3() { }
 protected:
  int protected_4;
  void protected_5() { }
 private:
  int private_6;
  void private_7() { }
};

class C {
  int private_0;
  void private_1() { }
 public:
  int public_2;
  void public_3() { }
 protected:
  int protected_4;
  void protected_5() { }
 private:
  int private_6;
  void private_7() { }
};

void fun(U, S, C) {
}

Please do double-check I've touched all the right bits of code.
Thanks!

Giuliano.

Giuliano Procida (1):
  abidw: Treat union members as public by default.

 src/abg-dwarf-reader.cc                       |   20 +-
 .../test-annotate/libtest24-drop-fns-2.so.abi |    4 +-
 .../test-annotate/libtest24-drop-fns.so.abi   |    4 +-
 .../test-anonymous-members-0.o.abi            |    8 +-
 .../data/test-annotate/test13-pr18894.so.abi  |    4 +-
 .../data/test-annotate/test14-pr18893.so.abi  |    8 +-
 .../data/test-annotate/test15-pr18892.so.abi  |   40 +-
 .../data/test-annotate/test17-pr19027.so.abi  |  282 ++--
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi |   12 +-
 ...19-pr19023-libtcmalloc_and_profiler.so.abi |   84 +-
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi |   12 +-
 .../data/test-annotate/test21-pr19092.so.abi  |  118 +-
 .../PR25409-librte_bus_dpaa.so.20.0.abi       |  238 +--
 .../test0-pr19026-libvtkIOSQL-6.1.so.1.abi    | 1384 ++++++++---------
 .../PR22015-libboost_iostreams.so.abi         |    4 +-
 .../data/test-read-dwarf/PR25007-sdhci.ko.abi |  208 +--
 .../libtest24-drop-fns-2.so.abi               |    4 +-
 .../test-read-dwarf/libtest24-drop-fns.so.abi |    4 +-
 .../data/test-read-dwarf/test-PR26568-1.o.abi |    4 +-
 .../data/test-read-dwarf/test-PR26568-2.o.abi |    4 +-
 .../test-read-dwarf/test-libandroid.so.abi    |  240 +--
 .../test-read-dwarf/test10-pr18818-gcc.so.abi |    8 +-
 .../test-read-dwarf/test11-pr18828.so.abi     |   52 +-
 .../test-read-dwarf/test12-pr18844.so.abi     |  106 +-
 .../test-read-dwarf/test13-pr18894.so.abi     |    4 +-
 .../test-read-dwarf/test14-pr18893.so.abi     |    8 +-
 .../test-read-dwarf/test15-pr18892.so.abi     |   40 +-
 .../test-read-dwarf/test16-pr18904.so.abi     |   58 +-
 .../test-read-dwarf/test17-pr19027.so.abi     |  282 ++--
 ...st18-pr19037-libvtkRenderingLIC-6.1.so.abi |   12 +-
 ...19-pr19023-libtcmalloc_and_profiler.so.abi |   84 +-
 ...st20-pr19025-libvtkParallelCore-6.1.so.abi |   12 +-
 .../test-read-dwarf/test21-pr19092.so.abi     |  118 +-
 .../test22-pr19097-libstdc++.so.6.0.17.so.abi |   80 +-
 .../test9-pr18818-clang.so.abi                |   12 +-
 35 files changed, 1781 insertions(+), 1781 deletions(-)

-- 
2.31.0.rc2.261.g7f71774620-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-21 11:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15 16:04 [PATCH 0/1] Fix union member access specifiers Giuliano Procida
2021-03-15 16:04 ` [PATCH 1/1] abidw: Treat union members as public by default Giuliano Procida
2021-03-19 16:40   ` Dodji Seketeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).