Re: Fwd: Testing Setup - More Tests and Automation?

[Mark Wielaard <mark@klomp.org>]

Hi,

On Fri, Apr 29, 2022 at 11:13:04PM +0200, Mark Wielaard wrote:
> And it caught an issue on fedora-ppc64 and debian-ppc64
> https://builder.sourceware.org/buildbot/#/builders/libabigail-fedora-ppc64
> https://builder.sourceware.org/buildbot/#/builders/libabigail-debian-ppc64
> 
> FAIL: runtestslowselfcompare.sh
> ===============================
> + abidw=../tools/abidw
> + objdir=../src/.libs
> + echo ENABLE_SLOW_TEST=yes
> ENABLE_SLOW_TEST=yes
> + test xyes '!=' x
> ++ ../tools/abidw --abidiff ../src/.libs/libabigail.so
> lt-abidw: abg-symtab-reader.cc:557: void abigail::symtab_reader::symtab::update_function_entry_address_symbol_map(Elf*, GElf_Sym*, const elf_symbol_sptr&): Assertion `__abg_cond__' failed.
> FAIL runtestslowselfcompare.sh (exit status: 134)
> 
> It didn't fail any other builder (so it isn't power specific, because
> fedora-ppc64le is green, and it isn't big endian specific, because
> fedora-s390x is green).
> 
> But it might have to do with ppc64 function descriptors, which are
> ppc64 specific.

It indeed is. The issue is in update_function_entry_address_symbol_map
which is only called for ppc64 ELFv1 binaries.

src/.libs/libabigail.so contains two identical symbols:

  468: 0000000000427498    604 FUNC    GLOBAL DEFAULT       21 _ZN7abigail10comparison12pointer_diffC2ESt10shared_ptrINS_2ir16pointer_type_defEES5_S2_INS0_4diffEES2_INS0_12diff_contextEE
 7362: 0000000000427498    604 FUNC    GLOBAL DEFAULT       21 _ZN7abigail10comparison12pointer_diffC2ESt10shared_ptrINS_2ir16pointer_type_defEES5_S2_INS0_4diffEES2_INS0_12diff_contextEE

But those are not seen as aliases. And the assert says:

      ABG_ASSERT(two_symbols_alias
                 || symbol_is_foo_and_prev_symbol_is_dot_foo);

I don't understand the aliasing code well enough to understand why
yet.

Cheers,

Mark