* [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
@ 2022-02-12 10:25 Noah Goldstein
2022-02-12 15:46 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Noah Goldstein @ 2022-02-12 10:25 UTC (permalink / raw)
To: libc-alpha
commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Feb 7 05:55:15 2022 -0800
x86-64: Optimize bzero
Remove setting the .text section for the code. This commit
adds that back.
---
sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
index 7c94fcdae1..785fee1d57 100644
--- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
+++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
@@ -114,6 +114,7 @@
# error SECTION is not defined!
#endif
+ .section SECTION(.text), "ax", @progbits
#if IS_IN (libc)
# if defined SHARED
ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
2022-02-12 10:25 [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms Noah Goldstein
@ 2022-02-12 15:46 ` H.J. Lu
2022-02-12 21:44 ` Noah Goldstein
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2022-02-12 15:46 UTC (permalink / raw)
To: Noah Goldstein; +Cc: GNU C Library, Carlos O'Donell
On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
>
> commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date: Mon Feb 7 05:55:15 2022 -0800
>
> x86-64: Optimize bzero
>
> Remove setting the .text section for the code. This commit
> adds that back.
> ---
> sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> index 7c94fcdae1..785fee1d57 100644
> --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> @@ -114,6 +114,7 @@
> # error SECTION is not defined!
> #endif
>
> + .section SECTION(.text), "ax", @progbits
> #if IS_IN (libc)
> # if defined SHARED
> ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> --
> 2.25.1
>
LGTM.
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
2022-02-12 15:46 ` H.J. Lu
@ 2022-02-12 21:44 ` Noah Goldstein
2022-05-04 6:01 ` Sunil Pandey
0 siblings, 1 reply; 4+ messages in thread
From: Noah Goldstein @ 2022-02-12 21:44 UTC (permalink / raw)
To: H.J. Lu; +Cc: GNU C Library, Carlos O'Donell
On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date: Mon Feb 7 05:55:15 2022 -0800
> >
> > x86-64: Optimize bzero
> >
> > Remove setting the .text section for the code. This commit
> > adds that back.
> > ---
> > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > index 7c94fcdae1..785fee1d57 100644
> > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > @@ -114,6 +114,7 @@
> > # error SECTION is not defined!
> > #endif
> >
> > + .section SECTION(.text), "ax", @progbits
> > #if IS_IN (libc)
> > # if defined SHARED
> > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> > --
> > 2.25.1
> >
>
> LGTM.
>
> Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
>
> Thanks.
>
Thanks pushed.
> --
> H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms
2022-02-12 21:44 ` Noah Goldstein
@ 2022-05-04 6:01 ` Sunil Pandey
0 siblings, 0 replies; 4+ messages in thread
From: Sunil Pandey @ 2022-05-04 6:01 UTC (permalink / raw)
To: Noah Goldstein, Libc-stable Mailing List; +Cc: H.J. Lu, GNU C Library
On Sat, Feb 12, 2022 at 1:44 PM Noah Goldstein via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > >
> > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840
> > > Author: H.J. Lu <hjl.tools@gmail.com>
> > > Date: Mon Feb 7 05:55:15 2022 -0800
> > >
> > > x86-64: Optimize bzero
> > >
> > > Remove setting the .text section for the code. This commit
> > > adds that back.
> > > ---
> > > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > index 7c94fcdae1..785fee1d57 100644
> > > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S
> > > @@ -114,6 +114,7 @@
> > > # error SECTION is not defined!
> > > #endif
> > >
> > > + .section SECTION(.text), "ax", @progbits
> > > #if IS_IN (libc)
> > > # if defined SHARED
> > > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
> >
> > Thanks.
> >
>
> Thanks pushed.
> > --
> > H.J.
I would like to backport this patch to release branches.
Any comments or objections?
--Sunil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-04 6:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 10:25 [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms Noah Goldstein
2022-02-12 15:46 ` H.J. Lu
2022-02-12 21:44 ` Noah Goldstein
2022-05-04 6:01 ` Sunil Pandey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).