public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Steve Ellcey <sellcey@caviumnetworks.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Fix -Os related build and test failures.
Date: Mon, 31 Oct 2016 20:50:00 -0000	[thread overview]
Message-ID: <5238d7ae-3e33-741b-3e96-61aa0d85f45b@redhat.com> (raw)
In-Reply-To: <1477943809.2891.39.camel@caviumnetworks.com>

On 10/31/2016 03:56 PM, Steve Ellcey wrote:
> On Mon, 2016-10-31 at 15:50 -0400, Carlos O'Donell wrote:
>>  
>> I have fix and I'm just testing it again on x86_64.
>>
>> Thank you for your patience :-)
>>
>> Cheers,
>> Carlos.
> 
> Sounds good.  FYI: I ran into this problem with nptl_db/thread_dbP.h,
> in addition to the files I mentioned.  I think those are the only
> instances of this problem.
> 
> Steve Ellcey
> 

This should fix it. Sorry for the lack of non-x86/x86_64 testing.

Like I said I'll set about setting up more crosses like the kernel
people do.

commit bb5badf17087099dd9140f812778f7a8615b2111
Author: Carlos O'Donell <carlos@redhat.com>
Date:   Mon Oct 31 16:46:57 2016 -0400

    Bug 20729: Include libc-internal.h where required.
    
    The original fix for bug 20729 failed to include
    libc-internal.h in the files that needed them and
    this caused build failures on machines that don't
    implicitly include this header. This commit fixes
    that by following the consensus rule that a header,
    if needed, should always be directly included.

diff --git a/locale/weight.h b/locale/weight.h
index 1f61f01..19b8e4a 100644
--- a/locale/weight.h
+++ b/locale/weight.h
@@ -19,6 +19,8 @@
 #ifndef _WEIGHT_H_
 #define _WEIGHT_H_	1
 
+#include <libc-internal.h>
+
 /* Find index of weight.  */
 static inline int32_t __attribute__ ((always_inline))
 findidx (const int32_t *table,
diff --git a/locale/weightwc.h b/locale/weightwc.h
index e42ce13..ae18965 100644
--- a/locale/weightwc.h
+++ b/locale/weightwc.h
@@ -19,6 +19,8 @@
 #ifndef _WEIGHTWC_H_
 #define _WEIGHTWC_H_	1
 
+#include <libc-internal.h>
+
 /* Find index of weight.  */
 static inline int32_t __attribute__ ((always_inline))
 findidx (const int32_t *table,
diff --git a/nptl_db/thread_dbP.h b/nptl_db/thread_dbP.h
index b53f1c1..f448547 100644
--- a/nptl_db/thread_dbP.h
+++ b/nptl_db/thread_dbP.h
@@ -30,6 +30,7 @@
 #include "../nptl/pthreadP.h"  	/* This is for *_BITMASK only.  */
 #include <list.h>
 #include <gnu/lib-names.h>
+#include <libc-internal.h>
 
 /* Indeces for the symbol names.  */
 enum
---

Cheers,
Carlos.

  reply	other threads:[~2016-10-31 20:50 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  4:48 [PATCH] Fix -Os related -Werror failures Carlos O'Donell
2016-10-28  6:25 ` Andreas Schwab
2016-10-28  6:32 ` Florian Weimer
2016-10-28  6:44   ` Jeff Law
2016-10-28  8:12     ` Arnd Bergmann
2016-10-28  8:17       ` Andrew Pinski
2016-10-28 13:28         ` Jeff Law
2016-10-28 20:10       ` Paul Eggert
2016-10-29  3:03         ` Jeff Law
2016-10-30  4:25           ` Paul Eggert
2016-10-28 12:09   ` Carlos O'Donell
2016-10-28 12:43     ` Florian Weimer
2016-10-28 13:04     ` Joseph Myers
2016-10-28 13:07     ` Carlos O'Donell
2016-10-28 12:49   ` Joseph Myers
2016-10-28 12:55     ` Florian Weimer
2016-10-28 13:18       ` Carlos O'Donell
2016-10-28 13:58         ` [PATCH v2] Fix -Os related build and test failures Carlos O'Donell
2016-10-28 14:17           ` Joseph Myers
2016-10-29  2:59             ` [PATCH v3] " Carlos O'Donell
2016-10-29  3:26               ` Carlos O'Donell
2016-10-29 17:35               ` Joseph Myers
2016-10-30  3:51                 ` [PATCH v4] " Carlos O'Donell
2016-10-31  8:33                   ` Andreas Schwab
2016-10-31  9:16                     ` Carlos O'Donell
2016-10-31  9:22                       ` Florian Weimer
2016-10-31 12:56                       ` David Miller
2016-10-31 19:56                         ` Carlos O'Donell
2016-11-01 22:59                           ` Joseph Myers
2016-11-02 12:52                             ` Carlos O'Donell
2016-11-01  9:17                   ` Andreas Schwab
2016-11-01 11:13                     ` Joseph Myers
2016-11-01 15:58                       ` Tamar Christina
2016-11-01 16:06                         ` David Miller
2016-11-01 16:15                           ` Tamar Christina
2016-11-02 11:53                           ` Carlos O'Donell
2016-11-02 17:03                             ` Carlos O'Donell
2016-11-02 13:22                       ` Carlos O'Donell
2016-10-31 18:38               ` [PATCH v3] " Steve Ellcey
2016-10-31 19:50                 ` Carlos O'Donell
2016-10-31 19:57                   ` Steve Ellcey
2016-10-31 20:50                     ` Carlos O'Donell [this message]
2016-10-31 21:00                       ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5238d7ae-3e33-741b-3e96-61aa0d85f45b@redhat.com \
    --to=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=sellcey@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).