Re: [PATCH v4] Fix -Os related build and test failures.

[Carlos O'Donell <carlos@redhat.com>]

On 11/01/2016 07:12 AM, Joseph Myers wrote:
> On Tue, 1 Nov 2016, Andreas Schwab wrote:
> 
>> On Okt 30 2016, Carlos O'Donell <carlos@redhat.com> wrote:
>>
>>> diff --git a/resolv/res_send.c b/resolv/res_send.c
>>> index 6d46bb2..4ec8c1a 100644
>>> --- a/resolv/res_send.c
>>> +++ b/resolv/res_send.c
>>> @@ -664,7 +664,7 @@ send_vc(res_state statp,
>>>  	   a false-positive.
>>>  	 */
>>>  	DIAG_PUSH_NEEDS_COMMENT;
>>> -	DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>>> +	DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>>>  	int resplen;
>>>  	DIAG_POP_NEEDS_COMMENT;
>>>  	struct iovec iov[4];
>>
>> That breaks powerpc and s390.
>>
>> res_send.c: In function 'send_vc':
>> res_send.c:668:6: error: 'resplen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>   int resplen;
>>       ^~~~~~~
> 
> And the other change to the same file introduces a new use of 
> DIAG_IGNORE_NEEDS_COMMENT with a comment that only mentions -Os.  Was the 
> intent to edit the latter use to be DIAG_IGNORE_Os_NEEDS_COMMENT, with the 
> former one edited by mistake instead?

It was indeed a mistake. I used a script to find and fix the uses I'd added,
but here I made a mistake.

I'm running a rawhide build check here to verify the fix fixes things for
x86, x86_64, aarch64, arm, ppc64, ppc64le, and s390.

Cheers,
Carlos.