From: Carlos O'Donell <carlos@redhat.com>
To: David Miller <davem@davemloft.net>, Tamar.Christina@arm.com
Cc: joseph@codesourcery.com, schwab@linux-m68k.org,
fweimer@redhat.com, libc-alpha@sourceware.org, nd@arm.com,
Bin.Cheng@arm.com
Subject: Re: [PATCH v4] Fix -Os related build and test failures.
Date: Wed, 02 Nov 2016 17:03:00 -0000 [thread overview]
Message-ID: <16b550f9-e5f0-ced0-38e9-022ccf3813b8@redhat.com> (raw)
In-Reply-To: <c603b219-6951-bbc3-8938-a867e4494ce4@redhat.com>
On 11/02/2016 07:52 AM, Carlos O'Donell wrote:
> On 11/01/2016 12:06 PM, David Miller wrote:
>> From: Tamar Christina <Tamar.Christina@arm.com>
>> Date: Tue, 1 Nov 2016 15:58:20 +0000
>>
>>> This also breaks ARM and AArch64,
>>>
>>> Would it be worth reverting the commit until this is fixed?
>>> It's currently blocking trunk builds.
>>
>> Mainline has been fixed already.
>
> No, there is one more issue left. My automated cleanup script
> turned one of the DIAG's into an -Os diag by error. Joseph
> noticed this and I'll fix it right now.
>
> I'm going to push out a Fedora Rawhide build to verify this
> for: arm, aarch64, ppc64le, ppc64, s390, s390x, x86, and
> x86_64.
The changes to fix bug 20729 introduced an error which removed an
ignore diagnostic from -O2 by using the new -Os related macro.
This broke ppc64 builds. The following patch fixes the mistake.
Tested on x86, x86_64, ppc64, ppc64le, arm, aarch64, and s390x.
Checked in.
2016-11-02 Florian Weimer <fweimer@redhat.com>
Carlos O'Donell <carlos@redhat.com>
[Bug #20729]
* resolv/res_send.c (send_vc): Revert DIAG_IGNORE_Os_NEEDS_COMMENT
change to non -Os related diagnostic. Use DIAG_IGNORE_Os_NEEDS_COMMENT
for -Os related change.
diff --git a/resolv/res_send.c b/resolv/res_send.c
index 4ec8c1a..e96d5d4 100644
--- a/resolv/res_send.c
+++ b/resolv/res_send.c
@@ -664,7 +664,7 @@ send_vc(res_state statp,
a false-positive.
*/
DIAG_PUSH_NEEDS_COMMENT;
- DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
+ DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
int resplen;
DIAG_POP_NEEDS_COMMENT;
struct iovec iov[4];
@@ -937,7 +937,7 @@ reopen (res_state statp, int *terrno, int ns)
the function return -1 before control flow reaches
the call to connect with slen. */
DIAG_PUSH_NEEDS_COMMENT;
- DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
+ DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
if (connect(EXT(statp).nssocks[ns], nsap, slen) < 0) {
DIAG_POP_NEEDS_COMMENT;
Aerror(statp, stderr, "connect(dg)", errno, nsap);
---
Cheers,
Carlos.
next prev parent reply other threads:[~2016-11-02 17:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 4:48 [PATCH] Fix -Os related -Werror failures Carlos O'Donell
2016-10-28 6:25 ` Andreas Schwab
2016-10-28 6:32 ` Florian Weimer
2016-10-28 6:44 ` Jeff Law
2016-10-28 8:12 ` Arnd Bergmann
2016-10-28 8:17 ` Andrew Pinski
2016-10-28 13:28 ` Jeff Law
2016-10-28 20:10 ` Paul Eggert
2016-10-29 3:03 ` Jeff Law
2016-10-30 4:25 ` Paul Eggert
2016-10-28 12:09 ` Carlos O'Donell
2016-10-28 12:43 ` Florian Weimer
2016-10-28 13:04 ` Joseph Myers
2016-10-28 13:07 ` Carlos O'Donell
2016-10-28 12:49 ` Joseph Myers
2016-10-28 12:55 ` Florian Weimer
2016-10-28 13:18 ` Carlos O'Donell
2016-10-28 13:58 ` [PATCH v2] Fix -Os related build and test failures Carlos O'Donell
2016-10-28 14:17 ` Joseph Myers
2016-10-29 2:59 ` [PATCH v3] " Carlos O'Donell
2016-10-29 3:26 ` Carlos O'Donell
2016-10-29 17:35 ` Joseph Myers
2016-10-30 3:51 ` [PATCH v4] " Carlos O'Donell
2016-10-31 8:33 ` Andreas Schwab
2016-10-31 9:16 ` Carlos O'Donell
2016-10-31 9:22 ` Florian Weimer
2016-10-31 12:56 ` David Miller
2016-10-31 19:56 ` Carlos O'Donell
2016-11-01 22:59 ` Joseph Myers
2016-11-02 12:52 ` Carlos O'Donell
2016-11-01 9:17 ` Andreas Schwab
2016-11-01 11:13 ` Joseph Myers
2016-11-01 15:58 ` Tamar Christina
2016-11-01 16:06 ` David Miller
2016-11-01 16:15 ` Tamar Christina
2016-11-02 11:53 ` Carlos O'Donell
2016-11-02 17:03 ` Carlos O'Donell [this message]
2016-11-02 13:22 ` Carlos O'Donell
2016-10-31 18:38 ` [PATCH v3] " Steve Ellcey
2016-10-31 19:50 ` Carlos O'Donell
2016-10-31 19:57 ` Steve Ellcey
2016-10-31 20:50 ` Carlos O'Donell
2016-10-31 21:00 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b550f9-e5f0-ced0-38e9-022ccf3813b8@redhat.com \
--to=carlos@redhat.com \
--cc=Bin.Cheng@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=davem@davemloft.net \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).