From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix -Os related -Werror failures.
Date: Fri, 28 Oct 2016 13:04:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610281258180.32491@digraph.polyomino.org.uk> (raw)
In-Reply-To: <f2153190-d62b-e04f-feae-39ed52c93589@redhat.com>
On Fri, 28 Oct 2016, Carlos O'Donell wrote:
> I agree that we can't account for _all_ optimizations someone might want
> to disable in their build, but I think it is a reasonable goal to target
> a few key _default_ optimization including -O3, -O2, and -Os.
And -O1 (bug 19444). And -Og for debuggability.
> I agree with Arnd that this code is _overly_ complex and could be
> rewritten such that it's a little clearer and makes sense to the compiler
> at -Os.
In general, making code clearer is a good approach.
For -O1 / -Og I'd also be willing to consider default initializers as a
less verbose way than DIAG_* macros of making it obvious to the compiler
that a variable is initialized (at -Os, that may not be such a good idea
because presumably the user cares about saving a few instructions from an
unnecessary initialization).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-10-28 13:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 4:48 Carlos O'Donell
2016-10-28 6:25 ` Andreas Schwab
2016-10-28 6:32 ` Florian Weimer
2016-10-28 6:44 ` Jeff Law
2016-10-28 8:12 ` Arnd Bergmann
2016-10-28 8:17 ` Andrew Pinski
2016-10-28 13:28 ` Jeff Law
2016-10-28 20:10 ` Paul Eggert
2016-10-29 3:03 ` Jeff Law
2016-10-30 4:25 ` Paul Eggert
2016-10-28 12:09 ` Carlos O'Donell
2016-10-28 12:43 ` Florian Weimer
2016-10-28 13:04 ` Joseph Myers [this message]
2016-10-28 13:07 ` Carlos O'Donell
2016-10-28 12:49 ` Joseph Myers
2016-10-28 12:55 ` Florian Weimer
2016-10-28 13:18 ` Carlos O'Donell
2016-10-28 13:58 ` [PATCH v2] Fix -Os related build and test failures Carlos O'Donell
2016-10-28 14:17 ` Joseph Myers
2016-10-29 2:59 ` [PATCH v3] " Carlos O'Donell
2016-10-29 3:26 ` Carlos O'Donell
2016-10-29 17:35 ` Joseph Myers
2016-10-30 3:51 ` [PATCH v4] " Carlos O'Donell
2016-10-31 8:33 ` Andreas Schwab
2016-10-31 9:16 ` Carlos O'Donell
2016-10-31 9:22 ` Florian Weimer
2016-10-31 12:56 ` David Miller
2016-10-31 19:56 ` Carlos O'Donell
2016-11-01 22:59 ` Joseph Myers
2016-11-02 12:52 ` Carlos O'Donell
2016-11-01 9:17 ` Andreas Schwab
2016-11-01 11:13 ` Joseph Myers
2016-11-01 15:58 ` Tamar Christina
2016-11-01 16:06 ` David Miller
2016-11-01 16:15 ` Tamar Christina
2016-11-02 11:53 ` Carlos O'Donell
2016-11-02 17:03 ` Carlos O'Donell
2016-11-02 13:22 ` Carlos O'Donell
2016-10-31 18:38 ` [PATCH v3] " Steve Ellcey
2016-10-31 19:50 ` Carlos O'Donell
2016-10-31 19:57 ` Steve Ellcey
2016-10-31 20:50 ` Carlos O'Donell
2016-10-31 21:00 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610281258180.32491@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).