From: Carlos O'Donell <carlos@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: schwab@suse.de, joseph@codesourcery.com, fweimer@redhat.com,
libc-alpha@sourceware.org
Subject: Re: [PATCH v4] Fix -Os related build and test failures.
Date: Mon, 31 Oct 2016 19:56:00 -0000 [thread overview]
Message-ID: <523b1244-6144-ede6-6c94-6515fd093ea6@redhat.com> (raw)
In-Reply-To: <20161031.085559.1939678123281578460.davem@davemloft.net>
On 10/31/2016 08:55 AM, David Miller wrote:
> From: Carlos O'Donell <carlos@redhat.com>
> Date: Mon, 31 Oct 2016 05:16:29 -0400
>
>> On 10/31/2016 04:33 AM, Andreas Schwab wrote:
>>> https://build.opensuse.org/project/monitor/home:Andreas_Schwab:glibc
>>>
>>> In file included from strxfrm_l.c:48:0:
>>> ../locale/weight.h: In function Β‘findidxΒ’:
>>> ../locale/weight.h:69:4: error: Β‘DIAG_PUSH_NEEDS_COMMENTΒ’ undeclared (first use in this function)
>>> DIAG_PUSH_NEEDS_COMMENT;
>>> ^~~~~~~~~~~~~~~~~~~~~~~
>>> ../locale/weight.h:69:4: note: each undeclared identifier is reported only once for each function it appears in
>>> ../locale/weight.h:70:4: error: implicit declaration of function Β‘DIAG_IGNORE_Os_NEEDS_COMMENTΒ’ [-Werror=implicit-function-declaration]
>>> DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> ../locale/weight.h:74:4: error: Β‘DIAG_POP_NEEDS_COMMENTΒ’ undeclared (first use in this function)
>>> DIAG_POP_NEEDS_COMMENT;
>>> ^~~~~~~~~~~~~~~~~~~~~~
>>
>> I'm fixing this. I don't know why this didn't fail on my x86_64 build.
>>
>> I'm moving the #include <libc-internal.h> into the weight header fragments.
>
> The thread debugging header nptl_db/thread_dbP.h needs it too.
Yes. I'm fixing any file to include the header as required.
I was too clever in thinking I could elide it for header
fragments included in other source files, I should have just
followed the rules we had in place "if it needs it it should
include it" since that fixed the messes we previously had.
I'm going to setup a non-x86_64 cross-build to test this.
I think I can do it easily enough on Fedora so I can keep
it up to date for upstream builds.
Cheers,
Carlos.
next prev parent reply other threads:[~2016-10-31 19:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 4:48 [PATCH] Fix -Os related -Werror failures Carlos O'Donell
2016-10-28 6:25 ` Andreas Schwab
2016-10-28 6:32 ` Florian Weimer
2016-10-28 6:44 ` Jeff Law
2016-10-28 8:12 ` Arnd Bergmann
2016-10-28 8:17 ` Andrew Pinski
2016-10-28 13:28 ` Jeff Law
2016-10-28 20:10 ` Paul Eggert
2016-10-29 3:03 ` Jeff Law
2016-10-30 4:25 ` Paul Eggert
2016-10-28 12:09 ` Carlos O'Donell
2016-10-28 12:43 ` Florian Weimer
2016-10-28 13:04 ` Joseph Myers
2016-10-28 13:07 ` Carlos O'Donell
2016-10-28 12:49 ` Joseph Myers
2016-10-28 12:55 ` Florian Weimer
2016-10-28 13:18 ` Carlos O'Donell
2016-10-28 13:58 ` [PATCH v2] Fix -Os related build and test failures Carlos O'Donell
2016-10-28 14:17 ` Joseph Myers
2016-10-29 2:59 ` [PATCH v3] " Carlos O'Donell
2016-10-29 3:26 ` Carlos O'Donell
2016-10-29 17:35 ` Joseph Myers
2016-10-30 3:51 ` [PATCH v4] " Carlos O'Donell
2016-10-31 8:33 ` Andreas Schwab
2016-10-31 9:16 ` Carlos O'Donell
2016-10-31 9:22 ` Florian Weimer
2016-10-31 12:56 ` David Miller
2016-10-31 19:56 ` Carlos O'Donell [this message]
2016-11-01 22:59 ` Joseph Myers
2016-11-02 12:52 ` Carlos O'Donell
2016-11-01 9:17 ` Andreas Schwab
2016-11-01 11:13 ` Joseph Myers
2016-11-01 15:58 ` Tamar Christina
2016-11-01 16:06 ` David Miller
2016-11-01 16:15 ` Tamar Christina
2016-11-02 11:53 ` Carlos O'Donell
2016-11-02 17:03 ` Carlos O'Donell
2016-11-02 13:22 ` Carlos O'Donell
2016-10-31 18:38 ` [PATCH v3] " Steve Ellcey
2016-10-31 19:50 ` Carlos O'Donell
2016-10-31 19:57 ` Steve Ellcey
2016-10-31 20:50 ` Carlos O'Donell
2016-10-31 21:00 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523b1244-6144-ede6-6c94-6515fd093ea6@redhat.com \
--to=carlos@redhat.com \
--cc=davem@davemloft.net \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).