* Re:[PATCH v2] MIPS: Sync elf.h from binutils
@ 2023-05-16 9:12 Ying Huang
2023-06-01 9:17 ` [PATCH " Ying Huang
0 siblings, 1 reply; 7+ messages in thread
From: Ying Huang @ 2023-05-16 9:12 UTC (permalink / raw)
To: fweimer, libc-alpha
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
HI,
> >/+#define EF_MIPS_MACH 0x00FF0000 /* Machine variant if we know it. This field was invented at Cygnus, />/+ but it is hoped that other vendors will adopt it. If some standard />/+ is developed, this code should be changed to follow it. */ />/+#define E_MIPS_MACH_3900 0x00810000 /* Cygnus is choosing values between 80 and 9F; />/+ 00 - 7F should be left for a future standard; />/+ the rest are open. */ /
> Surely after around 25 years, these comments can be more precise?
OK, I would delete the comments.
>
> >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. */ />/+ />/+ /* Floating-point ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_FP = 4, />/+ />/+ /* MSA ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_MSA = 8, />/+}; />/+ />/+/* Object attribute values. */ />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+ />/+ /* Not tagged or not using any ABIs affected by the differences. */ />/+ Val_GNU_MIPS_ABI_MSA_ANY = 0, />/+ />/+ /* Using 128-bit MSA. */ />/+ Val_GNU_MIPS_ABI_MSA_128 = 1, />/+}; /
> Any reason for using enum constants here, and not #define? I understand
> there is other MIPS precedent, but why continue in this direction?
>
> Thanks,
>
OK, I would change it to #define && submit PATCH v3.
Thanks,
Ying
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-05-16 9:12 Re:[PATCH v2] MIPS: Sync elf.h from binutils Ying Huang
@ 2023-06-01 9:17 ` Ying Huang
2023-06-01 9:21 ` Florian Weimer
0 siblings, 1 reply; 7+ messages in thread
From: Ying Huang @ 2023-06-01 9:17 UTC (permalink / raw)
To: fweimer, libc-alpha; +Cc: yunqiang.su
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
Hi,
> >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. */ />/+ />/+ /* Floating-point ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_FP = 4, />/+ />/+ /* MSA ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_MSA = 8, />/+}; />/+ />/+/* Object attribute values. */ />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+ />/+ /* Not tagged or not using any ABIs affected by the differences. */ />/+ Val_GNU_MIPS_ABI_MSA_ANY = 0, />/+ />/+ /* Using 128-bit MSA. */ />/+ Val_GNU_MIPS_ABI_MSA_128 = 1, />/+}; /
> Any reason for using enum constants here, and not #define? I understand
> there is other MIPS precedent, but why continue in this direction?
>
> Thanks,
> Florian
I wish to keep same with binutils.
Thanks,
Ying
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-06-01 9:17 ` [PATCH " Ying Huang
@ 2023-06-01 9:21 ` Florian Weimer
2023-06-01 9:40 ` Ying Huang
0 siblings, 1 reply; 7+ messages in thread
From: Florian Weimer @ 2023-06-01 9:21 UTC (permalink / raw)
To: Ying Huang; +Cc: libc-alpha, yunqiang.su
* Ying Huang:
> Hi,
>
>> >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. */ />/+ />/+ /*
> Floating-point ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_FP = 4, />/+ />/+ /* MSA
> ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_MSA = 8, />/+}; />/+ />/+/* Object
> attribute values. */ />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+
> />/+ /* Not tagged or not using any ABIs affected by the differences. */ />/+
> Val_GNU_MIPS_ABI_MSA_ANY = 0, />/+ />/+ /* Using 128-bit MSA. */ />/+
> Val_GNU_MIPS_ABI_MSA_128 = 1, />/+}; /
>> Any reason for using enum constants here, and not #define? I understand
>> there is other MIPS precedent, but why continue in this direction?
>>
>> Thanks,
>> Florian
>
> I wish to keep same with binutils.
Fine by me.
Thanks,
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-06-01 9:21 ` Florian Weimer
@ 2023-06-01 9:40 ` Ying Huang
2023-06-01 10:32 ` Florian Weimer
0 siblings, 1 reply; 7+ messages in thread
From: Ying Huang @ 2023-06-01 9:40 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, yunqiang.su
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi Florian,
在 2023/6/1 17:21, Florian Weimer 写道:
> * Ying Huang:
>
>> Hi,
>>
>>>> /+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. */ />/+ />/+ /*
>> Floating-point ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_FP = 4, />/+ />/+ /* MSA
>> ABI used by this object file. */ />/+ Tag_GNU_MIPS_ABI_MSA = 8, />/+}; />/+ />/+/* Object
>> attribute values. */ />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+
>> />/+ /* Not tagged or not using any ABIs affected by the differences. */ />/+
>> Val_GNU_MIPS_ABI_MSA_ANY = 0, />/+ />/+ /* Using 128-bit MSA. */ />/+
>> Val_GNU_MIPS_ABI_MSA_128 = 1, />/+}; /
>>> Any reason for using enum constants here, and not #define? I understand
>>> there is other MIPS precedent, but why continue in this direction?
>>>
>>> Thanks,
>>> Florian
>> I wish to keep same with binutils.
> Fine by me.
>
> Thanks,
> Florian
Could you help commit PATCH v2?
Thanks,
Ying
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-06-01 9:40 ` Ying Huang
@ 2023-06-01 10:32 ` Florian Weimer
2023-06-01 10:46 ` 黄莺
2023-06-28 1:43 ` Ying Huang
0 siblings, 2 replies; 7+ messages in thread
From: Florian Weimer @ 2023-06-01 10:32 UTC (permalink / raw)
To: Ying Huang; +Cc: libc-alpha, yunqiang.su
* Ying Huang:
> Could you help commit PATCH v2?
Is this contribution covered by an FSF copyright assignment?
Thanks,
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-06-01 10:32 ` Florian Weimer
@ 2023-06-01 10:46 ` 黄莺
2023-06-28 1:43 ` Ying Huang
1 sibling, 0 replies; 7+ messages in thread
From: 黄莺 @ 2023-06-01 10:46 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, 苏运强
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Yes, the entire company signed the fsf copyright assignment.
Thanks,
Ying
> From:"Florian Weimer"<fweimer@redhat.com>
> Date:Thu, Jun 1, 18:32
> Subject:Re: [PATCH v2] MIPS: Sync elf.h from binutils
> To:"Ying Huang"<ying.huang@oss.cipunited.com>
> Cc:<libc-alpha@sourceware.org>,<yunqiang.su@oss.cipunited.com>
> * Ying Huang:
>
> > Could you help commit PATCH v2?
>
> Is this contribution covered by an FSF copyright assignment?
>
> Thanks,
> Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] MIPS: Sync elf.h from binutils
2023-06-01 10:32 ` Florian Weimer
2023-06-01 10:46 ` 黄莺
@ 2023-06-28 1:43 ` Ying Huang
1 sibling, 0 replies; 7+ messages in thread
From: Ying Huang @ 2023-06-28 1:43 UTC (permalink / raw)
To: Florian Weimer, Libc-alpha; +Cc: yunqiang.su
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
Hi Florian,
在 2023/6/1 18:32, Florian Weimer 写道:
> * Ying Huang:
>
>> Could you help commit PATCH v2?
> Is this contribution covered by an FSF copyright assignment?
>
> Thanks,
> Florian
Yes, the entire company signed the fsf copyright assignment.
I have submitted patch v6, adjust all align issues and do make check.
Could you help commit patch v6?
Thanks,
Ying
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-28 1:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 9:12 Re:[PATCH v2] MIPS: Sync elf.h from binutils Ying Huang
2023-06-01 9:17 ` [PATCH " Ying Huang
2023-06-01 9:21 ` Florian Weimer
2023-06-01 9:40 ` Ying Huang
2023-06-01 10:32 ` Florian Weimer
2023-06-01 10:46 ` 黄莺
2023-06-28 1:43 ` Ying Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).