Re: [PATCH v2] Replace {u}int_fast{16|32} with {u}int32_t

[Florian Weimer <fweimer@redhat.com>]

* Noah Goldstein via Libc-alpha:

> @@ -558,10 +558,10 @@ skip:
>  }
>  
>  
> -static uint_fast32_t
> +static uint32_t
>  dl_new_hash (const char *s)
>  {
> -  uint_fast32_t h = 5381;
> +  uint32_t h = 5381;
>    for (unsigned char c = *s; c != '\0'; c = *++s)
>      h = h * 33 + c;
>    return h & 0xffffffff;

I think you can remove the final masking.

> diff --git a/resolv/nss_dns/dns-canon.c b/resolv/nss_dns/dns-canon.c
> index 3151e50ae1..53230c5599 100644
> --- a/resolv/nss_dns/dns-canon.c
> +++ b/resolv/nss_dns/dns-canon.c
> @@ -118,7 +118,7 @@ _nss_dns_getcanonname_r (const char *name, char *buffer, size_t buflen,
>  		goto unavail;
>  
>  	      /* Check whether type and class match.  */
> -	      uint_fast16_t type;
> +	      unsigned int type;
>  	      NS_GET16 (type, ptr);
>  	      if (type == qtypes[i])
>  		{

This should uint16_t because DNS record types are 16-bit only.

> diff --git a/timezone/zic.c b/timezone/zic.c
> index 2875b5544c..16d0cede65 100644
> --- a/timezone/zic.c
> +++ b/timezone/zic.c
> @@ -1789,7 +1789,7 @@ rulesub(struct rule *rp, const char *loyearp, const char *hiyearp,
>  }
>  
>  static void
> -convert(const int_fast32_t val, char *const buf)
> +convert(const int32_t val, char *const buf)
>  {
>  	register int	i;
>  	register int	shift;
> @@ -1811,7 +1811,7 @@ convert64(const zic_t val, char *const buf)
>  }
>  
>  static void
> -puttzcode(const int_fast32_t val, FILE *const fp)
> +puttzcode(const int32_t val, FILE *const fp)
>  {
>  	char	buf[4];

Has Paul commented on this?  This code is shared with the tz project.

Otherwise looks good.  Still builds on all architectures.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian