public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t
Date: Wed, 13 Apr 2022 12:11:47 -0700	[thread overview]
Message-ID: <56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu> (raw)
In-Reply-To: <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>

On 4/13/22 08:23, Noah Goldstein wrote:

>> Both, I expect. We can assume int is at least 32 bits.
> 
> Disagree with that a bit. fast32 is saving pretty specifically at least 32 bits
> which int doesn't say but int32_t does.

I thought the idea was to not worry about losing the 16-bit vs 32-bit vs 
whatever info, since it doesn't really matter and keeping the info 
around just encourages bikeshedding later.

If we want to keep that info then we should create private types like 
glibc_int_fast32_t as I mentioned earlier. If not, let's just use 'int'.


> Can you confirm all the tz changes are okay?

Oh, sorry, I didn't notice that you were changing zic.c.

Unfortunately the zic.c changes are not OK, as zic.c is supposed to 
portable to platforms that lack int32_t (the C standard allows such 
platforms).

  parent reply	other threads:[~2022-04-13 19:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 16:58 Noah Goldstein
2022-04-11 18:07 ` Paul Eggert
2022-04-11 21:24   ` Noah Goldstein
     [not found]   ` <CAFUsyfJ7Zba--qet3yzROomaf8Zdq-qhXAgS6=534nobws8fJg@mail.gmail.com>
     [not found]     ` <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu>
     [not found]       ` <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
2022-04-13 19:11         ` Paul Eggert [this message]
2022-04-13 23:28           ` Noah Goldstein
2022-04-13 23:38             ` Paul Eggert
2022-04-14  0:00               ` Noah Goldstein
2022-04-11 21:23 ` [PATCH v2] " Noah Goldstein
2022-04-12  9:50   ` Florian Weimer
2022-04-13 16:11     ` Noah Goldstein
2022-04-13 16:10 ` [PATCH v3] " Noah Goldstein
2022-04-13 23:28 ` [PATCH v4] " Noah Goldstein
2022-04-13 23:59 ` [PATCH v5] " Noah Goldstein
2022-04-14  0:41   ` Paul Eggert
2022-04-14  0:46     ` Noah Goldstein
2022-04-14  0:46 ` [PATCH v6] " Noah Goldstein
2022-04-14  1:13   ` Paul Eggert
2022-04-14  3:21     ` Noah Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56ae0132-0509-31a9-a003-29c752575332@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=goldstein.w.n@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).