public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t
Date: Wed, 13 Apr 2022 19:00:33 -0500	[thread overview]
Message-ID: <CAFUsyf+TorjzMm2sXhWNsc_25Ghq6vPNgWhb2y2hoH+ZTuxpeg@mail.gmail.com> (raw)
In-Reply-To: <5e6e21de-b437-35fd-7f5a-d08400f93e1e@cs.ucla.edu>

On Wed, Apr 13, 2022 at 6:38 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
>
> On 4/13/22 16:28, Noah Goldstein wrote:
> > he reason not replacing fast32 with int is int can be 2-bytes so it can
> > be incorrect.
>
> No, int cannot be 2 8-bit bytes in GNU code. GNU code can assume that
> int is at least 32 bits. See the first paragraph of:
>
> https://www.gnu.org/prep/standards/html_node/CPU-Portability.html
>
> Similarly, POSIX code can assume that int is at least 32 bits; look for
> "INT_MIN" and "INT_MAX" in:
>
> https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html

Okay, fixed in v5 to use int/unsigned int unless it very obviously
went against the
style of the function.

  reply	other threads:[~2022-04-14  0:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 16:58 Noah Goldstein
2022-04-11 18:07 ` Paul Eggert
2022-04-11 21:24   ` Noah Goldstein
     [not found]   ` <CAFUsyfJ7Zba--qet3yzROomaf8Zdq-qhXAgS6=534nobws8fJg@mail.gmail.com>
     [not found]     ` <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu>
     [not found]       ` <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
2022-04-13 19:11         ` Paul Eggert
2022-04-13 23:28           ` Noah Goldstein
2022-04-13 23:38             ` Paul Eggert
2022-04-14  0:00               ` Noah Goldstein [this message]
2022-04-11 21:23 ` [PATCH v2] " Noah Goldstein
2022-04-12  9:50   ` Florian Weimer
2022-04-13 16:11     ` Noah Goldstein
2022-04-13 16:10 ` [PATCH v3] " Noah Goldstein
2022-04-13 23:28 ` [PATCH v4] " Noah Goldstein
2022-04-13 23:59 ` [PATCH v5] " Noah Goldstein
2022-04-14  0:41   ` Paul Eggert
2022-04-14  0:46     ` Noah Goldstein
2022-04-14  0:46 ` [PATCH v6] " Noah Goldstein
2022-04-14  1:13   ` Paul Eggert
2022-04-14  3:21     ` Noah Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFUsyf+TorjzMm2sXhWNsc_25Ghq6vPNgWhb2y2hoH+ZTuxpeg@mail.gmail.com \
    --to=goldstein.w.n@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).