From: Paul Eggert <eggert@cs.ucla.edu>
To: Noah Goldstein <goldstein.w.n@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v5] Replace {u}int_fast{16|32} with {u}int32_t
Date: Wed, 13 Apr 2022 17:41:22 -0700 [thread overview]
Message-ID: <bb2e5760-2d47-a603-6444-57563cc85651@cs.ucla.edu> (raw)
In-Reply-To: <20220413235931.394191-1-goldstein.w.n@gmail.com>
On 4/13/22 16:59, Noah Goldstein via Libc-alpha wrote:
> - return h & 0xffffffff;
> + return h;
Please omit this change, as the "& 0xffffffff" is needed on
(admittedly-hypothetical) hosts where unsigned int is wider than 32
bits, which POSIX allows. Omitting this change shouldn't affect the
generated machine code on typical platforms.
> - uint_fast16_t type;
> + uint16_t type;
Since 'type' is compared to qtypes[i] which is 'short int', I suggest
using 'short int' here instead.
Otherwise, looks good; thanks.
A bigger cleanup would replace a lot of the 'uint32_t' stuff with
'unsigned', as a good deal of the code seems to be written under the
mistaken assumption that int can be only 16 bits, but that's low priority.
next prev parent reply other threads:[~2022-04-14 0:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 16:58 [PATCH v1] " Noah Goldstein
2022-04-11 18:07 ` Paul Eggert
2022-04-11 21:24 ` Noah Goldstein
[not found] ` <CAFUsyfJ7Zba--qet3yzROomaf8Zdq-qhXAgS6=534nobws8fJg@mail.gmail.com>
[not found] ` <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu>
[not found] ` <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
2022-04-13 19:11 ` Paul Eggert
2022-04-13 23:28 ` Noah Goldstein
2022-04-13 23:38 ` Paul Eggert
2022-04-14 0:00 ` Noah Goldstein
2022-04-11 21:23 ` [PATCH v2] " Noah Goldstein
2022-04-12 9:50 ` Florian Weimer
2022-04-13 16:11 ` Noah Goldstein
2022-04-13 16:10 ` [PATCH v3] " Noah Goldstein
2022-04-13 23:28 ` [PATCH v4] " Noah Goldstein
2022-04-13 23:59 ` [PATCH v5] " Noah Goldstein
2022-04-14 0:41 ` Paul Eggert [this message]
2022-04-14 0:46 ` Noah Goldstein
2022-04-14 0:46 ` [PATCH v6] " Noah Goldstein
2022-04-14 1:13 ` Paul Eggert
2022-04-14 3:21 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb2e5760-2d47-a603-6444-57563cc85651@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).