From: Paul Eggert <eggert@cs.ucla.edu>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v1] Replace {u}int_fast{16|32} with {u}int32_t
Date: Mon, 11 Apr 2022 11:07:19 -0700 [thread overview]
Message-ID: <9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu> (raw)
In-Reply-To: <20220411165835.4028009-1-goldstein.w.n@gmail.com>
On 4/11/22 09:58, Noah Goldstein via Libc-alpha wrote:
> - uint_fast16_t stack_flags = DEFAULT_STACK_PERMS;
> + uint32_t stack_flags = DEFAULT_STACK_PERMS;
Doesn't this lose width info - or worse, add misleading info? For this
particular case it looks like we need 32 bits, when we don't.
If we want to lose info, it'd be simpler to use plain 'int' and
'unsigned int' for situations like these. That's less misleading.
If we don't want to lose info, it'd be better to define private types
like glibc_uint_fast16_t and use these private types to address
efficiency concerns.
I prefer losing the width info here, as this will cause less
bikeshedding in the future. But if we want to keep width info, surely we
should not make it more misleading.
next prev parent reply other threads:[~2022-04-11 18:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 16:58 Noah Goldstein
2022-04-11 18:07 ` Paul Eggert [this message]
2022-04-11 21:24 ` Noah Goldstein
[not found] ` <CAFUsyfJ7Zba--qet3yzROomaf8Zdq-qhXAgS6=534nobws8fJg@mail.gmail.com>
[not found] ` <92b7db75-0536-d28b-0618-34519305223b@cs.ucla.edu>
[not found] ` <CAFUsyfKg2ZD3JC9sCnoDa3qFtjCwzWVZaiW+5WeWrB_kOTWXuQ@mail.gmail.com>
2022-04-13 19:11 ` Paul Eggert
2022-04-13 23:28 ` Noah Goldstein
2022-04-13 23:38 ` Paul Eggert
2022-04-14 0:00 ` Noah Goldstein
2022-04-11 21:23 ` [PATCH v2] " Noah Goldstein
2022-04-12 9:50 ` Florian Weimer
2022-04-13 16:11 ` Noah Goldstein
2022-04-13 16:10 ` [PATCH v3] " Noah Goldstein
2022-04-13 23:28 ` [PATCH v4] " Noah Goldstein
2022-04-13 23:59 ` [PATCH v5] " Noah Goldstein
2022-04-14 0:41 ` Paul Eggert
2022-04-14 0:46 ` Noah Goldstein
2022-04-14 0:46 ` [PATCH v6] " Noah Goldstein
2022-04-14 1:13 ` Paul Eggert
2022-04-14 3:21 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a1dd0bc-57cc-0fa7-0d61-1b9cbae247a0@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).