* [PATCH] Remove the unnecessary +make-deps
@ 2021-11-06 13:50 H.J. Lu
2021-11-08 16:01 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2021-11-06 13:50 UTC (permalink / raw)
To: libc-alpha
Since
commit d73f5331ce5370ca5a879229e3842f5de98689cd
Author: Roland McGrath <roland@gnu.org>
Date: Fri May 2 02:20:45 2003 +0000
2003-05-01 Roland McGrath <roland@redhat.com>
dependency is generated by passing -MD -MF to compiler. Remove
+make-deps which is no longer unnecessary.
---
Makerules | 9 ---------
sysdeps/unix/Makefile | 4 ----
2 files changed, 13 deletions(-)
diff --git a/Makerules b/Makerules
index 3503605a8e..8db0ca1296 100644
--- a/Makerules
+++ b/Makerules
@@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
# get the wrong predefines.
S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
-define +make-deps
-$(make-target-directory)
-$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
- $(CPPFLAGS) $($(patsubst .%,%,$(suffix $(<F)))-CPPFLAGS) | sed -e\
-'s,$(subst .,\.,$(@F:.d=.o)),$(foreach o,$(all-object-suffixes),$(@:.d=$o)) $@,' \
-$(sed-remove-objpfx) $(sed-remove-dotdot) > $(@:.d=.T)
-mv -f $(@:.d=.T) $@
-endef
-
ifneq (,$(objpfx))
# Continuation lines here are dangerous because they introduce spaces!
define sed-remove-objpfx
diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
index 2ee3be7237..582baa4bd8 100644
--- a/sysdeps/unix/Makefile
+++ b/sysdeps/unix/Makefile
@@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
mv -f $@T $@
endif
-$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
- $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
- $(+make-deps)
-
postclean-generated += sysd-syscalls
endif
--
2.33.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Remove the unnecessary +make-deps
2021-11-06 13:50 [PATCH] Remove the unnecessary +make-deps H.J. Lu
@ 2021-11-08 16:01 ` Andreas Schwab
2021-11-08 16:12 ` H.J. Lu
2021-11-08 18:42 ` H.J. Lu
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Schwab @ 2021-11-08 16:01 UTC (permalink / raw)
To: H.J. Lu via Libc-alpha
On Nov 06 2021, H.J. Lu via Libc-alpha wrote:
> diff --git a/Makerules b/Makerules
> index 3503605a8e..8db0ca1296 100644
> --- a/Makerules
> +++ b/Makerules
> @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
> # get the wrong predefines.
> S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
>
> -define +make-deps
> -$(make-target-directory)
> -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
This was the last use of +mkdep.
> diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
> index 2ee3be7237..582baa4bd8 100644
> --- a/sysdeps/unix/Makefile
> +++ b/sysdeps/unix/Makefile
> @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
> mv -f $@T $@
> endif
>
> -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
> - $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
This was the last reference to sysdeps/unix/s-proto.S and
sysdeps/unix/s-proto-cancel.S.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove the unnecessary +make-deps
2021-11-08 16:01 ` Andreas Schwab
@ 2021-11-08 16:12 ` H.J. Lu
2021-11-08 18:42 ` H.J. Lu
1 sibling, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2021-11-08 16:12 UTC (permalink / raw)
To: Andreas Schwab; +Cc: H.J. Lu via Libc-alpha
On Mon, Nov 8, 2021 at 8:01 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Nov 06 2021, H.J. Lu via Libc-alpha wrote:
>
> > diff --git a/Makerules b/Makerules
> > index 3503605a8e..8db0ca1296 100644
> > --- a/Makerules
> > +++ b/Makerules
> > @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
> > # get the wrong predefines.
> > S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
> >
> > -define +make-deps
> > -$(make-target-directory)
> > -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
>
> This was the last use of +mkdep.
>
> > diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
> > index 2ee3be7237..582baa4bd8 100644
> > --- a/sysdeps/unix/Makefile
> > +++ b/sysdeps/unix/Makefile
> > @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
> > mv -f $@T $@
> > endif
> >
> > -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
> > - $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
>
> This was the last reference to sysdeps/unix/s-proto.S and
> sysdeps/unix/s-proto-cancel.S.
>
> Andreas.
Is this an approval?
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove the unnecessary +make-deps
2021-11-08 16:01 ` Andreas Schwab
2021-11-08 16:12 ` H.J. Lu
@ 2021-11-08 18:42 ` H.J. Lu
1 sibling, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2021-11-08 18:42 UTC (permalink / raw)
To: Andreas Schwab; +Cc: H.J. Lu via Libc-alpha
On Mon, Nov 8, 2021 at 8:01 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Nov 06 2021, H.J. Lu via Libc-alpha wrote:
>
> > diff --git a/Makerules b/Makerules
> > index 3503605a8e..8db0ca1296 100644
> > --- a/Makerules
> > +++ b/Makerules
> > @@ -459,15 +459,6 @@ compile-stdin.c = $(COMPILE.c) -o $@ -x c - $(compile-mkdep-flags)
> > # get the wrong predefines.
> > S-CPPFLAGS = -DASSEMBLER $(asm-CPPFLAGS)
> >
> > -define +make-deps
> > -$(make-target-directory)
> > -$(+mkdep) $< $(if $(filter %.c,$<),$(CFLAGS)) \
>
> This was the last use of +mkdep.
>
> > diff --git a/sysdeps/unix/Makefile b/sysdeps/unix/Makefile
> > index 2ee3be7237..582baa4bd8 100644
> > --- a/sysdeps/unix/Makefile
> > +++ b/sysdeps/unix/Makefile
> > @@ -104,10 +104,6 @@ $(common-objpfx)sysd-syscalls: $(..)sysdeps/unix/make-syscalls.sh \
> > mv -f $@T $@
> > endif
> >
> > -$(common-objpfx)s-%.d: $(..)sysdeps/unix/s-%.S \
> > - $(wildcard $(+sysdep_dirs:%=%/syscalls.list))
>
> This was the last reference to sysdeps/unix/s-proto.S and
> sysdeps/unix/s-proto-cancel.S.
>
> Andreas.
>
The v2 patch is at
https://sourceware.org/pipermail/libc-alpha/2021-November/132816.html
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-08 18:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06 13:50 [PATCH] Remove the unnecessary +make-deps H.J. Lu
2021-11-08 16:01 ` Andreas Schwab
2021-11-08 16:12 ` H.J. Lu
2021-11-08 18:42 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).