public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH] riscv: Get level 3 cache's information
       [not found] <20221021072311.26918-1-zong.li@sifive.com>
@ 2022-10-21  7:28 ` Zong Li
  2022-11-02  1:58   ` Zong Li
  0 siblings, 1 reply; 6+ messages in thread
From: Zong Li @ 2022-10-21  7:28 UTC (permalink / raw)
  To: palmer, darius, andrew, dj, joseph, schwab,
	Florian Weimer via Libc-alpha

On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
>
> RISC-V architecture extends the cache information for level 3 cache
> in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
> the level 3 cache information.
> ---
>  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> index b768ebf781..4772a9fc11 100644
> --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
> +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> @@ -90,6 +90,13 @@ __sysconf (int name)
>         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
>        case _SC_LEVEL2_CACHE_LINESIZE:
>         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
> +      case _SC_LEVEL3_CACHE_SIZE:
> +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
> +      case _SC_LEVEL3_CACHE_ASSOC:
> +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
> +      case _SC_LEVEL3_CACHE_LINESIZE:
> +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
> +
>        default:
>         return linux_sysconf (name);
>      }
> --
> 2.17.1
>

Sorry for missing libc-alpha. Add libc-alpha in this loop.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: Get level 3 cache's information
  2022-10-21  7:28 ` [PATCH] riscv: Get level 3 cache's information Zong Li
@ 2022-11-02  1:58   ` Zong Li
  2022-11-02  2:19     ` Palmer Dabbelt
  0 siblings, 1 reply; 6+ messages in thread
From: Zong Li @ 2022-11-02  1:58 UTC (permalink / raw)
  To: palmer, darius, andrew, dj, joseph, schwab,
	Florian Weimer via Libc-alpha

On Fri, Oct 21, 2022 at 3:28 PM Zong Li <zong.li@sifive.com> wrote:
>
> On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
> >
> > RISC-V architecture extends the cache information for level 3 cache
> > in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
> > the level 3 cache information.
> > ---
> >  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> > index b768ebf781..4772a9fc11 100644
> > --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
> > +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> > @@ -90,6 +90,13 @@ __sysconf (int name)
> >         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
> >        case _SC_LEVEL2_CACHE_LINESIZE:
> >         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
> > +      case _SC_LEVEL3_CACHE_SIZE:
> > +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
> > +      case _SC_LEVEL3_CACHE_ASSOC:
> > +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
> > +      case _SC_LEVEL3_CACHE_LINESIZE:
> > +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
> > +
> >        default:
> >         return linux_sysconf (name);
> >      }
> > --
> > 2.17.1
> >

Hi all,
Because I didn't get any feedback here, could I know whether this
patch is good for all? Are you all willing to help me to pick it up if
it looks good to you? Thanks a lot :)

>
> Sorry for missing libc-alpha. Add libc-alpha in this loop.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: Get level 3 cache's information
  2022-11-02  1:58   ` Zong Li
@ 2022-11-02  2:19     ` Palmer Dabbelt
  2022-11-09  1:12       ` Zong Li
  0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2022-11-02  2:19 UTC (permalink / raw)
  To: zong.li; +Cc: Darius Rad, Andrew Waterman, dj, joseph, schwab, libc-alpha

On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote:
> On Fri, Oct 21, 2022 at 3:28 PM Zong Li <zong.li@sifive.com> wrote:
>>
>> On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
>> >
>> > RISC-V architecture extends the cache information for level 3 cache
>> > in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
>> > the level 3 cache information.
>> > ---
>> >  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
>> >  1 file changed, 7 insertions(+)
>> >
>> > diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>> > index b768ebf781..4772a9fc11 100644
>> > --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
>> > +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>> > @@ -90,6 +90,13 @@ __sysconf (int name)
>> >         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
>> >        case _SC_LEVEL2_CACHE_LINESIZE:
>> >         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
>> > +      case _SC_LEVEL3_CACHE_SIZE:
>> > +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
>> > +      case _SC_LEVEL3_CACHE_ASSOC:
>> > +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
>> > +      case _SC_LEVEL3_CACHE_LINESIZE:
>> > +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
>> > +
>> >        default:
>> >         return linux_sysconf (name);
>> >      }
>> > --
>> > 2.17.1
>> >
>
> Hi all,
> Because I didn't get any feedback here, could I know whether this
> patch is good for all? Are you all willing to help me to pick it up if
> it looks good to you? Thanks a lot :)

Sorry, for some reason I thought I'd replied to this one.

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks!

>> Sorry for missing libc-alpha. Add libc-alpha in this loop.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: Get level 3 cache's information
  2022-11-02  2:19     ` Palmer Dabbelt
@ 2022-11-09  1:12       ` Zong Li
  2022-11-09 14:42         ` Adhemerval Zanella Netto
  0 siblings, 1 reply; 6+ messages in thread
From: Zong Li @ 2022-11-09  1:12 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: Darius Rad, Andrew Waterman, dj, joseph, schwab, libc-alpha

On Wed, Nov 2, 2022 at 10:19 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote:
> > On Fri, Oct 21, 2022 at 3:28 PM Zong Li <zong.li@sifive.com> wrote:
> >>
> >> On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
> >> >
> >> > RISC-V architecture extends the cache information for level 3 cache
> >> > in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
> >> > the level 3 cache information.
> >> > ---
> >> >  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
> >> >  1 file changed, 7 insertions(+)
> >> >
> >> > diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> >> > index b768ebf781..4772a9fc11 100644
> >> > --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
> >> > +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
> >> > @@ -90,6 +90,13 @@ __sysconf (int name)
> >> >         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
> >> >        case _SC_LEVEL2_CACHE_LINESIZE:
> >> >         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
> >> > +      case _SC_LEVEL3_CACHE_SIZE:
> >> > +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
> >> > +      case _SC_LEVEL3_CACHE_ASSOC:
> >> > +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
> >> > +      case _SC_LEVEL3_CACHE_LINESIZE:
> >> > +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
> >> > +
> >> >        default:
> >> >         return linux_sysconf (name);
> >> >      }
> >> > --
> >> > 2.17.1
> >> >
> >
> > Hi all,
> > Because I didn't get any feedback here, could I know whether this
> > patch is good for all? Are you all willing to help me to pick it up if
> > it looks good to you? Thanks a lot :)
>
> Sorry, for some reason I thought I'd replied to this one.
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Thanks!

Hi Palmer, thanks a lot for your review. May I ask who might help me
to pick up this patch? I couldn't find this patch in master yet.

>
> >> Sorry for missing libc-alpha. Add libc-alpha in this loop.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: Get level 3 cache's information
  2022-11-09  1:12       ` Zong Li
@ 2022-11-09 14:42         ` Adhemerval Zanella Netto
  2022-11-09 21:11           ` Palmer Dabbelt
  0 siblings, 1 reply; 6+ messages in thread
From: Adhemerval Zanella Netto @ 2022-11-09 14:42 UTC (permalink / raw)
  To: Zong Li, Palmer Dabbelt
  Cc: Darius Rad, Andrew Waterman, dj, joseph, schwab, libc-alpha



On 08/11/22 22:12, Zong Li wrote:
> On Wed, Nov 2, 2022 at 10:19 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote:
>>> On Fri, Oct 21, 2022 at 3:28 PM Zong Li <zong.li@sifive.com> wrote:
>>>>
>>>> On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
>>>>>
>>>>> RISC-V architecture extends the cache information for level 3 cache
>>>>> in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
>>>>> the level 3 cache information.
>>>>> ---
>>>>>  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
>>>>>  1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>> index b768ebf781..4772a9fc11 100644
>>>>> --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>> +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>> @@ -90,6 +90,13 @@ __sysconf (int name)
>>>>>         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
>>>>>        case _SC_LEVEL2_CACHE_LINESIZE:
>>>>>         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
>>>>> +      case _SC_LEVEL3_CACHE_SIZE:
>>>>> +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
>>>>> +      case _SC_LEVEL3_CACHE_ASSOC:
>>>>> +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
>>>>> +      case _SC_LEVEL3_CACHE_LINESIZE:
>>>>> +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
>>>>> +
>>>>>        default:
>>>>>         return linux_sysconf (name);
>>>>>      }
>>>>> --
>>>>> 2.17.1
>>>>>
>>>
>>> Hi all,
>>> Because I didn't get any feedback here, could I know whether this
>>> patch is good for all? Are you all willing to help me to pick it up if
>>> it looks good to you? Thanks a lot :)
>>
>> Sorry, for some reason I thought I'd replied to this one.
>>
>> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
>> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>>
>> Thanks!
> 
> Hi Palmer, thanks a lot for your review. May I ask who might help me
> to pick up this patch? I couldn't find this patch in master yet.

I installed it, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] riscv: Get level 3 cache's information
  2022-11-09 14:42         ` Adhemerval Zanella Netto
@ 2022-11-09 21:11           ` Palmer Dabbelt
  0 siblings, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2022-11-09 21:11 UTC (permalink / raw)
  To: adhemerval.zanella
  Cc: zong.li, Darius Rad, Andrew Waterman, dj, joseph, schwab, libc-alpha

On Wed, 09 Nov 2022 06:42:03 PST (-0800), adhemerval.zanella@linaro.org wrote:
>
>
> On 08/11/22 22:12, Zong Li wrote:
>> On Wed, Nov 2, 2022 at 10:19 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>>
>>> On Tue, 01 Nov 2022 18:58:46 PDT (-0700), zong.li@sifive.com wrote:
>>>> On Fri, Oct 21, 2022 at 3:28 PM Zong Li <zong.li@sifive.com> wrote:
>>>>>
>>>>> On Fri, Oct 21, 2022 at 3:23 PM Zong Li <zong.li@sifive.com> wrote:
>>>>>>
>>>>>> RISC-V architecture extends the cache information for level 3 cache
>>>>>> in AUX vector in Linux v.6.1-rc1. This patch supports sysconf to get
>>>>>> the level 3 cache information.
>>>>>> ---
>>>>>>  sysdeps/unix/sysv/linux/riscv/sysconf.c | 7 +++++++
>>>>>>  1 file changed, 7 insertions(+)
>>>>>>
>>>>>> diff --git a/sysdeps/unix/sysv/linux/riscv/sysconf.c b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>>> index b768ebf781..4772a9fc11 100644
>>>>>> --- a/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>>> +++ b/sysdeps/unix/sysv/linux/riscv/sysconf.c
>>>>>> @@ -90,6 +90,13 @@ __sysconf (int name)
>>>>>>         return sysconf_get_cache_associativity (AT_L2_CACHEGEOMETRY);
>>>>>>        case _SC_LEVEL2_CACHE_LINESIZE:
>>>>>>         return sysconf_get_cache_linesize (AT_L2_CACHEGEOMETRY);
>>>>>> +      case _SC_LEVEL3_CACHE_SIZE:
>>>>>> +       return sysconf_get_cache_size (AT_L3_CACHESIZE);
>>>>>> +      case _SC_LEVEL3_CACHE_ASSOC:
>>>>>> +       return sysconf_get_cache_associativity (AT_L3_CACHEGEOMETRY);
>>>>>> +      case _SC_LEVEL3_CACHE_LINESIZE:
>>>>>> +       return sysconf_get_cache_linesize (AT_L3_CACHEGEOMETRY);
>>>>>> +
>>>>>>        default:
>>>>>>         return linux_sysconf (name);
>>>>>>      }
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>
>>>> Hi all,
>>>> Because I didn't get any feedback here, could I know whether this
>>>> patch is good for all? Are you all willing to help me to pick it up if
>>>> it looks good to you? Thanks a lot :)
>>>
>>> Sorry, for some reason I thought I'd replied to this one.
>>>
>>> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
>>> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>>>
>>> Thanks!
>>
>> Hi Palmer, thanks a lot for your review. May I ask who might help me
>> to pick up this patch? I couldn't find this patch in master yet.
>
> I installed it, thanks.

Thanks.  I'd actually managed to kick off a build yesterday but then 
forgot about it again (the build was fine).

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-11-09 21:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20221021072311.26918-1-zong.li@sifive.com>
2022-10-21  7:28 ` [PATCH] riscv: Get level 3 cache's information Zong Li
2022-11-02  1:58   ` Zong Li
2022-11-02  2:19     ` Palmer Dabbelt
2022-11-09  1:12       ` Zong Li
2022-11-09 14:42         ` Adhemerval Zanella Netto
2022-11-09 21:11           ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).