From: Stafford Horne <shorne@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v2 11/13] or1k: Build Infrastructure
Date: Sat, 20 Nov 2021 08:36:56 +0900 [thread overview]
Message-ID: <YZg1GDq00WB/PtnO@antec> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111182231450.1393807@digraph.polyomino.org.uk>
On Thu, Nov 18, 2021 at 10:34:10PM +0000, Joseph Myers wrote:
> On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote:
>
> > diff --git a/sysdeps/unix/sysv/linux/or1k/configure.ac b/sysdeps/unix/sysv/linux/or1k/configure.ac
> > new file mode 100644
> > index 0000000000..d439e7fd53
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/configure.ac
> > @@ -0,0 +1,4 @@
> > +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
> > +# Local configure fragment for sysdeps/unix/sysv/linux/or1k.
> > +
> > +arch_minimum_kernel=5.10.0
>
> This seems to be a lot more recent than when OpenRISC support was actually
> added to the Linux kernel, and also more recent than when 64-bit time
> support was added for 32-bit architectures (which may be a convenient
> minimum kernel for some new 32-bit architectures for that reason).
> Requiring a newer kernel like that is certainly fine if convenient for the
> port, but I think the choice of minimum kernel version, and the reasons
> for it, deserve mention at least in the commit message and the NEWS file
> entry.
OK, during the v1 review you mentioned:
You'll probably need a newer minimum kernel when requiring 64-bit time
support, until all the fallback for 64-bit time on 32-bit kernels without
the 64-bit-time syscalls is implemented.
I really just chose the version I was working on at the time. I just looked
back on it, this version 5.10 is good because. 1. it is a long term support
version. 2. in 5.8 I fixed a kernel bug which caused clone/fork to not work
with TLS.
I will upate the commit/news.
-Stafford
next prev parent reply other threads:[~2021-11-19 23:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 3:16 [PATCH v2 00/13] Glibc OpenRISC port Stafford Horne
2021-11-13 3:16 ` [PATCH v2 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-11-13 3:16 ` [PATCH v2 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-11-13 3:16 ` [PATCH v2 03/13] or1k: ABI Implementation Stafford Horne
2021-11-18 22:13 ` Joseph Myers
2021-11-19 11:45 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-11-13 3:16 ` [PATCH v2 05/13] or1k: Thread Local Storage support Stafford Horne
2021-11-18 22:22 ` Joseph Myers
2021-11-19 23:03 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-11-13 3:16 ` [PATCH v2 07/13] or1k: math soft float support Stafford Horne
2021-11-18 22:28 ` Joseph Myers
2021-11-19 23:07 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-11-18 22:29 ` Joseph Myers
2021-11-19 23:48 ` Stafford Horne
2021-11-19 12:27 ` Adhemerval Zanella
2021-11-19 23:46 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 09/13] or1k: Linux ABI Stafford Horne
2021-11-13 3:16 ` [PATCH v2 10/13] or1k: ABI lists Stafford Horne
2021-11-13 3:16 ` [PATCH v2 11/13] or1k: Build Infrastructure Stafford Horne
2021-11-18 22:34 ` Joseph Myers
2021-11-19 23:36 ` Stafford Horne [this message]
2021-11-13 3:16 ` [PATCH v2 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-11-13 3:16 ` [PATCH v2 13/13] Documentation for OpenRISC port Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZg1GDq00WB/PtnO@antec \
--to=shorne@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).