From: Stafford Horne <shorne@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v2 05/13] or1k: Thread Local Storage support
Date: Sat, 20 Nov 2021 08:03:38 +0900 [thread overview]
Message-ID: <YZgtSoIRAiH/Xjjt@antec> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111182219580.1393807@digraph.polyomino.org.uk>
On Thu, Nov 18, 2021 at 10:22:23PM +0000, Joseph Myers wrote:
> On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote:
>
> > diff --git a/sysdeps/or1k/dl-tls.h b/sysdeps/or1k/dl-tls.h
> > new file mode 100644
> > index 0000000000..f25645c715
> > --- /dev/null
> > +++ b/sysdeps/or1k/dl-tls.h
> > @@ -0,0 +1,26 @@
> > +/* Copyright (C) 2021 Free Software Foundation, Inc.
>
> Each file should have a one-line description on the line before the
> copyright notice.
OK, I went through the patch's and made sure I have this on all .c .h and .S
files.
> > diff --git a/sysdeps/or1k/libc-tls.c b/sysdeps/or1k/libc-tls.c
> > new file mode 100644
> > index 0000000000..43571944dd
> > --- /dev/null
> > +++ b/sysdeps/or1k/libc-tls.c
> > @@ -0,0 +1,32 @@
> > +/* Copyright (C) 2021 Free Software Foundation, Inc.
>
> Likewise.
>
> > diff --git a/sysdeps/or1k/stackinfo.h b/sysdeps/or1k/stackinfo.h
> > new file mode 100644
> > index 0000000000..14e767c5bf
> > --- /dev/null
> > +++ b/sysdeps/or1k/stackinfo.h
> > @@ -0,0 +1,33 @@
> > +/* Copyright (C) 2021 Free Software Foundation, Inc.
>
> Likewise.
>
> > +/* Default to an executable stack. PF_X can be overridden if PT_GNU_STACK is
> > + * present, but it is presumed absent. */
>
> We don't use '*' at the start of second and subsequent lines of comments.
OK, I went through the patch and tried to sort all of these occurances out.
Also there were a few where we didn't have two spaces after period ".". Also, a
few other similar issues.
> (It seems unfortunate for a new port to default to executable stacks, but
> it looks like this is indeed what the Linux kernel port to OpenRISC does,
> given the lack of an override of the default VM_DATA_DEFAULT_FLAGS and
> VM_STACK_DEFAULT_FLAGS.)
Yes.
Thanks for reviewing.
-Stafford
next prev parent reply other threads:[~2021-11-19 23:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 3:16 [PATCH v2 00/13] Glibc OpenRISC port Stafford Horne
2021-11-13 3:16 ` [PATCH v2 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-11-13 3:16 ` [PATCH v2 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-11-13 3:16 ` [PATCH v2 03/13] or1k: ABI Implementation Stafford Horne
2021-11-18 22:13 ` Joseph Myers
2021-11-19 11:45 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-11-13 3:16 ` [PATCH v2 05/13] or1k: Thread Local Storage support Stafford Horne
2021-11-18 22:22 ` Joseph Myers
2021-11-19 23:03 ` Stafford Horne [this message]
2021-11-13 3:16 ` [PATCH v2 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-11-13 3:16 ` [PATCH v2 07/13] or1k: math soft float support Stafford Horne
2021-11-18 22:28 ` Joseph Myers
2021-11-19 23:07 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-11-18 22:29 ` Joseph Myers
2021-11-19 23:48 ` Stafford Horne
2021-11-19 12:27 ` Adhemerval Zanella
2021-11-19 23:46 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 09/13] or1k: Linux ABI Stafford Horne
2021-11-13 3:16 ` [PATCH v2 10/13] or1k: ABI lists Stafford Horne
2021-11-13 3:16 ` [PATCH v2 11/13] or1k: Build Infrastructure Stafford Horne
2021-11-18 22:34 ` Joseph Myers
2021-11-19 23:36 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-11-13 3:16 ` [PATCH v2 13/13] Documentation for OpenRISC port Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZgtSoIRAiH/Xjjt@antec \
--to=shorne@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).