From: Joseph Myers <joseph@codesourcery.com>
To: Stafford Horne <shorne@gmail.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v2 07/13] or1k: math soft float support
Date: Thu, 18 Nov 2021 22:28:03 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2111182225310.1393807@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20211113031639.2402161-8-shorne@gmail.com>
On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote:
> diff --git a/sysdeps/or1k/bits/fenv.h b/sysdeps/or1k/bits/fenv.h
> new file mode 100644
> index 0000000000..49194ad851
> --- /dev/null
> +++ b/sysdeps/or1k/bits/fenv.h
> @@ -0,0 +1,68 @@
> +/* Copyright (C) 2021 Free Software Foundation, Inc.
Missing one-line description at start of file.
The constants you're defining here seem to be specific to hard float, but
they're defined unconditionally. Is this because you use the same ABI for
hard float and soft float (which is generally the case when such hard
float constants might be defined for soft float as well - a soft float
compilation could be using a hard float libc that supports those
constants)?
> +/* Define bits representing exceptions in the FPCSR status word. */
> +enum
> + {
> + FE_OVERFLOW =
> +#define FE_OVERFLOW 1 << 3
Macros need to be properly surrounded by parentheses so they always group
as a single operand in any expression.
> +#define FP_EX_OVERFLOW 1 << 3
> +#define FP_EX_UNDERFLOW 1 << 4
> +#define FP_EX_INEXACT 1 << 8
> +#define FP_EX_INVALID 1 << 9
> +#define FP_EX_DIVZERO 1 << 11
Likewise in sfp-machine.h.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-11-18 22:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 3:16 [PATCH v2 00/13] Glibc OpenRISC port Stafford Horne
2021-11-13 3:16 ` [PATCH v2 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-11-13 3:16 ` [PATCH v2 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-11-13 3:16 ` [PATCH v2 03/13] or1k: ABI Implementation Stafford Horne
2021-11-18 22:13 ` Joseph Myers
2021-11-19 11:45 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-11-13 3:16 ` [PATCH v2 05/13] or1k: Thread Local Storage support Stafford Horne
2021-11-18 22:22 ` Joseph Myers
2021-11-19 23:03 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-11-13 3:16 ` [PATCH v2 07/13] or1k: math soft float support Stafford Horne
2021-11-18 22:28 ` Joseph Myers [this message]
2021-11-19 23:07 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-11-18 22:29 ` Joseph Myers
2021-11-19 23:48 ` Stafford Horne
2021-11-19 12:27 ` Adhemerval Zanella
2021-11-19 23:46 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 09/13] or1k: Linux ABI Stafford Horne
2021-11-13 3:16 ` [PATCH v2 10/13] or1k: ABI lists Stafford Horne
2021-11-13 3:16 ` [PATCH v2 11/13] or1k: Build Infrastructure Stafford Horne
2021-11-18 22:34 ` Joseph Myers
2021-11-19 23:36 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-11-13 3:16 ` [PATCH v2 13/13] Documentation for OpenRISC port Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2111182225310.1393807@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).