From: Stafford Horne <shorne@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>,
Openrisc <openrisc@lists.librecores.org>
Subject: Re: [PATCH v2 07/13] or1k: math soft float support
Date: Sat, 20 Nov 2021 08:07:28 +0900 [thread overview]
Message-ID: <YZguMGX4mbvqTK9R@antec> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111182225310.1393807@digraph.polyomino.org.uk>
On Thu, Nov 18, 2021 at 10:28:03PM +0000, Joseph Myers wrote:
> On Sat, 13 Nov 2021, Stafford Horne via Libc-alpha wrote:
>
> > diff --git a/sysdeps/or1k/bits/fenv.h b/sysdeps/or1k/bits/fenv.h
> > new file mode 100644
> > index 0000000000..49194ad851
> > --- /dev/null
> > +++ b/sysdeps/or1k/bits/fenv.h
> > @@ -0,0 +1,68 @@
> > +/* Copyright (C) 2021 Free Software Foundation, Inc.
>
> Missing one-line description at start of file.
OK Added for v3.
> The constants you're defining here seem to be specific to hard float, but
> they're defined unconditionally. Is this because you use the same ABI for
> hard float and soft float (which is generally the case when such hard
> float constants might be defined for soft float as well - a soft float
> compilation could be using a hard float libc that supports those
> constants)?
Yes, it's the same ABI. I have patches for hard float but am not submitting
until the Linux side is sorted out as mentioned in the comment. It seems
delcairing these conditionally was normal, hence I didn't mention anything about
it.
I didn't think as far as allowing for shared libc usage between soft/float
float, but I think that would work.
> > +/* Define bits representing exceptions in the FPCSR status word. */
> > +enum
> > + {
> > + FE_OVERFLOW =
> > +#define FE_OVERFLOW 1 << 3
>
> Macros need to be properly surrounded by parentheses so they always group
> as a single operand in any expression.
>
> > +#define FP_EX_OVERFLOW 1 << 3
> > +#define FP_EX_UNDERFLOW 1 << 4
> > +#define FP_EX_INEXACT 1 << 8
> > +#define FP_EX_INVALID 1 << 9
> > +#define FP_EX_DIVZERO 1 << 11
>
> Likewise in sfp-machine.h.
OK, I have cleaned those up.
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2021-11-19 23:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 3:16 [PATCH v2 00/13] Glibc OpenRISC port Stafford Horne
2021-11-13 3:16 ` [PATCH v2 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-11-13 3:16 ` [PATCH v2 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-11-13 3:16 ` [PATCH v2 03/13] or1k: ABI Implementation Stafford Horne
2021-11-18 22:13 ` Joseph Myers
2021-11-19 11:45 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-11-13 3:16 ` [PATCH v2 05/13] or1k: Thread Local Storage support Stafford Horne
2021-11-18 22:22 ` Joseph Myers
2021-11-19 23:03 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-11-13 3:16 ` [PATCH v2 07/13] or1k: math soft float support Stafford Horne
2021-11-18 22:28 ` Joseph Myers
2021-11-19 23:07 ` Stafford Horne [this message]
2021-11-13 3:16 ` [PATCH v2 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-11-18 22:29 ` Joseph Myers
2021-11-19 23:48 ` Stafford Horne
2021-11-19 12:27 ` Adhemerval Zanella
2021-11-19 23:46 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 09/13] or1k: Linux ABI Stafford Horne
2021-11-13 3:16 ` [PATCH v2 10/13] or1k: ABI lists Stafford Horne
2021-11-13 3:16 ` [PATCH v2 11/13] or1k: Build Infrastructure Stafford Horne
2021-11-18 22:34 ` Joseph Myers
2021-11-19 23:36 ` Stafford Horne
2021-11-13 3:16 ` [PATCH v2 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-11-13 3:16 ` [PATCH v2 13/13] Documentation for OpenRISC port Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZguMGX4mbvqTK9R@antec \
--to=shorne@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).