Re: [PATCH v8] Locales: Cyrillic -> ASCII transliteration table [BZ #2872]

[Rafal Luzynski <digitalfreak@lingonborough.com>]

Hi Egor,

I have applied your patch locally and I am going to start reviewing it.
I can tell you already that it applies correctly but git reports these
warnings:

    Applying: v8 Locales: Cyrillic -> ASCII transliteration table [BZ #2872]
    .git/rebase-apply/patch:1520: trailing whitespace.
    % i.e. [U0401-U04F9, U2019] but only the letters covered by ISO 9.1995 
    .git/rebase-apply/patch:1521: trailing whitespace.
    % It implements the GOST_7.79 System A (Latin Script) as a first 
    .git/rebase-apply/patch:1523: trailing whitespace.
    % https://en.wikipedia.org/wiki/ISO_9 for reference. 
    .git/rebase-apply/patch:1524: trailing whitespace.
    % The System B is extended from GOST_7.79-Russian using open sources 
    .git/rebase-apply/patch:1535: trailing whitespace.
    % Generated from UnicodeData.txt with a spreadsheet referenced 
    warning: 5 lines add whitespace errors.

Also the commit message is missing from your patch because probably it is
missing from your local repository.  Please re-add it and please remember
that it must contain a summary like this:

	[BZ #2872]
	* localedata/locales/translit_cyrillic: Add ISO 9.1995, GOST 7.79
	System A transliteration System B transcription table from Cyrillic
	to Latin/ASCII.
	* localedata/locales/aa_DJ: Add 'include "translit_cyrillic";""' to
	LC_CTYPE translit section.
	* localedata/locales/af_ZA: Likewise.

Hm... as I look at this now I think it should rather be:

	[BZ #2872]
	* localedata/locales/translit_cyrillic: New file.
	* localedata/locales/aa_DJ (LC_CTYPE): Add
	“'include "translit_cyrillic";""”
	* localedata/locales/af_ZA (LC_CTYPE): Likewise.

... and so on.  Optionally you can use:

	* localedata/locales/translit_cyrillic: New file.  Supports
	ISO 9.1995, GOST 7.79 System A transliteration System B
	transcription table from Cyrillic to Latin/ASCII.

I will appreciate more hints about how to write the ChangeLog entry
correctly
from more experienced maintainers.

2.11.2018 01:00 Egor Kobylkin <egor@kobylkin.com> wrote:
> [...]
> * The 'include "translit_cyrillic";""' now immediately follows last
> 'include "translit_XXX";""' string (was inserted just before
> translit_end previously.)

I confirm that this is the only relevant difference between v6 and v8.

> * Only the locales already having 'include .*translit.*;""' are patched
> (see the list for manual exclusions below, full list of included locales
> at the end of the email in the commit section.)

Has this list changed, that is, has any locale been added or removed?

> * Excluded az_AZ completely to avoid circular reference from tr_TR via
> “copy "tr_TR"”.

True, this is another difference and I hope this is correct (I have not
yet tested).

> Changelog v6:
> * Locales removed from the patch: C and sd_PK.
> * Added locales: az_AZ and ky_KG.

Correct.

> * Consistently transliterate single uppercase Cyrillic letters
>   to sequences of all uppercase Latin letters in all languages (whenever
>   a Cyrillic letter is transliterated to more than one Latin letter),
>   for example "Ї" is now transliterated as "YI" rather than "Yi".

I think you have not yet explained whether this is required by any existing
standard (please provide links) or whether this is your genuine idea to
distinguish between the cases like "Ш" transliterated to "Sh" and "Сх"
also transliterated to "Sh".

Again, I have not yet started reviewing and testing, this is just a feedback
after applying the patch locally.

Regards,

Rafal