* [PATCH] hppa: add missing prlimit64 symbol @ 2012-04-12 23:00 Mike Frysinger 2012-04-12 23:07 ` Roland McGrath 2012-04-13 2:02 ` Carlos O'Donell 0 siblings, 2 replies; 15+ messages in thread From: Mike Frysinger @ 2012-04-12 23:00 UTC (permalink / raw) To: libc-ports All other arches have this in their syscall list. Looks like hppa is missing it though and breaks one or two apps that try to call it. URL: https://bugs.gentoo.org/411745 Signed-off-by: Mike Frysinger <vapier@gentoo.org> 2012-04-12 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/hppa/syscalls.list: Add prlimit64. --- sysdeps/unix/sysv/linux/hppa/syscalls.list | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sysdeps/unix/sysv/linux/hppa/syscalls.list b/sysdeps/unix/sysv/linux/hppa/syscalls.list index 0f7537c..1b6b311 100644 --- a/sysdeps/unix/sysv/linux/hppa/syscalls.list +++ b/sysdeps/unix/sysv/linux/hppa/syscalls.list @@ -35,3 +35,4 @@ socketpair - socketpair i:iiif __socketpair socketpair setrlimit - setrlimit i:ip __setrlimit setrlimit getrlimit - getrlimit i:ip __getrlimit getrlimit +prlimit64 EXTRA prlimit64 i:iipp prlimit64 -- 1.7.8.5 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-12 23:00 [PATCH] hppa: add missing prlimit64 symbol Mike Frysinger @ 2012-04-12 23:07 ` Roland McGrath 2012-04-12 23:26 ` Mike Frysinger 2012-04-13 2:00 ` Carlos O'Donell 2012-04-13 2:02 ` Carlos O'Donell 1 sibling, 2 replies; 15+ messages in thread From: Roland McGrath @ 2012-04-12 23:07 UTC (permalink / raw) To: Mike Frysinger; +Cc: libc-ports > All other arches have this in their syscall list. Looks like hppa > is missing it though and breaks one or two apps that try to call it. If it's really "all", then why isn't it in linux/syscalls.list instead? Thanks, Roland ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-12 23:07 ` Roland McGrath @ 2012-04-12 23:26 ` Mike Frysinger 2012-04-13 3:59 ` Roland McGrath 2012-04-13 2:00 ` Carlos O'Donell 1 sibling, 1 reply; 15+ messages in thread From: Mike Frysinger @ 2012-04-12 23:26 UTC (permalink / raw) To: Roland McGrath; +Cc: libc-ports [-- Attachment #1: Type: Text/Plain, Size: 1783 bytes --] On Thursday 12 April 2012 19:07:24 Roland McGrath wrote: > > All other arches have this in their syscall list. Looks like hppa > > is missing it though and breaks one or two apps that try to call it. > > If it's really "all", then why isn't it in linux/syscalls.list instead? i'm not familiar with how stacking works and the syscalls.list, but the 64bit arches need to do something different from the 32bit arches. on 64bit, prlimit64 is just an alias to prlimit. for 32bit arches, they need to declare the list themselves. sysdeps/unix/sysv/linux/wordsize-64/syscalls.list lists it unconditionally (for the alias), and from there, it seems that all the 32bit arches add it to their arch-specific list. sysdeps/unix/sysv/linux/sh/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 sysdeps/unix/sysv/linux/i386/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 ports/sysdeps/unix/sysv/linux/arm/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 ports/sysdeps/unix/sysv/linux/mips/mips32/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 ports/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 ports/sysdeps/unix/sysv/linux/m68k/syscalls.list:prlimit64 EXTRA prlimit64 i:iipp prlimit64 hppa is the only one here i can see missing. and probably the new "generic/wordsize-32/" ... -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-12 23:26 ` Mike Frysinger @ 2012-04-13 3:59 ` Roland McGrath 2012-08-11 19:27 ` Mike Frysinger 0 siblings, 1 reply; 15+ messages in thread From: Roland McGrath @ 2012-04-13 3:59 UTC (permalink / raw) To: Mike Frysinger; +Cc: libc-ports > sysdeps/unix/sysv/linux/wordsize-64/syscalls.list lists it unconditionally > (for the alias), and from there, it seems that all the 32bit arches add it to > their arch-specific list. That should mean that adding it to sysdeps/unix/sysv/linux/syscalls.list should do the right thing for hppa, and that removing it from other machine-specific syscalls.list files will then have no effect on the status quo. Can you try that and verify? Thanks, Roland ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-13 3:59 ` Roland McGrath @ 2012-08-11 19:27 ` Mike Frysinger 2012-08-12 12:59 ` Joseph S. Myers 2012-08-12 15:00 ` Mike Frysinger 0 siblings, 2 replies; 15+ messages in thread From: Mike Frysinger @ 2012-08-11 19:27 UTC (permalink / raw) To: Roland McGrath; +Cc: libc-ports [-- Attachment #1: Type: Text/Plain, Size: 1616 bytes --] On Thursday 12 April 2012 23:58:54 Roland McGrath wrote: > > sysdeps/unix/sysv/linux/wordsize-64/syscalls.list lists it > > unconditionally (for the alias), and from there, it seems that all the > > 32bit arches add it to their arch-specific list. > > That should mean that adding it to sysdeps/unix/sysv/linux/syscalls.list > should do the right thing for hppa, and that removing it from other > machine-specific syscalls.list files will then have no effect on the status > quo. Can you try that and verify? ok, i confused myself. wordsize-64/syscalls.list has the line: prlimit EXTRA prlimit64 i:iipp prlimit prlimit64 while the 32bit arches have: prlimit64 EXTRA prlimit64 i:iipp prlimit64 and additionally, we have: sysdeps/unix/sysv/linux/prlimit.c so if we try to build a 64bit system with both these syscalls.list entries, we hit a build error: /usr/local/src/gnu/glibc/build/x86_64/libc_pic.a(prlimit64.os): In function `prlimit64': /usr/local/src/gnu/glibc/misc/../sysdeps/unix/syscall-template.S:81: multiple definition of `__GI_prlimit64' /usr/local/src/gnu/glibc/build/x86_64/libc_pic.a(prlimit.os):/usr/local/src/gnu/glibc/misc/../sysdeps/unix/syscall- template.S:81: first defined here which makes sense as normally we don't generate a prlimit64 file at all, just a prlimit wrapper with a prlimit64 alias in it. so the next thing i tried was creating sysdeps/unix/sysv/linux/wordsize-32/syscalls.list and adding the new prlimit alias there. but a simple i686 build doesn't pick up the new location of the prlimit64 symbol. -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-11 19:27 ` Mike Frysinger @ 2012-08-12 12:59 ` Joseph S. Myers 2012-08-12 13:15 ` Carlos O'Donell 2012-08-12 14:48 ` Mike Frysinger 2012-08-12 15:00 ` Mike Frysinger 1 sibling, 2 replies; 15+ messages in thread From: Joseph S. Myers @ 2012-08-12 12:59 UTC (permalink / raw) To: Mike Frysinger; +Cc: Roland McGrath, libc-ports On Sat, 11 Aug 2012, Mike Frysinger wrote: > while the 32bit arches have: > prlimit64 EXTRA prlimit64 i:iipp prlimit64 > so the next thing i tried was creating > sysdeps/unix/sysv/linux/wordsize-32/syscalls.list and adding the new prlimit > alias there. but a simple i686 build doesn't pick up the new location of the > prlimit64 symbol. Well, it wouldn't be an *alias*; it would be the prlimit64 entry above. But, if the point is to fix things for hppa then you need to arrange for hppa to get a GLIBC_2.17 version for prlimit64, not the default GLIBC_2.13 since in fact the function was missing in 2.13 for hppa - as noted in point (v) for hppa in my list at <http://sourceware.org/ml/libc-ports/2012-06/msg00048.html>. (The lack of ABI baselines - which of course ought to be checked against binaries of old releases when set up - is point (g) on that list, and (x) is another point involving checks against old binaries.) (Adding the entry, but with @@GLIBC_2.17 like the SH fanotify_mark, to the hppa syscalls.list along with an appropriate Versions entry, is certainly the safer approach than doing something with the potential to affect other architectures, even though it may also be good to work out how to clean these things up. Note hppa also needs fanotify_mark at a new version, and note that cleanups here only help existing architectures; there are no issues for new architectures using linux-generic because linux-generic already has the right entries in syscalls.list.) -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-12 12:59 ` Joseph S. Myers @ 2012-08-12 13:15 ` Carlos O'Donell 2012-08-12 16:03 ` Joseph S. Myers 2012-08-12 14:48 ` Mike Frysinger 1 sibling, 1 reply; 15+ messages in thread From: Carlos O'Donell @ 2012-08-12 13:15 UTC (permalink / raw) To: Joseph S. Myers; +Cc: Mike Frysinger, Roland McGrath, libc-ports On Sun, Aug 12, 2012 at 8:59 AM, Joseph S. Myers <joseph@codesourcery.com> wrote: > On Sat, 11 Aug 2012, Mike Frysinger wrote: > >> while the 32bit arches have: >> prlimit64 EXTRA prlimit64 i:iipp prlimit64 > >> so the next thing i tried was creating >> sysdeps/unix/sysv/linux/wordsize-32/syscalls.list and adding the new prlimit >> alias there. but a simple i686 build doesn't pick up the new location of the >> prlimit64 symbol. > > Well, it wouldn't be an *alias*; it would be the prlimit64 entry above. > But, if the point is to fix things for hppa then you need to arrange for > hppa to get a GLIBC_2.17 version for prlimit64, not the default GLIBC_2.13 > since in fact the function was missing in 2.13 for hppa - as noted in > point (v) for hppa in my list at > <http://sourceware.org/ml/libc-ports/2012-06/msg00048.html>. (The lack of > ABI baselines - which of course ought to be checked against binaries of > old releases when set up - is point (g) on that list, and (x) is another > point involving checks against old binaries.) > > (Adding the entry, but with @@GLIBC_2.17 like the SH fanotify_mark, to the > hppa syscalls.list along with an appropriate Versions entry, is certainly > the safer approach than doing something with the potential to affect other > architectures, even though it may also be good to work out how to clean > these things up. Note hppa also needs fanotify_mark at a new version, and > note that cleanups here only help existing architectures; there are no > issues for new architectures using linux-generic because linux-generic > already has the right entries in syscalls.list.) I've been spending the weekend bringing up new hardware for my hppa testing, so hopefully I can get back to tackling the maintenance backlog (along with any 2.15 and 2.16 backport requests). Cheers, Carlos. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-12 13:15 ` Carlos O'Donell @ 2012-08-12 16:03 ` Joseph S. Myers 0 siblings, 0 replies; 15+ messages in thread From: Joseph S. Myers @ 2012-08-12 16:03 UTC (permalink / raw) To: Carlos O'Donell; +Cc: Mike Frysinger, Roland McGrath, libc-ports On Sun, 12 Aug 2012, Carlos O'Donell wrote: > I've been spending the weekend bringing up new hardware for my hppa > testing, so hopefully I can get back to tackling the maintenance > backlog (along with any 2.15 and 2.16 backport requests). A large proportion of the issues I listed, and of the subsequent global changes needing hppa versions, and quite possibly of the open hppa ports issues in Bugzilla, could be done purely as mechanical changes without hardware testing, to reduce the size of the backlog. It's finding and fixing the issues missing from my list that will need proper testing. (For reference, my notes of ports changes (for more than just hppa - there are alpha and ia64 issues here too) that would be appropriate given post-2.16 libc changes but haven't yet been done: [2012-08-07] hppa cleanup __ASSUME_LWS_CAS [2012-08-02] am33, ia64 ASM_TYPE_DIRECTIVE [2012-07-17] alpha, hppa, ia64 TLS configure checks remove [2012-07-17] hppa, am33 (and SH) c++-types data [2012-07-10] am33 ASM_GLOBAL_DIRECTIVE ) -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-12 12:59 ` Joseph S. Myers 2012-08-12 13:15 ` Carlos O'Donell @ 2012-08-12 14:48 ` Mike Frysinger 2012-08-12 14:51 ` Carlos O'Donell 2012-08-12 15:58 ` Joseph S. Myers 1 sibling, 2 replies; 15+ messages in thread From: Mike Frysinger @ 2012-08-12 14:48 UTC (permalink / raw) To: Joseph S. Myers; +Cc: Roland McGrath, libc-ports [-- Attachment #1: Type: Text/Plain, Size: 924 bytes --] On Sunday 12 August 2012 08:59:20 Joseph S. Myers wrote: > (Adding the entry, but with @@GLIBC_2.17 like the SH fanotify_mark, to the > hppa syscalls.list along with an appropriate Versions entry, is certainly > the safer approach than doing something with the potential to affect other > architectures, even though it may also be good to work out how to clean > these things up. Note hppa also needs fanotify_mark at a new version, and > note that cleanups here only help existing architectures; i originally posted just an entry updating hppa but was encouraged at looking at cleaning up everyone > there are no > issues for new architectures using linux-generic because linux-generic > already has the right entries in syscalls.list.) if all new arches are expected to start with linux-generic as its base, then i can see leaning towards just adding the entry to hppa and being done with it -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-12 14:48 ` Mike Frysinger @ 2012-08-12 14:51 ` Carlos O'Donell 2012-08-12 15:58 ` Joseph S. Myers 1 sibling, 0 replies; 15+ messages in thread From: Carlos O'Donell @ 2012-08-12 14:51 UTC (permalink / raw) To: Mike Frysinger; +Cc: Joseph S. Myers, Roland McGrath, libc-ports On Sun, Aug 12, 2012 at 10:48 AM, Mike Frysinger <vapier@gentoo.org> wrote: > On Sunday 12 August 2012 08:59:20 Joseph S. Myers wrote: >> (Adding the entry, but with @@GLIBC_2.17 like the SH fanotify_mark, to the >> hppa syscalls.list along with an appropriate Versions entry, is certainly >> the safer approach than doing something with the potential to affect other >> architectures, even though it may also be good to work out how to clean >> these things up. Note hppa also needs fanotify_mark at a new version, and >> note that cleanups here only help existing architectures; > > i originally posted just an entry updating hppa but was encouraged at looking > at cleaning up everyone > >> there are no >> issues for new architectures using linux-generic because linux-generic >> already has the right entries in syscalls.list.) > > if all new arches are expected to start with linux-generic as its base, then i > can see leaning towards just adding the entry to hppa and being done with it Agreed. That's a practical and immediate fix. Cheers, Carlos. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-12 14:48 ` Mike Frysinger 2012-08-12 14:51 ` Carlos O'Donell @ 2012-08-12 15:58 ` Joseph S. Myers 1 sibling, 0 replies; 15+ messages in thread From: Joseph S. Myers @ 2012-08-12 15:58 UTC (permalink / raw) To: Mike Frysinger; +Cc: Roland McGrath, libc-ports On Sun, 12 Aug 2012, Mike Frysinger wrote: > if all new arches are expected to start with linux-generic as its base, then i > can see leaning towards just adding the entry to hppa and being done with it That's a kernel expectation rather than a glibc one - but while new glibc ports for old kernel ports are certainly possible, new glibc ports are more likely for new kernel ports, and new kernel ports are expected to use the generic ABI. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-08-11 19:27 ` Mike Frysinger 2012-08-12 12:59 ` Joseph S. Myers @ 2012-08-12 15:00 ` Mike Frysinger 1 sibling, 0 replies; 15+ messages in thread From: Mike Frysinger @ 2012-08-12 15:00 UTC (permalink / raw) To: libc-ports [-- Attachment #1: Type: Text/Plain, Size: 8380 bytes --] for posterity, here's what i attempted -mike From 9532af952bae3ddd59526ec8e99a7c7f708c8b6a Mon Sep 17 00:00:00 2001 From: Mike Frysinger <vapier@gentoo.org> Date: Sat, 11 Aug 2012 14:24:54 -0400 Subject: [PATCH] Linux prlimit64: move 32bit version to common location Most 32bit targets declare the prlimit64 wrapper in the arch-specific syscalls.list file. The few that don't are broken (like hppa), but rather than copy & paste that line into the missing arches, move it to the central Linux location. For 64bit targets, there is a line in the wordsize-64 directory that overrides this. Signed-off-by: Mike Frysinger <vapier@gentoo.org> ./ChangeLog 2012-08-11 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/syscalls.list: Add prlimit64. * sysdeps/unix/sysv/linux/i386/syscalls.list: Delete prlimit64. * sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list: Likewise. * sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list: Likewise. * sysdeps/unix/sysv/linux/sh/syscalls.list: Likewise. * sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list: Likewise. ./ports/ChangeLog.arm 2012-08-11 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/arm/syscalls.list: Delete prlimit64. ./ports/ChangeLog.linux-generic 2012-08-11 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/generic/wordsize-32/syscalls.list: Delete prlimit64. ./ports/ChangeLog.m68k 2012-08-11 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/m68k/syscalls.list: Delete prlimit64. ./ports/ChangeLog.mips 2012-08-11 Mike Frysinger <vapier@gentoo.org> * sysdeps/unix/sysv/linux/mips/mips32/syscalls.list: Delete prlimit64. * sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list: Delete prlimit64. --- ports/sysdeps/unix/sysv/linux/arm/syscalls.list | 2 -- .../sysv/linux/generic/wordsize-32/syscalls.list | 1 - ports/sysdeps/unix/sysv/linux/m68k/syscalls.list | 1 - .../unix/sysv/linux/mips/mips32/syscalls.list | 2 -- .../unix/sysv/linux/mips/mips64/n32/syscalls.list | 2 -- sysdeps/unix/sysv/linux/i386/syscalls.list | 2 -- .../sysv/linux/powerpc/powerpc32/syscalls.list | 1 - sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list | 1 - sysdeps/unix/sysv/linux/sh/syscalls.list | 2 -- .../unix/sysv/linux/sparc/sparc32/syscalls.list | 1 - sysdeps/unix/sysv/linux/syscalls.list | 1 + 11 files changed, 1 insertion(+), 15 deletions(-) diff --git a/ports/sysdeps/unix/sysv/linux/arm/syscalls.list b/ports/sysdeps/unix/sysv/linux/arm/syscalls.list index ba8cdd7..40ddc95 100644 --- a/ports/sysdeps/unix/sysv/linux/arm/syscalls.list +++ b/ports/sysdeps/unix/sysv/linux/arm/syscalls.list @@ -2,8 +2,6 @@ chown - chown32 i:sii __chown chown -prlimit64 EXTRA prlimit64 i:iipp prlimit64 - fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark # Semaphore and shm system calls. msgctl, shmctl, and semctl have C diff --git a/ports/sysdeps/unix/sysv/linux/generic/wordsize-32/syscalls.list b/ports/sysdeps/unix/sysv/linux/generic/wordsize-32/syscalls.list index 58b4057..fd555a2 100644 --- a/ports/sysdeps/unix/sysv/linux/generic/wordsize-32/syscalls.list +++ b/ports/sysdeps/unix/sysv/linux/generic/wordsize-32/syscalls.list @@ -3,5 +3,4 @@ # rlimit APIs getrlimit - getrlimit i:ip __getrlimit getrlimit setrlimit - setrlimit i:ip __setrlimit setrlimit -prlimit64 EXTRA prlimit64 i:iipp prlimit64 fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/ports/sysdeps/unix/sysv/linux/m68k/syscalls.list b/ports/sysdeps/unix/sysv/linux/m68k/syscalls.list index 1e27d8d..b324fd1 100644 --- a/ports/sysdeps/unix/sysv/linux/m68k/syscalls.list +++ b/ports/sysdeps/unix/sysv/linux/m68k/syscalls.list @@ -3,5 +3,4 @@ chown - chown32 i:sii __chown chown cacheflush EXTRA cacheflush i:iiii __cacheflush cacheflush -prlimit64 EXTRA prlimit64 i:iipp prlimit64 fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/ports/sysdeps/unix/sysv/linux/mips/mips32/syscalls.list b/ports/sysdeps/unix/sysv/linux/mips/mips32/syscalls.list index f357b5c..5cafa95 100644 --- a/ports/sysdeps/unix/sysv/linux/mips/mips32/syscalls.list +++ b/ports/sysdeps/unix/sysv/linux/mips/mips32/syscalls.list @@ -1,5 +1,3 @@ # File name Caller Syscall name # args Strong name Weak names -prlimit64 EXTRA prlimit64 i:iipp prlimit64 - fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/ports/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list b/ports/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list index 7ad5523..dd5ea93 100644 --- a/ports/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list +++ b/ports/sysdeps/unix/sysv/linux/mips/mips64/n32/syscalls.list @@ -3,6 +3,4 @@ readahead - readahead i:iii __readahead readahead sync_file_range - sync_file_range Ci:iiii sync_file_range -prlimit64 EXTRA prlimit64 i:iipp prlimit64 - fanotify_mark EXTRA fanotify_mark i:iiiis fanotify_mark diff --git a/sysdeps/unix/sysv/linux/i386/syscalls.list b/sysdeps/unix/sysv/linux/i386/syscalls.list index 149d432..da587b2 100644 --- a/sysdeps/unix/sysv/linux/i386/syscalls.list +++ b/sysdeps/unix/sysv/linux/i386/syscalls.list @@ -7,6 +7,4 @@ oldgetrlimit EXTRA getrlimit i:ip __old_getrlimit getrlimit@GLIBC_2.0 oldsetrlimit EXTRA setrlimit i:ip __old_setrlimit setrlimit@GLIBC_2.0 waitpid - waitpid Ci:ipi __waitpid waitpid __libc_waitpid -prlimit64 EXTRA prlimit64 i:iipp prlimit64 - fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list b/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list index aaa3557..420bfad 100644 --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list @@ -7,5 +7,4 @@ oldsetrlimit EXTRA setrlimit i:ip __old_setrlimit setrlimit@GLIBC_2.0 # Due to 64bit alignment there is a dummy second parameter readahead - readahead i:iiiii __readahead readahead -prlimit64 EXTRA prlimit64 i:iipp prlimit64 fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list b/sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list index e946d33..061dc55 100644 --- a/sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list +++ b/sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list @@ -4,5 +4,4 @@ oldgetrlimit EXTRA getrlimit i:ip __old_getrlimit getrlimit@GLIBC_2.0 oldsetrlimit EXTRA setrlimit i:ip __old_setrlimit setrlimit@GLIBC_2.0 vfork - vfork 0 __vfork vfork -prlimit64 EXTRA prlimit64 i:iipp prlimit64 fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/sysdeps/unix/sysv/linux/sh/syscalls.list b/sysdeps/unix/sysv/linux/sh/syscalls.list index faffe37..62a4002 100644 --- a/sysdeps/unix/sysv/linux/sh/syscalls.list +++ b/sysdeps/unix/sysv/linux/sh/syscalls.list @@ -2,6 +2,4 @@ waitpid - waitpid Ci:ipi __waitpid waitpid __libc_waitpid -prlimit64 EXTRA prlimit64 i:iipp prlimit64 - fanotify_mark EXTRA fanotify_mark i:iiiiis __fanotify_mark fanotify_mark@@GLIBC_2.16 diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list b/sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list index 3d70185..b6d0aed 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/syscalls.list @@ -5,5 +5,4 @@ getrlimit - getrlimit 2 __getrlimit getrlimit getresuid - getresuid32 3 getresuid getresgid - getresgid32 3 getresgid -prlimit64 EXTRA prlimit64 i:iipp prlimit64 fanotify_mark EXTRA fanotify_mark i:iiiiis fanotify_mark diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list index 6343272..a7da7c5 100644 --- a/sysdeps/unix/sysv/linux/syscalls.list +++ b/sysdeps/unix/sysv/linux/syscalls.list @@ -54,6 +54,7 @@ pipe2 - pipe2 i:fi __pipe2 pipe2 pivot_root EXTRA pivot_root i:ss pivot_root poll - poll Ci:pii __libc_poll __poll poll prctl EXTRA prctl i:iiiii __prctl prctl +prlimit64 EXTRA prlimit64 i:iipp prlimit64 putpmsg - putpmsg i:ippii putpmsg query_module EXTRA query_module i:sipip query_module quotactl EXTRA quotactl i:isip quotactl -- 1.7.9.7 [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-12 23:07 ` Roland McGrath 2012-04-12 23:26 ` Mike Frysinger @ 2012-04-13 2:00 ` Carlos O'Donell 1 sibling, 0 replies; 15+ messages in thread From: Carlos O'Donell @ 2012-04-13 2:00 UTC (permalink / raw) To: Roland McGrath; +Cc: Mike Frysinger, libc-ports On Thu, Apr 12, 2012 at 7:07 PM, Roland McGrath <roland@hack.frob.com> wrote: >> All other arches have this in their syscall list. Looks like hppa >> is missing it though and breaks one or two apps that try to call it. > > If it's really "all", then why isn't it in linux/syscalls.list instead? That's exactly the question I asked myself when I handed a similar patch to one of our hppa developers last week :-) Cheers, Carlos. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-12 23:00 [PATCH] hppa: add missing prlimit64 symbol Mike Frysinger 2012-04-12 23:07 ` Roland McGrath @ 2012-04-13 2:02 ` Carlos O'Donell 2012-04-13 2:21 ` Mike Frysinger 1 sibling, 1 reply; 15+ messages in thread From: Carlos O'Donell @ 2012-04-13 2:02 UTC (permalink / raw) To: Mike Frysinger; +Cc: libc-ports On Thu, Apr 12, 2012 at 7:01 PM, Mike Frysinger <vapier@gentoo.org> wrote: > All other arches have this in their syscall list. Looks like hppa > is missing it though and breaks one or two apps that try to call it. > > URL: https://bugs.gentoo.org/411745 > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > > 2012-04-12 Mike Frysinger <vapier@gentoo.org> > > * sysdeps/unix/sysv/linux/hppa/syscalls.list: Add prlimit64. > --- > sysdeps/unix/sysv/linux/hppa/syscalls.list | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/hppa/syscalls.list b/sysdeps/unix/sysv/linux/hppa/syscalls.list > index 0f7537c..1b6b311 100644 > --- a/sysdeps/unix/sysv/linux/hppa/syscalls.list > +++ b/sysdeps/unix/sysv/linux/hppa/syscalls.list > @@ -35,3 +35,4 @@ socketpair - socketpair i:iiif __socketpair socketpair > > setrlimit - setrlimit i:ip __setrlimit setrlimit > getrlimit - getrlimit i:ip __getrlimit getrlimit > +prlimit64 EXTRA prlimit64 i:iipp prlimit64 > -- > 1.7.8.5 Sorry for making you do this work, I had this patch already done last week but I forgot to push it out. I'll checkin your version as soon as I get trunk building again with my crt* and elf changes. Cheers, Carlos. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hppa: add missing prlimit64 symbol 2012-04-13 2:02 ` Carlos O'Donell @ 2012-04-13 2:21 ` Mike Frysinger 0 siblings, 0 replies; 15+ messages in thread From: Mike Frysinger @ 2012-04-13 2:21 UTC (permalink / raw) To: Carlos O'Donell; +Cc: libc-ports [-- Attachment #1: Type: Text/Plain, Size: 393 bytes --] On Thursday 12 April 2012 22:02:15 Carlos O'Donell wrote: > Sorry for making you do this work, I had this patch already done last > week but I forgot to push it out. np. didn't take long to figure out + fix. > I'll checkin your version as soon as I get trunk building again with > my crt* and elf changes. this i did have to hack together and really had no idea if it was correct :) -mike [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2012-08-12 16:03 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-04-12 23:00 [PATCH] hppa: add missing prlimit64 symbol Mike Frysinger 2012-04-12 23:07 ` Roland McGrath 2012-04-12 23:26 ` Mike Frysinger 2012-04-13 3:59 ` Roland McGrath 2012-08-11 19:27 ` Mike Frysinger 2012-08-12 12:59 ` Joseph S. Myers 2012-08-12 13:15 ` Carlos O'Donell 2012-08-12 16:03 ` Joseph S. Myers 2012-08-12 14:48 ` Mike Frysinger 2012-08-12 14:51 ` Carlos O'Donell 2012-08-12 15:58 ` Joseph S. Myers 2012-08-12 15:00 ` Mike Frysinger 2012-04-13 2:00 ` Carlos O'Donell 2012-04-13 2:02 ` Carlos O'Donell 2012-04-13 2:21 ` Mike Frysinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).