* [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] [not found] ` <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com> @ 2019-01-01 0:00 ` Stefan Liebler 2019-01-01 0:00 ` Carlos O'Donell 0 siblings, 1 reply; 2+ messages in thread From: Stefan Liebler @ 2019-01-01 0:00 UTC (permalink / raw) To: GNU C Library, libc-stable Cc: Carlos O'Donell, Thomas Gleixner, Sebastian Sewior, Heiko Carstens, Torvald Riegel, Florian Weimer On 02/06/2019 04:59 PM, Carlos O'Donell wrote: > On 2/6/19 6:25 AM, Stefan Liebler wrote: >> Hi Carlos, >> I've updated the patch with three additional comments and I've mentioned the filed bug. >> Please review it once again before I commit it to master and cherry pick it to the release branches. > > Thank you! Reviewed. Committed to master (2.29.9000): "Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]" (https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708) and backported it to glibc 2.25 ... 2.29 release branches. Thanks. Stefan > >>> Yes, I did that backport to RHEL 7.6. These fixes are just "further" >>> fixes right? I'll work on getting this fixed in RHEL 7.7, and RHEL 8 >>> for all arches. >> Sounds great. >> That's the same fix for pthread_mutex_trylock as previously done for pthread_mutex_lock and pthread_mutex_timedlock. > > I've filed these: > https://bugzilla.redhat.com/show_bug.cgi?id=1672771 > https://bugzilla.redhat.com/show_bug.cgi?id=1672773 > > Feel free to comment or verify if they are going to be needed in RHEL7.7 > or RHEL8. I haven't done the analysis of the disassembly yet. If you > could have a look that would help. > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] 2019-01-01 0:00 ` [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] Stefan Liebler @ 2019-01-01 0:00 ` Carlos O'Donell 0 siblings, 0 replies; 2+ messages in thread From: Carlos O'Donell @ 2019-01-01 0:00 UTC (permalink / raw) To: Stefan Liebler, GNU C Library, libc-stable Cc: Thomas Gleixner, Sebastian Sewior, Heiko Carstens, Torvald Riegel, Florian Weimer On 2/7/19 10:05 AM, Stefan Liebler wrote: > On 02/06/2019 04:59 PM, Carlos O'Donell wrote: >> On 2/6/19 6:25 AM, Stefan Liebler wrote: >>> Hi Carlos, >>> I've updated the patch with three additional comments and I've mentioned the filed bug. >>> Please review it once again before I commit it to master and cherry pick it to the release branches. >> >> Thank you! Reviewed. > Committed to master (2.29.9000): > "Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]" > (https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708) > > and backported it to glibc 2.25 ... 2.29 release branches. Thank you! Now if only we could fix the final robust mutex design flaw[1] ;-) -- Cheers, Carlos. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=14485 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-07 20:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <fcc30533-41b1-a159-7019-290d2c489242@linux.ibm.com>
[not found] ` <60ff0bf2-38f9-92b4-7582-8b65c2acfa0e@redhat.com>
[not found] ` <c60e8de1-704a-9ff1-6ec9-474e47cc4686@linux.ibm.com>
[not found] ` <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com>
2019-01-01 0:00 ` [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180] Stefan Liebler
2019-01-01 0:00 ` Carlos O'Donell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).