* [Patch AArch64] Add missing .note.GNU-stack note
@ 2014-11-13 15:32 James Greenhalgh
2014-11-21 17:30 ` James Greenhalgh
0 siblings, 1 reply; 3+ messages in thread
From: James Greenhalgh @ 2014-11-13 15:32 UTC (permalink / raw)
To: libffi-discuss; +Cc: marcus.shawcroft, rth, green
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
Hi Anthony,
This trivial patch fixes:
https://github.com/atgreen/libffi/issues/141
By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
Could you please apply this to HEAD?
Thanks,
James
---
2014-11-13 James Greenhalgh <james.greenhalgh@arm.com>
* aarch64/sysv.S: Add .note.GNU-stack.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Patch-AArch64-Add-missing-.note.GNU-stack-note.patch --]
[-- Type: text/x-patch; name=0001-Patch-AArch64-Add-missing-.note.GNU-stack-note.patch, Size: 388 bytes --]
diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
index 1fb68f2..d5b1c2e 100644
--- a/src/aarch64/sysv.S
+++ b/src/aarch64/sysv.S
@@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
.size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
#endif
#endif /* FFI_GO_CLOSURES */
+
+#if defined __ELF__ && defined __linux__
+ .section .note.GNU-stack,"",%progbits
+#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch AArch64] Add missing .note.GNU-stack note
2014-11-13 15:32 [Patch AArch64] Add missing .note.GNU-stack note James Greenhalgh
@ 2014-11-21 17:30 ` James Greenhalgh
2014-12-05 17:33 ` James Greenhalgh
0 siblings, 1 reply; 3+ messages in thread
From: James Greenhalgh @ 2014-11-21 17:30 UTC (permalink / raw)
To: libffi-discuss; +Cc: Marcus Shawcroft, rth, green
*ping*
Thanks,
James
On Thu, Nov 13, 2014 at 03:32:02PM +0000, James Greenhalgh wrote:
>
> Hi Anthony,
>
> This trivial patch fixes:
> https://github.com/atgreen/libffi/issues/141
>
> By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
>
> Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
>
> Could you please apply this to HEAD?
>
> Thanks,
> James
>
> ---
>
> 2014-11-13 James Greenhalgh <james.greenhalgh@arm.com>
>
> * aarch64/sysv.S: Add .note.GNU-stack.
>
> diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
> index 1fb68f2..d5b1c2e 100644
> --- a/src/aarch64/sysv.S
> +++ b/src/aarch64/sysv.S
> @@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
> .size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
> #endif
> #endif /* FFI_GO_CLOSURES */
> +
> +#if defined __ELF__ && defined __linux__
> + .section .note.GNU-stack,"",%progbits
> +#endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch AArch64] Add missing .note.GNU-stack note
2014-11-21 17:30 ` James Greenhalgh
@ 2014-12-05 17:33 ` James Greenhalgh
0 siblings, 0 replies; 3+ messages in thread
From: James Greenhalgh @ 2014-12-05 17:33 UTC (permalink / raw)
To: libffi-discuss; +Cc: Marcus Shawcroft, rth, green
On Fri, Nov 21, 2014 at 05:30:36PM +0000, James Greenhalgh wrote:
> *ping*
*ping^2*
Cheers,
James
>
> Thanks,
> James
>
> On Thu, Nov 13, 2014 at 03:32:02PM +0000, James Greenhalgh wrote:
> >
> > Hi Anthony,
> >
> > This trivial patch fixes:
> > https://github.com/atgreen/libffi/issues/141
> >
> > By adding a .note.GNU-stack note to the bottom of src/aarch64/sysv.S.
> >
> > Tested native on aarch64-none-linux-gnu, with no issues in the testsuite.
> >
> > Could you please apply this to HEAD?
> >
> > Thanks,
> > James
> >
> > ---
> >
> > 2014-11-13 James Greenhalgh <james.greenhalgh@arm.com>
> >
> > * aarch64/sysv.S: Add .note.GNU-stack.
> >
>
> > diff --git a/src/aarch64/sysv.S b/src/aarch64/sysv.S
> > index 1fb68f2..d5b1c2e 100644
> > --- a/src/aarch64/sysv.S
> > +++ b/src/aarch64/sysv.S
> > @@ -396,3 +396,7 @@ CNAME(ffi_go_closure_SYSV):
> > .size CNAME(ffi_go_closure_SYSV), . - CNAME(ffi_go_closure_SYSV)
> > #endif
> > #endif /* FFI_GO_CLOSURES */
> > +
> > +#if defined __ELF__ && defined __linux__
> > + .section .note.GNU-stack,"",%progbits
> > +#endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-05 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-13 15:32 [Patch AArch64] Add missing .note.GNU-stack note James Greenhalgh
2014-11-21 17:30 ` James Greenhalgh
2014-12-05 17:33 ` James Greenhalgh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).