public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/format_text/format-text.c Date: Sat, 16 Aug 2008 09:46:00 -0000 [thread overview] Message-ID: <20080816094655.9912.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2008-08-16 09:46:55 Modified files: . : WHATS_NEW lib/format_text: format-text.c Log message: Fix allocation bug in text metadata format write error path. Function _text_pv_write doesn't use memory pool but static buffer, call dm_pool_free in error path in _raw_write_mda_header is wrong. Move pool free only to path where is the memory pool used. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.946&r2=1.947 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.93&r2=1.94 --- LVM2/WHATS_NEW 2008/08/13 12:44:23 1.946 +++ LVM2/WHATS_NEW 2008/08/16 09:46:55 1.947 @@ -1,5 +1,6 @@ Version 2.02.40 - ================================ + Fix allocation bug in text metadata format write error path. Fix vgcfgbackup to properly check filename if template is used. configure aborts if lcov or genhtml are missing with --enable-profiling vgremove tries to remove lv snapshot first. --- LVM2/lib/format_text/format-text.c 2008/07/31 13:07:01 1.93 +++ LVM2/lib/format_text/format-text.c 2008/08/16 09:46:55 1.94 @@ -346,10 +346,8 @@ MDA_HEADER_SIZE - sizeof(mdah->checksum_xl))); - if (!dev_write(dev, start_byte, MDA_HEADER_SIZE, mdah)) { - dm_pool_free(fmt->cmd->mem, mdah); + if (!dev_write(dev, start_byte, MDA_HEADER_SIZE, mdah)) return_0; - } return 1; } @@ -670,6 +668,7 @@ if (!_raw_write_mda_header(fid->fmt, mdac->area.dev, mdac->area.start, mdah)) { + dm_pool_free(fid->fmt->cmd->mem, mdah); log_error("Failed to write metadata area header"); goto out; } @@ -752,6 +751,7 @@ if (!_raw_write_mda_header(fid->fmt, mdac->area.dev, mdac->area.start, mdah)) { + dm_pool_free(fid->fmt->cmd->mem, mdah); log_error("Failed to write metadata area header"); goto out; }
next reply other threads:[~2008-08-16 9:46 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-08-16 9:46 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 11:09 zkabelac 2011-08-29 13:37 prajnoha 2011-02-03 1:41 zkabelac 2010-10-26 9:13 zkabelac 2010-09-30 14:12 prajnoha 2010-06-01 12:08 prajnoha 2009-07-30 21:15 snitzer 2009-07-30 18:40 snitzer 2009-07-30 17:42 snitzer 2009-07-30 17:19 snitzer 2009-07-30 17:18 snitzer 2009-03-23 21:13 taka 2009-03-03 16:35 mbroz 2008-10-17 0:55 agk 2008-09-30 20:37 agk 2008-07-31 10:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080816094655.9912.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).