public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/format_text/format-text.c Date: Thu, 30 Jul 2009 18:40:00 -0000 [thread overview] Message-ID: <20090730184023.7139.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2009-07-30 18:40:22 Modified files: . : WHATS_NEW lib/format_text: format-text.c Log message: Revert 'preserve_pe_start' related code in _text_pv_setup If pv_setup was given a non-zero pe_start it would short-circuit establishing a default pv->pe_align. pv->pe_align=0 would result in a divide by zero in _mda_setup(). 'vgconvert -M2 $vgname' hit this. .pv_write still properly preserves pe_start if it was supplied. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1216&r2=1.1217 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.111&r2=1.112 --- LVM2/WHATS_NEW 2009/07/30 17:45:28 1.1216 +++ LVM2/WHATS_NEW 2009/07/30 18:40:22 1.1217 @@ -1,7 +1,7 @@ Version 2.02.51 - ================================ Add --dataalignmentoffset to pvcreate to shift start of aligned data area. - Preserve pe_start in .pv_setup and .pv_write if pe_start was supplied. + Preserve pe_start in .pv_write if pe_start was supplied. Fix _mda_setup() to not check first mda's size before pe_align rounding. Formalize pe_start policy as split between .pv_setup and .pv_write. Document -I option of clvmd in the man page. --- LVM2/lib/format_text/format-text.c 2009/07/30 17:45:29 1.111 +++ LVM2/lib/format_text/format-text.c 2009/07/30 18:40:22 1.112 @@ -1735,10 +1735,8 @@ /* FIXME Default from config file? vgextend cmdline flag? */ pv->status |= ALLOCATABLE_PV; } else { - if (pe_start) { + if (pe_start) pv->pe_start = pe_start; - goto preserve_pe_start; - } if (!data_alignment) data_alignment = find_config_tree_int(pv->fmt->cmd, @@ -1760,7 +1758,6 @@ return 0; } - preserve_pe_start: if (extent_count) pe_end = pe_start + extent_count * extent_size - 1; if (!_mda_setup(fmt, pe_start, pe_end, pvmetadatacopies,
next reply other threads:[~2009-07-30 18:40 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-30 18:40 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 11:09 zkabelac 2011-08-29 13:37 prajnoha 2011-02-03 1:41 zkabelac 2010-10-26 9:13 zkabelac 2010-09-30 14:12 prajnoha 2010-06-01 12:08 prajnoha 2009-07-30 21:15 snitzer 2009-07-30 17:42 snitzer 2009-07-30 17:19 snitzer 2009-07-30 17:18 snitzer 2009-03-23 21:13 taka 2009-03-03 16:35 mbroz 2008-10-17 0:55 agk 2008-09-30 20:37 agk 2008-08-16 9:46 mbroz 2008-07-31 10:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090730184023.7139.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).