public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: snitzer@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW lib/format_text/format-text.c
Date: Thu, 30 Jul 2009 17:42:00 -0000 [thread overview]
Message-ID: <20090730174236.27606.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: snitzer@sourceware.org 2009-07-30 17:42:34
Modified files:
. : WHATS_NEW
lib/format_text: format-text.c
Log message:
Preserve pe_start in .pv_setup and .pv_write if pe_start was supplied.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1214&r2=1.1215
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.109&r2=1.110
--- LVM2/WHATS_NEW 2009/07/30 17:19:31 1.1214
+++ LVM2/WHATS_NEW 2009/07/30 17:42:33 1.1215
@@ -1,5 +1,6 @@
Version 2.02.51 -
================================
+ Preserve pe_start in .pv_setup and .pv_write if pe_start was supplied.
Fix _mda_setup() to not check first mda's size before pe_align rounding.
Formalize pe_start policy as split between .pv_setup and .pv_write.
Document -I option of clvmd in the man page.
--- LVM2/lib/format_text/format-text.c 2009/07/30 17:41:01 1.109
+++ LVM2/lib/format_text/format-text.c 2009/07/30 17:42:33 1.110
@@ -1368,12 +1368,17 @@
else
dm_list_init(&info->das);
+ if (pv->pe_start) {
+ log_very_verbose("%s: preserving pe_start=%lu",
+ pv_dev_name(pv), pv->pe_start);
+ goto preserve_pe_start;
+ }
+
/*
* If pe_start is still unset, set it to first aligned
* sector after any metadata areas that begin before pe_start.
*/
- if (!pv->pe_start)
- pv->pe_start = pv->pe_align;
+ pv->pe_start = pv->pe_align;
dm_list_iterate_items(mda, &info->mdas) {
mdac = (struct mda_context *) mda->metadata_locn;
if (pv->dev == mdac->area.dev &&
@@ -1389,6 +1394,8 @@
pv->pe_start += pv->pe_align - adjustment;
}
}
+
+ preserve_pe_start:
if (!add_da
(NULL, &info->das, pv->pe_start << SECTOR_SHIFT, UINT64_C(0)))
return_0;
@@ -1700,8 +1707,10 @@
/* FIXME Default from config file? vgextend cmdline flag? */
pv->status |= ALLOCATABLE_PV;
} else {
- if (pe_start)
+ if (pe_start) {
pv->pe_start = pe_start;
+ goto preserve_pe_start;
+ }
if (!data_alignment)
data_alignment = find_config_tree_int(pv->fmt->cmd,
@@ -1714,6 +1723,7 @@
"%lu sectors (requested %lu sectors)",
pv_dev_name(pv), pv->pe_align, data_alignment);
+ preserve_pe_start:
if (extent_count)
pe_end = pe_start + extent_count * extent_size - 1;
if (!_mda_setup(fmt, pe_start, pe_end, pvmetadatacopies,
next reply other threads:[~2009-07-30 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 17:42 snitzer [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 11:09 zkabelac
2011-08-29 13:37 prajnoha
2011-02-03 1:41 zkabelac
2010-10-26 9:13 zkabelac
2010-09-30 14:12 prajnoha
2010-06-01 12:08 prajnoha
2009-07-30 21:15 snitzer
2009-07-30 18:40 snitzer
2009-07-30 17:19 snitzer
2009-07-30 17:18 snitzer
2009-03-23 21:13 taka
2009-03-03 16:35 mbroz
2008-10-17 0:55 agk
2008-09-30 20:37 agk
2008-08-16 9:46 mbroz
2008-07-31 10:50 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090730174236.27606.qmail@sourceware.org \
--to=snitzer@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).