public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: snitzer@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/format_text/format-text.c Date: Thu, 30 Jul 2009 17:18:00 -0000 [thread overview] Message-ID: <20090730171809.18591.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: snitzer@sourceware.org 2009-07-30 17:18:08 Modified files: . : WHATS_NEW lib/format_text: format-text.c Log message: Formalize pe_start policy as split between .pv_setup and .pv_write. Document existing pe_start policy. Fix issue in _text_pv_setup() where existing pe_start case could have the pv->pe_start set to pv->pe_align even though pe_start shouldn't ever change. vgconvert and pvcreate have a facility to preserve the existing start of the on-disk data extents, known as pe_start. They indicate this by passing the existing value to the pvsetup function which must preserve it. This patch avoids one particular case where the value could get changed incorrectly now that the alignment settings are configurable. Signed-off-by: Mike Snitzer <snitzer@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1212&r2=1.1213 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.106&r2=1.107 --- LVM2/WHATS_NEW 2009/07/30 13:32:38 1.1212 +++ LVM2/WHATS_NEW 2009/07/30 17:18:03 1.1213 @@ -1,5 +1,6 @@ Version 2.02.51 - ================================ + Formalize pe_start policy as split between .pv_setup and .pv_write. Document -I option of clvmd in the man page. Fix configure script to handle multiple clvmd selections. Fix lvm2app.pc installation filename. --- LVM2/lib/format_text/format-text.c 2009/07/15 20:02:47 1.106 +++ LVM2/lib/format_text/format-text.c 2009/07/30 17:18:08 1.107 @@ -1595,6 +1595,13 @@ }; /* pvmetadatasize in sectors */ +/* + * pe_start policy: + * - In cases where a pre-existing pe_start is provided (pvcreate --restorefile + * and vgconvert): pe_start must not be changed (so pv->pe_start = pe_start). + * - In cases where pe_start is 0: leave pv->pe_start as 0 and defer the + * setting of pv->pe_start to .pv_write + */ static int _text_pv_setup(const struct format_type *fmt, uint64_t pe_start, uint32_t extent_count, uint32_t extent_size, unsigned long data_alignment, @@ -1702,9 +1709,6 @@ "%lu sectors (requested %lu sectors)", pv_dev_name(pv), pv->pe_align, data_alignment); - if (pv->pe_start < pv->pe_align) - pv->pe_start = pv->pe_align; - if (extent_count) pe_end = pe_start + extent_count * extent_size - 1; if (!_mda_setup(fmt, pe_start, pe_end, pvmetadatacopies,
next reply other threads:[~2009-07-30 17:18 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-30 17:18 snitzer [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 11:09 zkabelac 2011-08-29 13:37 prajnoha 2011-02-03 1:41 zkabelac 2010-10-26 9:13 zkabelac 2010-09-30 14:12 prajnoha 2010-06-01 12:08 prajnoha 2009-07-30 21:15 snitzer 2009-07-30 18:40 snitzer 2009-07-30 17:42 snitzer 2009-07-30 17:19 snitzer 2009-03-23 21:13 taka 2009-03-03 16:35 mbroz 2008-10-17 0:55 agk 2008-09-30 20:37 agk 2008-08-16 9:46 mbroz 2008-07-31 10:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090730171809.18591.qmail@sourceware.org \ --to=snitzer@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).