public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/format_text/format-text.c Date: Tue, 03 Mar 2009 16:35:00 -0000 [thread overview] Message-ID: <20090303163537.20000.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2009-03-03 16:35:35 Modified files: . : WHATS_NEW lib/format_text: format-text.c Log message: vgname_from_mda now tries to parse for vgname even if rlocn not defined (there is no metadata area). In most cases it fails in validate_name(), unfortunately there are situatuions, when validate_name is ok and later code fails with checksum error. Reproducer: # dd if=/dev/zero of=/dev/loop0 # pvcreate --metadatasize 637k /dev/loop0 Physical volume "/dev/loop0" successfully created # pvs /dev/loop0 /dev/loop0: Checksum error PV VG Fmt Attr PSize PFree /dev/loop0 lvm2 -- 1.00M 1.00M Signed-off-by: Milan Broz <mbroz@redhat.com> - Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1059&r2=1.1060 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format_text/format-text.c.diff?cvsroot=lvm2&r1=1.102&r2=1.103 --- LVM2/WHATS_NEW 2009/03/03 13:03:03 1.1059 +++ LVM2/WHATS_NEW 2009/03/03 16:35:32 1.1060 @@ -1,5 +1,6 @@ Version 2.02.45 - 3rd March 2009 ================================ + Avoid scanning empty metadata areas for VG names. Attempt proper clean up in child before executing new binary in exec_cmd(). Do not scan devices if reporting only attributes from PV label. Use pkgconfig to obtain corosync library details during configuration. --- LVM2/lib/format_text/format-text.c 2009/02/25 23:29:06 1.102 +++ LVM2/lib/format_text/format-text.c 2009/03/03 16:35:34 1.103 @@ -1061,6 +1061,12 @@ /* FIXME Cope with returning a list */ rlocn = mdah->raw_locns; + /* + * If no valid offset, do not try to search for vgname + */ + if (!rlocn->offset) + goto out; + /* Do quick check for a vgname */ if (!dev_read(dev_area->dev, dev_area->start + rlocn->offset, NAME_LEN, buf))
next reply other threads:[~2009-03-03 16:35 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-03-03 16:35 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-02-13 11:09 zkabelac 2011-08-29 13:37 prajnoha 2011-02-03 1:41 zkabelac 2010-10-26 9:13 zkabelac 2010-09-30 14:12 prajnoha 2010-06-01 12:08 prajnoha 2009-07-30 21:15 snitzer 2009-07-30 18:40 snitzer 2009-07-30 17:42 snitzer 2009-07-30 17:19 snitzer 2009-07-30 17:18 snitzer 2009-03-23 21:13 taka 2008-10-17 0:55 agk 2008-09-30 20:37 agk 2008-08-16 9:46 mbroz 2008-07-31 10:50 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090303163537.20000.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).