newlib-2.5.0 bug report

newlib-2.5.0 bug report

[David Binderman]

Hello there,

newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?

Source code is

              strcpy ((char *) newp->fname, runp->name);
              while(newp->fname != '\0') newp->fname++;

Maybe better code

              strcpy ((char *) newp->fname, runp->name);
              while(*(newp->fname) != '\0') newp->fname++;

Regards

David Binderman

Re: newlib-2.5.0 bug report

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On Apr 25 18:03, David Binderman wrote:
> Hello there,
> 
> newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?
> 
> Source code is
> 
>               strcpy ((char *) newp->fname, runp->name);
>               while(newp->fname != '\0') newp->fname++;
> 
> Maybe better code
> 
>               strcpy ((char *) newp->fname, runp->name);
>               while(*(newp->fname) != '\0') newp->fname++;
> 
> Regards
> 
> David Binderman

Makes sense.  Please send a patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]