* [PATCH] Added FTW.H Methods
@ 2020-08-12 21:38 Eshan dhawan
2020-08-13 8:16 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Eshan dhawan @ 2020-08-12 21:38 UTC (permalink / raw)
To: newlib; +Cc: joel, Eshan dhawan
Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
---
newlib/configure.host | 2 +-
newlib/libc/include/ftw.h | 64 ++++++++++++++
newlib/libc/posix/Makefile.am | 2 +-
newlib/libc/posix/ftw.c | 36 ++++++++
newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
5 files changed, 256 insertions(+), 2 deletions(-)
create mode 100644 newlib/libc/include/ftw.h
create mode 100644 newlib/libc/posix/ftw.c
create mode 100644 newlib/libc/posix/nftw.c
diff --git a/newlib/configure.host b/newlib/configure.host
index e3dbbc7fe..da7cba0ba 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -664,7 +664,7 @@ case "${host}" in
default_newlib_io_c99_formats="yes"
newlib_cflags="${newlib_cflags} -ffunction-sections -fdata-sections "
newlib_cflags="${newlib_cflags} -D_COMPILING_NEWLIB"
-newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DGETREENT_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
+newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DGETREENT_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC -D_FTW_ENABLE_"
# turn off unsupported items in posix directory
newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
;;
diff --git a/newlib/libc/include/ftw.h b/newlib/libc/include/ftw.h
new file mode 100644
index 000000000..f88ce87b2
--- /dev/null
+++ b/newlib/libc/include/ftw.h
@@ -0,0 +1,64 @@
+/*
+* Copyright © 2005-2020 Rich Felker, et al.
+*
+* Permission is hereby granted, free of charge, to any person obtaining
+* a copy of this software and associated documentation files (the
+* "Software"), to deal in the Software without restriction, including
+* without limitation the rights to use, copy, modify, merge, publish,
+* distribute, sublicense, and/or sell copies of the Software, and to
+* permit persons to whom the Software is furnished to do so, subject to
+* the following conditions:
+*
+* The above copyright notice and this permission notice shall be
+* included in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+#ifndef _FTW_H
+#define _FTW_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <sys/features.h>
+#include <sys/stat.h>
+
+#define FTW_F 1
+#define FTW_D 2
+#define FTW_DNR 3
+#define FTW_NS 4
+#define FTW_SL 5
+#define FTW_DP 6
+#define FTW_SLN 7
+
+#define FTW_PHYS 1
+#define FTW_MOUNT 2
+#define FTW_CHDIR 4
+#define FTW_DEPTH 8
+
+struct FTW {
+ int base;
+ int level;
+};
+
+int ftw(const char *, int (*)(const char *, const struct stat *, int), int);
+int nftw(const char *, int (*)(const char *, const struct stat *, int, struct FTW *), int, int);
+
+#if defined(_LARGEFILE64_SOURCE) || defined(_GNU_SOURCE)
+#define ftw64 ftw
+#define nftw64 nftw
+#endif
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif
diff --git a/newlib/libc/posix/Makefile.am b/newlib/libc/posix/Makefile.am
index 6cdee1df0..5a358f782 100644
--- a/newlib/libc/posix/Makefile.am
+++ b/newlib/libc/posix/Makefile.am
@@ -10,7 +10,7 @@ GENERAL_SOURCES = \
opendir.c readdir.c readdir_r.c \
regcomp.c regerror.c regexec.c regfree.c \
rewinddir.c sleep.c usleep.c \
- telldir.c
+ telldir.c ftw.c nftw.c
ELIX_2_SOURCES = \
scandir.c seekdir.c
diff --git a/newlib/libc/posix/ftw.c b/newlib/libc/posix/ftw.c
new file mode 100644
index 000000000..c295fa984
--- /dev/null
+++ b/newlib/libc/posix/ftw.c
@@ -0,0 +1,36 @@
+/*
+* Copyright © 2005-2020 Rich Felker, et al.
+*
+* Permission is hereby granted, free of charge, to any person obtaining
+* a copy of this software and associated documentation files (the
+* "Software"), to deal in the Software without restriction, including
+* without limitation the rights to use, copy, modify, merge, publish,
+* distribute, sublicense, and/or sell copies of the Software, and to
+* permit persons to whom the Software is furnished to do so, subject to
+* the following conditions:
+*
+* The above copyright notice and this permission notice shall be
+* included in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+#ifdef _FTW_ENABLE_
+#include <ftw.h>
+
+int ftw(const char *path, int (*fn)(const char *, const struct stat *, int), int fd_limit)
+{
+ /* The following cast assumes that calling a function with one
+ * argument more than it needs behaves as expected. This is
+ * actually undefined, but works on all real-world machines. */
+ return nftw(path, (int (*)())fn, fd_limit, FTW_PHYS);
+}
+
+weak_alias(ftw, ftw64);
+#endif /* _FTW_ENABLE_ */
diff --git a/newlib/libc/posix/nftw.c b/newlib/libc/posix/nftw.c
new file mode 100644
index 000000000..df0701cca
--- /dev/null
+++ b/newlib/libc/posix/nftw.c
@@ -0,0 +1,154 @@
+/*
+* Copyright © 2005-2020 Rich Felker, et al.
+*
+* Permission is hereby granted, free of charge, to any person obtaining
+* a copy of this software and associated documentation files (the
+* "Software"), to deal in the Software without restriction, including
+* without limitation the rights to use, copy, modify, merge, publish,
+* distribute, sublicense, and/or sell copies of the Software, and to
+* permit persons to whom the Software is furnished to do so, subject to
+* the following conditions:
+*
+* The above copyright notice and this permission notice shall be
+* included in all copies or substantial portions of the Software.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+*/
+
+#ifdef _FTW_ENABLE_
+#include <ftw.h>
+#include <dirent.h>
+#include <sys/stat.h>
+#include <errno.h>
+#include <unistd.h>
+#include <string.h>
+#include <limits.h>
+#include <pthread.h>
+
+struct history
+{
+ struct history *chain;
+ dev_t dev;
+ ino_t ino;
+ int level;
+ int base;
+};
+
+#undef dirfd
+#define dirfd(d) (*(int *)d)
+
+static int do_nftw(char *path, int (*fn)(const char *, const struct stat *, int, struct FTW *), int fd_limit, int flags, struct history *h)
+{
+ size_t l = strlen(path), j = l && path[l-1]=='/' ? l-1 : l;
+ struct stat st;
+ struct history new;
+ int type;
+ int r;
+ struct FTW lev;
+
+ if ((flags & FTW_PHYS) ? lstat(path, &st) : stat(path, &st) < 0) {
+ if (!(flags & FTW_PHYS) && errno==ENOENT && !lstat(path, &st))
+ type = FTW_SLN;
+ else if (errno != EACCES) return -1;
+ else type = FTW_NS;
+ } else if (S_ISDIR(st.st_mode)) {
+ if (access(path, R_OK) < 0) type = FTW_DNR;
+ else if (flags & FTW_DEPTH) type = FTW_DP;
+ else type = FTW_D;
+ } else if (S_ISLNK(st.st_mode)) {
+ if (flags & FTW_PHYS) type = FTW_SL;
+ else type = FTW_SLN;
+ } else {
+ type = FTW_F;
+ }
+
+ if ((flags & FTW_MOUNT) && h && st.st_dev != h->dev)
+ return 0;
+
+ new.chain = h;
+ new.dev = st.st_dev;
+ new.ino = st.st_ino;
+ new.level = h ? h->level+1 : 0;
+ new.base = j+1;
+
+ lev.level = new.level;
+ if (h) {
+ lev.base = h->base;
+ } else {
+ size_t k;
+ for (k=j; k && path[k]=='/'; k--);
+ for (; k && path[k-1]!='/'; k--);
+ lev.base = k;
+ }
+
+ if (!(flags & FTW_DEPTH) && (r=fn(path, &st, type, &lev)))
+ return r;
+
+ for (; h; h = h->chain)
+ if (h->dev == st.st_dev && h->ino == st.st_ino)
+ return 0;
+
+ if ((type == FTW_D || type == FTW_DP) && fd_limit) {
+ DIR *d = opendir(path);
+ if (d) {
+ struct dirent *de;
+ while ((de = readdir(d))) {
+ if (de->d_name[0] == '.'
+ && (!de->d_name[1]
+ || (de->d_name[1]=='.'
+ && !de->d_name[2]))) continue;
+ if (strlen(de->d_name) >= PATH_MAX-l) {
+ errno = ENAMETOOLONG;
+ closedir(d);
+ return -1;
+ }
+ path[j]='/';
+ strcpy(path+j+1, de->d_name);
+ if ((r=do_nftw(path, fn, fd_limit-1, flags, &new))) {
+ closedir(d);
+ return r;
+ }
+ }
+ closedir(d);
+ } else if (errno != EACCES) {
+ return -1;
+ }
+ }
+
+ path[l] = 0;
+ if ((flags & FTW_DEPTH) && (r=fn(path, &st, type, &lev)))
+ return r;
+
+ return 0;
+}
+
+int nftw(const char *path, int (*fn)(const char *, const struct stat *, int, struct FTW *), int fd_limit, int flags)
+{
+ int r, cs;
+ size_t l;
+ char pathbuf[PATH_MAX+1];
+
+ if (fd_limit <= 0) return 0;
+
+ l = strlen(path);
+ if (l > PATH_MAX) {
+ errno = ENAMETOOLONG;
+ return -1;
+ }
+ memcpy(pathbuf, path, l+1);
+
+ pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs);
+ r = do_nftw(pathbuf, fn, fd_limit, flags, NULL);
+ pthread_setcancelstate(cs, 0);
+ return r;
+}
+
+weak_alias(nftw, nftw64);
+
+#endif /* _FTW_ENABLE_ */
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added FTW.H Methods
2020-08-12 21:38 [PATCH] Added FTW.H Methods Eshan dhawan
@ 2020-08-13 8:16 ` Corinna Vinschen
2020-08-13 13:11 ` Joel Sherrill
0 siblings, 1 reply; 6+ messages in thread
From: Corinna Vinschen @ 2020-08-13 8:16 UTC (permalink / raw)
To: Eshan dhawan; +Cc: newlib, joel
On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> ---
> newlib/configure.host | 2 +-
> newlib/libc/include/ftw.h | 64 ++++++++++++++
> newlib/libc/posix/Makefile.am | 2 +-
> newlib/libc/posix/ftw.c | 36 ++++++++
> newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> 5 files changed, 256 insertions(+), 2 deletions(-)
> create mode 100644 newlib/libc/include/ftw.h
> create mode 100644 newlib/libc/posix/ftw.c
> create mode 100644 newlib/libc/posix/nftw.c
Why do we need _FTW_ENABLE_?
What do we need the foo64 variants for? WHile newlib defines
_LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
anywhere else in newlib itself.
Also, there's a ftw/nftw implementation in Cygwin already. Did you
check it for inclusion into newlib, or to drop the Cygwin version in
favor of a new newlib versions? We could at least share a common
header, but then we will have to use the flag values already used in
the Cygwin implementation for backward compatibility.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added FTW.H Methods
2020-08-13 8:16 ` Corinna Vinschen
@ 2020-08-13 13:11 ` Joel Sherrill
2020-08-17 9:42 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Joel Sherrill @ 2020-08-13 13:11 UTC (permalink / raw)
To: Newlib, Eshan dhawan, joel; +Cc: Corinna Vinschen
On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib <
newlib@sourceware.org> wrote:
> On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> > Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> > ---
> > newlib/configure.host | 2 +-
> > newlib/libc/include/ftw.h | 64 ++++++++++++++
> > newlib/libc/posix/Makefile.am | 2 +-
> > newlib/libc/posix/ftw.c | 36 ++++++++
> > newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> > 5 files changed, 256 insertions(+), 2 deletions(-)
> > create mode 100644 newlib/libc/include/ftw.h
> > create mode 100644 newlib/libc/posix/ftw.c
> > create mode 100644 newlib/libc/posix/nftw.c
>
> Why do we need _FTW_ENABLE_?
>
> What do we need the foo64 variants for? WHile newlib defines
> _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
> anywhere else in newlib itself.
>
> Also, there's a ftw/nftw implementation in Cygwin already. Did you
> check it for inclusion into newlib, or to drop the Cygwin version in
> favor of a new newlib versions? We could at least share a common
> header, but then we will have to use the flag values already used in
> the Cygwin implementation for backward compatibility.
>
We went straight to *BSD for implementations and didn't look at Cygwin.
I've asked Eshan to replace the implementation with the Cygwin one.
Hopefully that's easy and allows one more piece of shared software.
--joel
>
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added FTW.H Methods
2020-08-13 13:11 ` Joel Sherrill
@ 2020-08-17 9:42 ` Corinna Vinschen
2020-08-17 10:40 ` Eshan Dhawan
0 siblings, 1 reply; 6+ messages in thread
From: Corinna Vinschen @ 2020-08-17 9:42 UTC (permalink / raw)
To: Joel Sherrill; +Cc: Newlib, Eshan dhawan, joel
On Aug 13 08:11, Joel Sherrill wrote:
> On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib <
> newlib@sourceware.org> wrote:
>
> > On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> > > Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> > > ---
> > > newlib/configure.host | 2 +-
> > > newlib/libc/include/ftw.h | 64 ++++++++++++++
> > > newlib/libc/posix/Makefile.am | 2 +-
> > > newlib/libc/posix/ftw.c | 36 ++++++++
> > > newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> > > 5 files changed, 256 insertions(+), 2 deletions(-)
> > > create mode 100644 newlib/libc/include/ftw.h
> > > create mode 100644 newlib/libc/posix/ftw.c
> > > create mode 100644 newlib/libc/posix/nftw.c
> >
> > Why do we need _FTW_ENABLE_?
> >
> > What do we need the foo64 variants for? WHile newlib defines
> > _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
> > anywhere else in newlib itself.
> >
> > Also, there's a ftw/nftw implementation in Cygwin already. Did you
> > check it for inclusion into newlib, or to drop the Cygwin version in
> > favor of a new newlib versions? We could at least share a common
> > header, but then we will have to use the flag values already used in
> > the Cygwin implementation for backward compatibility.
> >
>
> We went straight to *BSD for implementations and didn't look at Cygwin.
Cygwin's ftw is OpenBSD. Which BSD is this ftw taken from?
> I've asked Eshan to replace the implementation with the Cygwin one.
> Hopefully that's easy and allows one more piece of shared software.
It's not *that* easy because OpenBSD's/Cygwin's ftw(3) uses fts(3) under
the hood.
While sharing code is good, your implementation is more compact, which
speaks for your code.
However, I'd like to ask for ftw.h compatibility at least, so perhaps
Cygwin can use this other ftw, too at one point.
But even then, there's still the _FTW_ENABLE_ and _LARGEFILE64_SOURCE
stuff I asked about.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added FTW.H Methods
2020-08-17 9:42 ` Corinna Vinschen
@ 2020-08-17 10:40 ` Eshan Dhawan
2020-08-17 15:38 ` Corinna Vinschen
0 siblings, 1 reply; 6+ messages in thread
From: Eshan Dhawan @ 2020-08-17 10:40 UTC (permalink / raw)
To: newlib; +Cc: Joel Sherrill, joel
> On 17-Aug-2020, at 3:12 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
>
> On Aug 13 08:11, Joel Sherrill wrote:
>>> On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib <
>>> newlib@sourceware.org> wrote:
>>>
>>> On Aug 13 03:08, Eshan dhawan via Newlib wrote:
>>>> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
>>>> ---
>>>> newlib/configure.host | 2 +-
>>>> newlib/libc/include/ftw.h | 64 ++++++++++++++
>>>> newlib/libc/posix/Makefile.am | 2 +-
>>>> newlib/libc/posix/ftw.c | 36 ++++++++
>>>> newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
>>>> 5 files changed, 256 insertions(+), 2 deletions(-)
>>>> create mode 100644 newlib/libc/include/ftw.h
>>>> create mode 100644 newlib/libc/posix/ftw.c
>>>> create mode 100644 newlib/libc/posix/nftw.c
>>>
>>> Why do we need _FTW_ENABLE_?
>>>
>>> What do we need the foo64 variants for? WHile newlib defines
>>> _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
>>> anywhere else in newlib itself.
>>>
>>> Also, there's a ftw/nftw implementation in Cygwin already. Did you
>>> check it for inclusion into newlib, or to drop the Cygwin version in
>>> favor of a new newlib versions? We could at least share a common
>>> header, but then we will have to use the flag values already used in
>>> the Cygwin implementation for backward compatibility.
>>>
>>
>> We went straight to *BSD for implementations and didn't look at Cygwin.
>
> Cygwin's ftw is OpenBSD. Which BSD is this ftw taken from?
It’s taken from MUSL Libc
>
>> I've asked Eshan to replace the implementation with the Cygwin one.
>> Hopefully that's easy and allows one more piece of shared software.
>
> It's not *that* easy because OpenBSD's/Cygwin's ftw(3) uses fts(3) under
> the hood.
That’s the same reason We couldn’t use FTW from BSD
>
> While sharing code is good, your implementation is more compact, which
> speaks for your code.
>
> However, I'd like to ask for ftw.h compatibility at least, so perhaps
> Cygwin can use this other ftw, too at one point.
>
> But even then, there's still the _FTW_ENABLE_ and _LARGEFILE64_SOURCE
> stuff I asked about.
_FTW_ENABLE_ was there because the FTW implementation required pthread_setcancelstate ()
>
>
> Thanks,
> Corinna
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added FTW.H Methods
2020-08-17 10:40 ` Eshan Dhawan
@ 2020-08-17 15:38 ` Corinna Vinschen
0 siblings, 0 replies; 6+ messages in thread
From: Corinna Vinschen @ 2020-08-17 15:38 UTC (permalink / raw)
To: Eshan Dhawan; +Cc: newlib, joel
On Aug 17 16:10, Eshan Dhawan via Newlib wrote:
>
> > On 17-Aug-2020, at 3:12 PM, Corinna Vinschen <vinschen@redhat.com> wrote:
> >
> > On Aug 13 08:11, Joel Sherrill wrote:
> >>> On Thu, Aug 13, 2020 at 3:17 AM Corinna Vinschen via Newlib <
> >>> newlib@sourceware.org> wrote:
> >>>
> >>> On Aug 13 03:08, Eshan dhawan via Newlib wrote:
> >>>> Signed-off-by: Eshan dhawan <eshandhawan51@gmail.com>
> >>>> ---
> >>>> newlib/configure.host | 2 +-
> >>>> newlib/libc/include/ftw.h | 64 ++++++++++++++
> >>>> newlib/libc/posix/Makefile.am | 2 +-
> >>>> newlib/libc/posix/ftw.c | 36 ++++++++
> >>>> newlib/libc/posix/nftw.c | 154 ++++++++++++++++++++++++++++++++++
> >>>> 5 files changed, 256 insertions(+), 2 deletions(-)
> >>>> create mode 100644 newlib/libc/include/ftw.h
> >>>> create mode 100644 newlib/libc/posix/ftw.c
> >>>> create mode 100644 newlib/libc/posix/nftw.c
> >>>
> >>> Why do we need _FTW_ENABLE_?
> >>>
> >>> What do we need the foo64 variants for? WHile newlib defines
> >>> _LARGEFILE64_SOURCE for __linux__ and __RDOS__, it's not used
> >>> anywhere else in newlib itself.
> >>>
> >>> Also, there's a ftw/nftw implementation in Cygwin already. Did you
> >>> check it for inclusion into newlib, or to drop the Cygwin version in
> >>> favor of a new newlib versions? We could at least share a common
> >>> header, but then we will have to use the flag values already used in
> >>> the Cygwin implementation for backward compatibility.
> >>>
> >>
> >> We went straight to *BSD for implementations and didn't look at Cygwin.
> >
> > Cygwin's ftw is OpenBSD. Which BSD is this ftw taken from?
> It’s taken from MUSL Libc
Ok.
> >> I've asked Eshan to replace the implementation with the Cygwin one.
> >> Hopefully that's easy and allows one more piece of shared software.
> >
> > It's not *that* easy because OpenBSD's/Cygwin's ftw(3) uses fts(3) under
> > the hood.
> That’s the same reason We couldn’t use FTW from BSD
> >
> > While sharing code is good, your implementation is more compact, which
> > speaks for your code.
> >
> > However, I'd like to ask for ftw.h compatibility at least, so perhaps
> > Cygwin can use this other ftw, too at one point.
> >
> > But even then, there's still the _FTW_ENABLE_ and _LARGEFILE64_SOURCE
> > stuff I asked about.
> _FTW_ENABLE_ was there because the FTW implementation required pthread_setcancelstate ()
That puzzles me a bit. Not setting _FTW_ENABLE_ disables ftw entirely,
just because it requires pthread_setcancelstate. However, newlib
already supports a flag _STDIO_WITH_THREAD_CANCELLATION_SUPPORT to call
pthread_setcancelstate only on targets providing it, see, for instance,
newlib/libc/stdio/freopen.c. ftw could simply do the same.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-17 15:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 21:38 [PATCH] Added FTW.H Methods Eshan dhawan
2020-08-13 8:16 ` Corinna Vinschen
2020-08-13 13:11 ` Joel Sherrill
2020-08-17 9:42 ` Corinna Vinschen
2020-08-17 10:40 ` Eshan Dhawan
2020-08-17 15:38 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).