From: Joel Sherrill <joel.sherrill@oarcorp.com>
To: newlib@sourceware.org, aditya upadhyay <aadit0402@gmail.com>
Subject: Re: Long double complex methods
Date: Thu, 29 Jun 2017 13:47:00 -0000 [thread overview]
Message-ID: <372bbc8f-afbc-2c26-2586-1f7bdf76fb33@oarcorp.com> (raw)
In-Reply-To: <20170629063911.GB31936@calimero.vinschen.de>
On 6/29/2017 1:39 AM, Corinna Vinschen wrote:
> Hi Aditya,
>
> On Jun 29 02:04, Aditya Upadhyay wrote:
>> Hello Developers,
>>
>> I have ported all long double complex methods with suffix "l" from
>> NetBSD. I am attaching the patches for all the methods. I am
>> requesting you to please review these patches and point me any
>> modification needed.
>>
>> Thanks & Regards,
> [...]
>
> Looks good, just the last patch in the series:
>
>> Subject: [PATCH 18/18] Importing csinl.c from NetBSD.
>
> is missing the Makefile.am change. Care to resend a v2 of patch 18?
Aditya may not need this but it won't hurt to post a hint. git
format-patch has some interesting options. The "-v N" option
adds a version number to the subject so it is clear on mailing
lists which patches are v1 and which are subsequent versions.
Something like this:
git format-patch -o DIRECTORY -v N MY_BRANCH master
I always dump the patches into a subdirectory since the names
are so long they tend to clutter up a normal source directory.
Also it makes it easier to use git send-email to send a patch
set to a mailing list.
> Thanks,
> Corinna
>
--joel
next prev parent reply other threads:[~2017-06-29 13:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 20:35 Aditya Upadhyay
2017-06-28 21:36 ` Dionna Amalie Glaze via newlib
2017-06-28 21:57 ` Joel Sherrill
2017-06-29 16:18 ` Joseph Myers
2017-06-29 16:31 ` Joel Sherrill
2017-06-29 6:39 ` Corinna Vinschen
2017-06-29 7:11 ` Aditya Upadhyay
2017-06-29 11:53 ` Corinna Vinschen
2017-06-29 12:04 ` Corinna Vinschen
2017-06-29 19:38 ` Yaakov Selkowitz
2017-06-29 21:17 ` Joel Sherrill
2017-06-30 9:11 ` Aditya Upadhyay
2017-07-04 21:31 ` Aditya Upadhyay
2017-07-04 21:56 ` Aditya Upadhyay
2017-07-05 8:27 ` Corinna Vinschen
2017-07-05 9:02 ` Aditya Upadhyay
2017-07-05 12:40 ` Corinna Vinschen
2022-11-08 18:31 ` [newlib] Generally make all 'long double complex' methods available in <complex.h> Thomas Schwinge
2022-11-08 20:24 ` Jeff Johnston
2017-06-29 13:47 ` Joel Sherrill [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-28 13:53 Long double complex methods Aditya Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=372bbc8f-afbc-2c26-2586-1f7bdf76fb33@oarcorp.com \
--to=joel.sherrill@oarcorp.com \
--cc=aadit0402@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).