Include FD_SETSIZE on RTEMS to 256

Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1.1: Type: text/plain, Size: 105 bytes --]

Hi

The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.

Is it OK to apply?

Thanks.

--joel

[-- Attachment #2: 0001-RTEMS-Increase-FS_SETSIZE-to-256-bits.patch --]
[-- Type: application/octet-stream, Size: 690 bytes --]

From 081fc6c8e64568cef8bcd9c254e72cbfb8de1a2d Mon Sep 17 00:00:00 2001
From: Chris Johns <chrisj@rtems.org>
Date: Tue, 20 Feb 2024 11:46:05 +1100
Subject: [PATCH] RTEMS: Increase FS_SETSIZE to 256 bits

---
 newlib/libc/include/sys/select.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/newlib/libc/include/sys/select.h b/newlib/libc/include/sys/select.h
index 93d0b79bf..8b5675640 100644
--- a/newlib/libc/include/sys/select.h
+++ b/newlib/libc/include/sys/select.h
@@ -30,6 +30,8 @@ typedef	__sigset_t	sigset_t;
 #ifndef FD_SETSIZE
 # ifdef __CYGWIN__
 #  define FD_SETSIZE	1024
+# elifdef __rtems__
+#  define FD_SETSIZE	256
 # else
 #  define FD_SETSIZE	64
 # endif
-- 
2.42.0

Re: Include FD_SETSIZE on RTEMS to 256

[Sebastian Huber]

Hello Joel,

it seems in the patch you set it to 25 and not 256.

On 29.02.24 00:02, Joel Sherrill wrote:
> Hi
> 
> The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> 
> Is it OK to apply?
> 
> Thanks.
> 
> --joel

-- 
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

Re: Include FD_SETSIZE on RTEMS to 256

[Sebastian Huber]

On 29.02.24 07:29, Sebastian Huber wrote:
> Hello Joel,
> 
> it seems in the patch you set it to 25 and not 256.

No, sorry, this was a display problem. The patch is fine.

-- 
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/

Re: Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Thu, Feb 29, 2024 at 12:31 AM Sebastian Huber <
sebastian.huber@embedded-brains.de> wrote:

> On 29.02.24 07:29, Sebastian Huber wrote:
> > Hello Joel,
> >
> > it seems in the patch you set it to 25 and not 256.
>
> No, sorry, this was a display problem. The patch is fine.
>

I was worried I had screwed it up getting it from the RTEMS ticket,
reviewing it in
vi, applying it locally, and then sending it.  Accidentally deleting a
character would
not have surprised me.

Now just waiting for an Ack from Corinna or Jeff.

--joel

>
> --
> embedded brains GmbH & Co. KG
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.huber@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
>

Re: Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

Is this OK to commit now? It has been almost two weeks since the last
activity.

--joel

On Thu, Feb 29, 2024 at 8:24 AM Joel Sherrill <joel@rtems.org> wrote:

>
>
> On Thu, Feb 29, 2024 at 12:31 AM Sebastian Huber <
> sebastian.huber@embedded-brains.de> wrote:
>
>> On 29.02.24 07:29, Sebastian Huber wrote:
>> > Hello Joel,
>> >
>> > it seems in the patch you set it to 25 and not 256.
>>
>> No, sorry, this was a display problem. The patch is fine.
>>
>
> I was worried I had screwed it up getting it from the RTEMS ticket,
> reviewing it in
> vi, applying it locally, and then sending it.  Accidentally deleting a
> character would
> not have surprised me.
>
> Now just waiting for an Ack from Corinna or Jeff.
>
> --joel
>
>>
>> --
>> embedded brains GmbH & Co. KG
>> Herr Sebastian HUBER
>> Dornierstr. 4
>> 82178 Puchheim
>> Germany
>> email: sebastian.huber@embedded-brains.de
>> phone: +49-89-18 94 741 - 16
>> fax:   +49-89-18 94 741 - 08
>>
>> Registergericht: Amtsgericht München
>> Registernummer: HRB 157899
>> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
>> Unsere Datenschutzerklärung finden Sie hier:
>> https://embedded-brains.de/datenschutzerklaerung/
>>
>

Re: Include FD_SETSIZE on RTEMS to 256

[Corinna Vinschen]

On Mar 11 09:50, Joel Sherrill wrote:
> Is this OK to commit now? It has been almost two weeks since the last
> activity.

Sorry for the delay, but if the patch only affects RTEMS, you and
Sebastian don't have to wait for Jeff or me.


Corinna

Re: Include FD_SETSIZE on RTEMS to 256

[Jon Turney]

On 28/02/2024 23:02, Joel Sherrill wrote:
> Hi
> 
> The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> 
> Is it OK to apply?
> 

This uses the preprocessor directive '#elifdef',

It seems like support for that was added in gcc 12.

Re: Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk>
wrote:

> On 28/02/2024 23:02, Joel Sherrill wrote:
> > Hi
> >
> > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> >
> > Is it OK to apply?
> >
>
> This uses the preprocessor directive '#elifdef',
>
> It seems like support for that was added in gcc 12.
>

Good catch. Unfortunately, I just pushed the posted patch just before your
email arrived.

I have posted a small patch to change this to #elif defined(__rtems__). If
someone acks it, I will push it quickly to minimize who might be impacted.

There should be no dependencies in newlib for any toolchain that is that
recent.

--joel

Re: Include FD_SETSIZE on RTEMS to 256

[Corinna Vinschen]

On Mar 13 09:35, Joel Sherrill wrote:
> On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk>
> wrote:
> 
> > On 28/02/2024 23:02, Joel Sherrill wrote:
> > > Hi
> > >
> > > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> > >
> > > Is it OK to apply?
> > >
> >
> > This uses the preprocessor directive '#elifdef',
> >
> > It seems like support for that was added in gcc 12.
> >
> 
> Good catch. Unfortunately, I just pushed the posted patch just before your
> email arrived.
> 
> I have posted a small patch to change this to #elif defined(__rtems__). If
> someone acks it, I will push it quickly to minimize who might be impacted.

You sent the wrong patch apparently.  However, if your patch just
changes #elifdef X to #elif defined (X), then test it with a pre-12
gcc and then push it.  Soon.


Corinna

Re: Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

On Wed, Mar 13, 2024 at 10:02 AM Corinna Vinschen <vinschen@redhat.com>
wrote:

> On Mar 13 09:35, Joel Sherrill wrote:
> > On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk>
> > wrote:
> >
> > > On 28/02/2024 23:02, Joel Sherrill wrote:
> > > > Hi
> > > >
> > > > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> > > >
> > > > Is it OK to apply?
> > > >
> > >
> > > This uses the preprocessor directive '#elifdef',
> > >
> > > It seems like support for that was added in gcc 12.
> > >
> >
> > Good catch. Unfortunately, I just pushed the posted patch just before
> your
> > email arrived.
> >
> > I have posted a small patch to change this to #elif defined(__rtems__).
> If
> > someone acks it, I will push it quickly to minimize who might be
> impacted.
>
> You sent the wrong patch apparently.  However, if your patch just
> changes #elifdef X to #elif defined (X), then test it with a pre-12
> gcc and then push it.  Soon.
>

Sorry. I am building a gcc8 toolchain now to verify the change. Hopefully,
it will not be too much longer.

>
>
> Corinna
>
>

Re: Include FD_SETSIZE on RTEMS to 256

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

On Wed, Mar 13, 2024 at 11:03 AM Joel Sherrill <joel@rtems.org> wrote:

>
>
> On Wed, Mar 13, 2024 at 10:02 AM Corinna Vinschen <vinschen@redhat.com>
> wrote:
>
>> On Mar 13 09:35, Joel Sherrill wrote:
>> > On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk
>> >
>> > wrote:
>> >
>> > > On 28/02/2024 23:02, Joel Sherrill wrote:
>> > > > Hi
>> > > >
>> > > > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
>> > > >
>> > > > Is it OK to apply?
>> > > >
>> > >
>> > > This uses the preprocessor directive '#elifdef',
>> > >
>> > > It seems like support for that was added in gcc 12.
>> > >
>> >
>> > Good catch. Unfortunately, I just pushed the posted patch just before
>> your
>> > email arrived.
>> >
>> > I have posted a small patch to change this to #elif defined(__rtems__).
>> If
>> > someone acks it, I will push it quickly to minimize who might be
>> impacted.
>>
>> You sent the wrong patch apparently.  However, if your patch just
>> changes #elifdef X to #elif defined (X), then test it with a pre-12
>> gcc and then push it.  Soon.
>>
>
> Sorry. I am building a gcc8 toolchain now to verify the change. Hopefully,
> it will not be too much longer.
>

Correction pushed and tested with gcc8 and a test program.

--joel

>
>>
>> Corinna
>>
>>

Re: Include FD_SETSIZE on RTEMS to 256

[Corinna Vinschen]

On Mar 13 11:33, Joel Sherrill wrote:
> On Wed, Mar 13, 2024 at 11:03 AM Joel Sherrill <joel@rtems.org> wrote:
> 
> >
> >
> > On Wed, Mar 13, 2024 at 10:02 AM Corinna Vinschen <vinschen@redhat.com>
> > wrote:
> >
> >> On Mar 13 09:35, Joel Sherrill wrote:
> >> > On Wed, Mar 13, 2024 at 9:21 AM Jon Turney <jon.turney@dronecode.org.uk
> >> >
> >> > wrote:
> >> >
> >> > > On 28/02/2024 23:02, Joel Sherrill wrote:
> >> > > > Hi
> >> > > >
> >> > > > The attached patch changes FD_SETSIZE from 64 to 256 for RTEMS.
> >> > > >
> >> > > > Is it OK to apply?
> >> > > >
> >> > >
> >> > > This uses the preprocessor directive '#elifdef',
> >> > >
> >> > > It seems like support for that was added in gcc 12.
> >> > >
> >> >
> >> > Good catch. Unfortunately, I just pushed the posted patch just before
> >> your
> >> > email arrived.
> >> >
> >> > I have posted a small patch to change this to #elif defined(__rtems__).
> >> If
> >> > someone acks it, I will push it quickly to minimize who might be
> >> impacted.
> >>
> >> You sent the wrong patch apparently.  However, if your patch just
> >> changes #elifdef X to #elif defined (X), then test it with a pre-12
> >> gcc and then push it.  Soon.
> >>
> >
> > Sorry. I am building a gcc8 toolchain now to verify the change. Hopefully,
> > it will not be too much longer.
> >
> 
> Correction pushed and tested with gcc8 and a test program.
> 
> --joel

Thanks!

Corinna