* [RFA] Fix build failure on visium & iq2000
@ 2021-07-02 17:23 Jeff Law
2021-07-05 20:46 ` Jeff Johnston
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2021-07-02 17:23 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
visium and iq2000 have libgloss configure bits that reference
target_makefile_frag, but it's never set. This leads to failures during
the configure process and an empty libgloss/<target>/Makefile.
Naturally bad things happen with an empty Makefile.
This patch initializes target_makefile_frag for both targets in their
configure.in files and updates the generated configure files. This
fixes the build failures. I've been using it in my tester for about a
week and both targets have flipped from consistently failing to
consistently passing.
* libgloss/visium/configure.in (target_makefile_frag): Define.
* libgloss/visium/configure: Regenerated.
* libgloss/iq2000/configure.in (target_makefile_frag): Define.
* libgloss/iq2000/configure: Regenerated.
OK for the trunk? I think I've still got commit privs.
Jeff
[-- Attachment #2: libgloss.patch --]
[-- Type: text/plain, Size: 1683 bytes --]
diff --git a/libgloss/iq2000/configure.in b/libgloss/iq2000/configure.in
index 9cbd7e2ea..754ee3cab 100644
--- a/libgloss/iq2000/configure.in
+++ b/libgloss/iq2000/configure.in
@@ -46,6 +46,7 @@ AC_PROG_RANLIB
LIB_AM_PROG_AS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
if test "${with_multisubdir}" = "m32"; then
LD_TYPE="m32"
diff --git a/libgloss/visium/configure.in b/libgloss/visium/configure.in
index 33c1872c7..5274ba668 100644
--- a/libgloss/visium/configure.in
+++ b/libgloss/visium/configure.in
@@ -33,6 +33,7 @@ AC_PROG_RANLIB
LIB_AM_PROG_AS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
dnl We have to assign the same value to other variables because autoconf
dnl doesn't provide a mechanism to substitute a replacement keyword with
diff --git a/libgloss/iq2000/configure b/libgloss/iq2000/configure
index 66a533bc8..4411837d4 100755
--- a/libgloss/iq2000/configure
+++ b/libgloss/iq2000/configure
@@ -2520,6 +2520,7 @@ test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
if test "${with_multisubdir}" = "m32"; then
LD_TYPE="m32"
diff --git a/libgloss/visium/configure b/libgloss/visium/configure
index f1bb39a11..abd6f5b92 100755
--- a/libgloss/visium/configure
+++ b/libgloss/visium/configure
@@ -1946,6 +1946,7 @@ test "${CCASFLAGS+set}" = set || CCASFLAGS=$CFLAGS
host_makefile_frag=${srcdir}/../config/default.mh
+target_makefile_frag=${srcdir}/../config/default.mt
host_makefile_frag_path=$host_makefile_frag
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix build failure on visium & iq2000
2021-07-02 17:23 [RFA] Fix build failure on visium & iq2000 Jeff Law
@ 2021-07-05 20:46 ` Jeff Johnston
2021-07-06 15:15 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnston @ 2021-07-05 20:46 UTC (permalink / raw)
To: Jeff Law; +Cc: Newlib
Hi Jeff,
Go ahead if you have commit privileges. Otherwise, let me know and I'll
post it for you.
-- Jeff J.
On Fri, Jul 2, 2021 at 1:24 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
> visium and iq2000 have libgloss configure bits that reference
> target_makefile_frag, but it's never set. This leads to failures during
> the configure process and an empty libgloss/<target>/Makefile.
> Naturally bad things happen with an empty Makefile.
>
> This patch initializes target_makefile_frag for both targets in their
> configure.in files and updates the generated configure files. This
> fixes the build failures. I've been using it in my tester for about a
> week and both targets have flipped from consistently failing to
> consistently passing.
>
>
>
> * libgloss/visium/configure.in (target_makefile_frag): Define.
> * libgloss/visium/configure: Regenerated.
> * libgloss/iq2000/configure.in (target_makefile_frag): Define.
> * libgloss/iq2000/configure: Regenerated.
>
>
> OK for the trunk? I think I've still got commit privs.
>
> Jeff
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix build failure on visium & iq2000
2021-07-05 20:46 ` Jeff Johnston
@ 2021-07-06 15:15 ` Jeff Law
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Law @ 2021-07-06 15:15 UTC (permalink / raw)
To: Jeff Johnston; +Cc: Newlib
On 7/5/2021 2:46 PM, Jeff Johnston wrote:
> Hi Jeff,
>
> Go ahead if you have commit privileges. Otherwise, let me know and
> I'll post it for you.
Thanks. Done.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-06 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 17:23 [RFA] Fix build failure on visium & iq2000 Jeff Law
2021-07-05 20:46 ` Jeff Johnston
2021-07-06 15:15 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).