From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Haochen Jiang <haochen.jiang@intel.com>,
konglin1 <lingling.kong@intel.com>,
binutils@sourceware.org
Subject: Re: [PATCH 1/2] i386: Add <Vxy> and <Exy>
Date: Mon, 31 Oct 2022 09:30:29 -0700 [thread overview]
Message-ID: <CAMe9rOrL7uKTo-KtAtdrydSQ1Kzv7D6PLWZQ65Tw9f8+=USGAQ@mail.gmail.com> (raw)
In-Reply-To: <f32c29ea-bfa2-0a54-a70b-446177d07c22@suse.com>
On Mon, Oct 31, 2022 at 2:04 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 31.10.2022 07:06, Haochen Jiang wrote:
> > From: konglin1 <lingling.kong@intel.com>
> >
> > opcodes/
> > * i386-opc.tbl: Add <Vxy> for VEX insn with x/y suffix,
> > and <Exy> for EVEX insn with x/y suffix.
>
> Code change looks good (and thanks for splitting it off), but the changelog
> entry wants to use "rename" instead of "add", not the least to also mention
Agreed.
> the identifier which goes away. However, this kind of a change is where
> personally I think the legacy changelog model is quite a bit worse than
> the modern one with a proper textual commit message.
>
I prefer concise and accurate ChangeLog entries. It is easier to tell
what the changes are.
--
H.J.
next prev parent reply other threads:[~2022-10-31 16:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 6:05 [PATCH v4 0/2] Support Intel AVX-NE-CONVERT Haochen Jiang
2022-10-31 6:06 ` [PATCH 1/2] i386: Add <Vxy> and <Exy> Haochen Jiang
2022-10-31 9:04 ` Jan Beulich
2022-10-31 16:30 ` H.J. Lu [this message]
2022-11-01 8:50 ` Kong, Lingling
2022-11-01 14:42 ` H.J. Lu
2022-10-31 6:06 ` [PATCH 2/2] Support Intel AVX-NE-CONVERT Haochen Jiang
2022-10-31 9:14 ` Jan Beulich
2022-11-01 1:24 ` Jiang, Haochen
2022-11-01 6:50 ` Jan Beulich
2022-11-01 8:08 ` Kong, Lingling
2022-11-01 9:04 ` Kong, Lingling
2022-11-02 7:47 ` Jan Beulich
2022-11-02 8:50 ` Kong, Lingling
2022-11-02 9:53 ` Jan Beulich
2022-11-03 2:44 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrL7uKTo-KtAtdrydSQ1Kzv7D6PLWZQ65Tw9f8+=USGAQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=haochen.jiang@intel.com \
--cc=jbeulich@suse.com \
--cc=lingling.kong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).