* [Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
@ 2021-05-21 13:33 Andre Vehreschild
2021-06-04 16:05 ` [Ping, Patch, " Andre Vehreschild
0 siblings, 1 reply; 9+ messages in thread
From: Andre Vehreschild @ 2021-05-21 13:33 UTC (permalink / raw)
To: GCC-Patches-ML, GCC-Fortran-ML; +Cc: Damian Rouson, Brad Richardson
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
Hi,
the attached patch fixes an issue when calling CO_BROADCAST in -fcoarray=single
mode, where the optional but non-present (in the calling scope) stat variable
was assigned to before checking for it being not present.
Regtests fine on x86-64-linux/f33. Ok for trunk?
Regards,
Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
[-- Attachment #2: pr100337.log --]
[-- Type: text/x-log, Size: 234 bytes --]
gcc/fortran/ChangeLog:
PR fortran/100337
* trans-intrinsic.c (conv_co_collective): Check stat for null ptr
before dereferrencing.
gcc/testsuite/ChangeLog:
PR fortran/100337
* gfortran.dg/coarray_collectives_17.f90: New test.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: pr100337.patch --]
[-- Type: text/x-patch, Size: 2587 bytes --]
diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 4d7451479d3..03a38090051 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -11232,8 +11232,28 @@ conv_co_collective (gfc_code *code)
if (flag_coarray == GFC_FCOARRAY_SINGLE)
{
if (stat != NULL_TREE)
- gfc_add_modify (&block, stat,
- fold_convert (TREE_TYPE (stat), integer_zero_node));
+ {
+ /* For optional stats, check the pointer is valid before zero'ing. */
+ if (gfc_expr_attr (stat_expr).optional)
+ {
+ tree tmp;
+ stmtblock_t ass_block;
+ gfc_start_block (&ass_block);
+ gfc_add_modify (&ass_block, stat,
+ fold_convert (TREE_TYPE (stat),
+ integer_zero_node));
+ tmp = fold_build2 (NE_EXPR, logical_type_node,
+ gfc_build_addr_expr (NULL_TREE, stat),
+ null_pointer_node);
+ tmp = fold_build3 (COND_EXPR, void_type_node, tmp,
+ gfc_finish_block (&ass_block),
+ build_empty_stmt (input_location));
+ gfc_add_expr_to_block (&block, tmp);
+ }
+ else
+ gfc_add_modify (&block, stat,
+ fold_convert (TREE_TYPE (stat), integer_zero_node));
+ }
return gfc_finish_block (&block);
}
diff --git a/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90 b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
new file mode 100644
index 00000000000..84a6645865e
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
@@ -0,0 +1,42 @@
+! { dg-do run }
+! { dg-options "-fcoarray=single" }
+!
+! PR 100337
+! Test case inspired by code submitted by Brad Richardson
+
+program main
+ implicit none
+
+ integer, parameter :: MESSAGE = 42
+ integer :: result
+
+ call myco_broadcast(MESSAGE, result, 1)
+
+ if (result /= MESSAGE) error stop 1
+contains
+ subroutine myco_broadcast(m, r, source_image, stat, errmsg)
+ integer, intent(in) :: m
+ integer, intent(out) :: r
+ integer, intent(in) :: source_image
+ integer, intent(out), optional :: stat
+ character(len=*), intent(inout), optional :: errmsg
+
+ integer :: data_length
+
+ data_length = 1
+
+ call co_broadcast(data_length, source_image, stat, errmsg)
+
+ if (present(stat)) then
+ if (stat /= 0) return
+ end if
+
+ if (this_image() == source_image) then
+ r = m
+ end if
+
+ call co_broadcast(r, source_image, stat, errmsg)
+ end subroutine
+
+end program
+
^ permalink raw reply [flat|nested] 9+ messages in thread* [Ping, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-05-21 13:33 [Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST Andre Vehreschild
@ 2021-06-04 16:05 ` Andre Vehreschild
2021-06-19 11:23 ` [Ping^2, " Andre Vehreschild
0 siblings, 1 reply; 9+ messages in thread
From: Andre Vehreschild @ 2021-06-04 16:05 UTC (permalink / raw)
To: GCC-Patches-ML, GCC-Fortran-ML; +Cc: Damian Rouson, Brad Richardson
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
Ping!
On Fri, 21 May 2021 15:33:11 +0200
Andre Vehreschild <vehre@gmx.de> wrote:
> Hi,
>
> the attached patch fixes an issue when calling CO_BROADCAST in
> -fcoarray=single mode, where the optional but non-present (in the calling
> scope) stat variable was assigned to before checking for it being not present.
>
> Regtests fine on x86-64-linux/f33. Ok for trunk?
>
> Regards,
> Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
[-- Attachment #2: pr100337.log --]
[-- Type: text/x-log, Size: 234 bytes --]
gcc/fortran/ChangeLog:
PR fortran/100337
* trans-intrinsic.c (conv_co_collective): Check stat for null ptr
before dereferrencing.
gcc/testsuite/ChangeLog:
PR fortran/100337
* gfortran.dg/coarray_collectives_17.f90: New test.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: pr100337.patch --]
[-- Type: text/x-patch, Size: 2587 bytes --]
diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 4d7451479d3..03a38090051 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -11232,8 +11232,28 @@ conv_co_collective (gfc_code *code)
if (flag_coarray == GFC_FCOARRAY_SINGLE)
{
if (stat != NULL_TREE)
- gfc_add_modify (&block, stat,
- fold_convert (TREE_TYPE (stat), integer_zero_node));
+ {
+ /* For optional stats, check the pointer is valid before zero'ing. */
+ if (gfc_expr_attr (stat_expr).optional)
+ {
+ tree tmp;
+ stmtblock_t ass_block;
+ gfc_start_block (&ass_block);
+ gfc_add_modify (&ass_block, stat,
+ fold_convert (TREE_TYPE (stat),
+ integer_zero_node));
+ tmp = fold_build2 (NE_EXPR, logical_type_node,
+ gfc_build_addr_expr (NULL_TREE, stat),
+ null_pointer_node);
+ tmp = fold_build3 (COND_EXPR, void_type_node, tmp,
+ gfc_finish_block (&ass_block),
+ build_empty_stmt (input_location));
+ gfc_add_expr_to_block (&block, tmp);
+ }
+ else
+ gfc_add_modify (&block, stat,
+ fold_convert (TREE_TYPE (stat), integer_zero_node));
+ }
return gfc_finish_block (&block);
}
diff --git a/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90 b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
new file mode 100644
index 00000000000..84a6645865e
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
@@ -0,0 +1,42 @@
+! { dg-do run }
+! { dg-options "-fcoarray=single" }
+!
+! PR 100337
+! Test case inspired by code submitted by Brad Richardson
+
+program main
+ implicit none
+
+ integer, parameter :: MESSAGE = 42
+ integer :: result
+
+ call myco_broadcast(MESSAGE, result, 1)
+
+ if (result /= MESSAGE) error stop 1
+contains
+ subroutine myco_broadcast(m, r, source_image, stat, errmsg)
+ integer, intent(in) :: m
+ integer, intent(out) :: r
+ integer, intent(in) :: source_image
+ integer, intent(out), optional :: stat
+ character(len=*), intent(inout), optional :: errmsg
+
+ integer :: data_length
+
+ data_length = 1
+
+ call co_broadcast(data_length, source_image, stat, errmsg)
+
+ if (present(stat)) then
+ if (stat /= 0) return
+ end if
+
+ if (this_image() == source_image) then
+ r = m
+ end if
+
+ call co_broadcast(r, source_image, stat, errmsg)
+ end subroutine
+
+end program
+
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-04 16:05 ` [Ping, Patch, " Andre Vehreschild
@ 2021-06-19 11:23 ` Andre Vehreschild
2021-06-21 12:30 ` Tobias Burnus
0 siblings, 1 reply; 9+ messages in thread
From: Andre Vehreschild @ 2021-06-19 11:23 UTC (permalink / raw)
To: GCC-Patches-ML, GCC-Fortran-ML; +Cc: Damian Rouson, Brad Richardson
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
PING!
On Fri, 4 Jun 2021 18:05:18 +0200
Andre Vehreschild <vehre@gmx.de> wrote:
> Ping!
>
> On Fri, 21 May 2021 15:33:11 +0200
> Andre Vehreschild <vehre@gmx.de> wrote:
>
> > Hi,
> >
> > the attached patch fixes an issue when calling CO_BROADCAST in
> > -fcoarray=single mode, where the optional but non-present (in the calling
> > scope) stat variable was assigned to before checking for it being not
> > present.
> >
> > Regtests fine on x86-64-linux/f33. Ok for trunk?
> >
> > Regards,
> > Andre
>
>
--
Andre Vehreschild * Email: vehre ad gmx dot de
[-- Attachment #2: pr100337.log --]
[-- Type: text/x-log, Size: 234 bytes --]
gcc/fortran/ChangeLog:
PR fortran/100337
* trans-intrinsic.c (conv_co_collective): Check stat for null ptr
before dereferrencing.
gcc/testsuite/ChangeLog:
PR fortran/100337
* gfortran.dg/coarray_collectives_17.f90: New test.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: pr100337.patch --]
[-- Type: text/x-patch, Size: 2587 bytes --]
diff --git a/gcc/fortran/trans-intrinsic.c b/gcc/fortran/trans-intrinsic.c
index 4d7451479d3..03a38090051 100644
--- a/gcc/fortran/trans-intrinsic.c
+++ b/gcc/fortran/trans-intrinsic.c
@@ -11232,8 +11232,28 @@ conv_co_collective (gfc_code *code)
if (flag_coarray == GFC_FCOARRAY_SINGLE)
{
if (stat != NULL_TREE)
- gfc_add_modify (&block, stat,
- fold_convert (TREE_TYPE (stat), integer_zero_node));
+ {
+ /* For optional stats, check the pointer is valid before zero'ing. */
+ if (gfc_expr_attr (stat_expr).optional)
+ {
+ tree tmp;
+ stmtblock_t ass_block;
+ gfc_start_block (&ass_block);
+ gfc_add_modify (&ass_block, stat,
+ fold_convert (TREE_TYPE (stat),
+ integer_zero_node));
+ tmp = fold_build2 (NE_EXPR, logical_type_node,
+ gfc_build_addr_expr (NULL_TREE, stat),
+ null_pointer_node);
+ tmp = fold_build3 (COND_EXPR, void_type_node, tmp,
+ gfc_finish_block (&ass_block),
+ build_empty_stmt (input_location));
+ gfc_add_expr_to_block (&block, tmp);
+ }
+ else
+ gfc_add_modify (&block, stat,
+ fold_convert (TREE_TYPE (stat), integer_zero_node));
+ }
return gfc_finish_block (&block);
}
diff --git a/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90 b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
new file mode 100644
index 00000000000..84a6645865e
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/coarray_collectives_17.f90
@@ -0,0 +1,42 @@
+! { dg-do run }
+! { dg-options "-fcoarray=single" }
+!
+! PR 100337
+! Test case inspired by code submitted by Brad Richardson
+
+program main
+ implicit none
+
+ integer, parameter :: MESSAGE = 42
+ integer :: result
+
+ call myco_broadcast(MESSAGE, result, 1)
+
+ if (result /= MESSAGE) error stop 1
+contains
+ subroutine myco_broadcast(m, r, source_image, stat, errmsg)
+ integer, intent(in) :: m
+ integer, intent(out) :: r
+ integer, intent(in) :: source_image
+ integer, intent(out), optional :: stat
+ character(len=*), intent(inout), optional :: errmsg
+
+ integer :: data_length
+
+ data_length = 1
+
+ call co_broadcast(data_length, source_image, stat, errmsg)
+
+ if (present(stat)) then
+ if (stat /= 0) return
+ end if
+
+ if (this_image() == source_image) then
+ r = m
+ end if
+
+ call co_broadcast(r, source_image, stat, errmsg)
+ end subroutine
+
+end program
+
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-19 11:23 ` [Ping^2, " Andre Vehreschild
@ 2021-06-21 12:30 ` Tobias Burnus
2021-06-22 7:40 ` Andre Vehreschild
0 siblings, 1 reply; 9+ messages in thread
From: Tobias Burnus @ 2021-06-21 12:30 UTC (permalink / raw)
To: Andre Vehreschild, GCC-Patches-ML, GCC-Fortran-ML; +Cc: Brad Richardson
Any reason that you did not put it under
gfortran.dg/coarray/
such that it is also run with -fcoarray=lib (-lcaf_single)?
I know that the issue only exists for single, but it also makes
sense to check that libcaf_single works ....
In that sense, I wonder whether also the other CO_* should be
checked in the testsuite as they are handled differently in
libcaf_... (but identical with -fcoarray=single).
Except for those two nits, it LGTM. Thanks!
Tobias
PS: The function is used by
case GFC_ISYM_CO_BROADCAST:
case GFC_ISYM_CO_MIN:
case GFC_ISYM_CO_MAX:
case GFC_ISYM_CO_REDUCE:
case GFC_ISYM_CO_SUM:
and, with -fcoarray=single, errmsg is not touched
as stat is (unconditionally) 0 (success)..
On 19.06.21 13:23, Andre Vehreschild via Fortran wrote:
> PING!
>
> On Fri, 4 Jun 2021 18:05:18 +0200
> Andre Vehreschild <vehre@gmx.de> wrote:
>
>> Ping!
>>
>> On Fri, 21 May 2021 15:33:11 +0200
>> Andre Vehreschild <vehre@gmx.de> wrote:
>>
>>> Hi,
>>>
>>> the attached patch fixes an issue when calling CO_BROADCAST in
>>> -fcoarray=single mode, where the optional but non-present (in the calling
>>> scope) stat variable was assigned to before checking for it being not
>>> present.
>>>
>>> Regtests fine on x86-64-linux/f33. Ok for trunk?
>>>
>>> Regards,
>>> Andre
>>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-21 12:30 ` Tobias Burnus
@ 2021-06-22 7:40 ` Andre Vehreschild
2021-06-22 8:37 ` Tobias Burnus
0 siblings, 1 reply; 9+ messages in thread
From: Andre Vehreschild @ 2021-06-22 7:40 UTC (permalink / raw)
To: Tobias Burnus; +Cc: GCC-Patches-ML, GCC-Fortran-ML, Brad Richardson
Hi Tobias,
thanks for the review.
To the questions:
- I added a test only for -fcoarray=single because in the library case the
optional stat is just propagated to the library, which is already tested a
lot of times and which needs to handle the optional stat in any case. So an
error there would have been detected in one of the earlier tests. I did not
want to add unnecessary test overhead given that the tests already run for a
long time.
- I did not add tests for the other CO_* routines, i.e. CO_MIN, CO_MAX,
CO_REDUCE or CO_SUM, that are also handled by this routine, because I believe
that showing that the fix works for CO_BROADCAST shows that the others work,
too. Because the four others do not have any special handling in their
implementation in trans_intrinsic. Or do you mean other coarray-routines
besides the five handled by conv_co_collective()?
If it is ok for you, I would apply the patch as is, or do you see a reason to
add more tests?
Regards,
Andre
On Mon, 21 Jun 2021 14:30:21 +0200
Tobias Burnus <tobias@codesourcery.com> wrote:
> Any reason that you did not put it under
> gfortran.dg/coarray/
> such that it is also run with -fcoarray=lib (-lcaf_single)?
> I know that the issue only exists for single, but it also makes
> sense to check that libcaf_single works ....
>
> In that sense, I wonder whether also the other CO_* should be
> checked in the testsuite as they are handled differently in
> libcaf_... (but identical with -fcoarray=single).
>
> Except for those two nits, it LGTM. Thanks!
>
> Tobias
>
> PS: The function is used by
> case GFC_ISYM_CO_BROADCAST:
> case GFC_ISYM_CO_MIN:
> case GFC_ISYM_CO_MAX:
> case GFC_ISYM_CO_REDUCE:
> case GFC_ISYM_CO_SUM:
> and, with -fcoarray=single, errmsg is not touched
> as stat is (unconditionally) 0 (success)..
>
>
> On 19.06.21 13:23, Andre Vehreschild via Fortran wrote:
> > PING!
> >
> > On Fri, 4 Jun 2021 18:05:18 +0200
> > Andre Vehreschild <vehre@gmx.de> wrote:
> >
> >> Ping!
> >>
> >> On Fri, 21 May 2021 15:33:11 +0200
> >> Andre Vehreschild <vehre@gmx.de> wrote:
> >>
> >>> Hi,
> >>>
> >>> the attached patch fixes an issue when calling CO_BROADCAST in
> >>> -fcoarray=single mode, where the optional but non-present (in the calling
> >>> scope) stat variable was assigned to before checking for it being not
> >>> present.
> >>>
> >>> Regtests fine on x86-64-linux/f33. Ok for trunk?
> >>>
> >>> Regards,
> >>> Andre
> >>
> >
> > --
> > Andre Vehreschild * Email: vehre ad gmx dot de
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank
> Thürauf
--
Andre Vehreschild * Email: vehre ad gmx dot de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-22 7:40 ` Andre Vehreschild
@ 2021-06-22 8:37 ` Tobias Burnus
2021-06-23 8:23 ` Andre Vehreschild
0 siblings, 1 reply; 9+ messages in thread
From: Tobias Burnus @ 2021-06-22 8:37 UTC (permalink / raw)
To: Andre Vehreschild; +Cc: Brad Richardson, GCC-Patches-ML, GCC-Fortran-ML
Hi Andre,
On 22.06.21 09:40, Andre Vehreschild via Fortran wrote:
> To the questions:
> - I added a test only for -fcoarray=single because in the library case the
> optional stat is just propagated to the library, which is already tested a
> lot of times and which needs to handle the optional stat in any case. So an
> error there would have been detected in one of the earlier tests. I did not
> want to add unnecessary test overhead given that the tests already run for a
> long time.
Fair point.
> - I did not add tests for the other CO_* routines, i.e. CO_MIN, CO_MAX,
> CO_REDUCE or CO_SUM, that are also handled by this routine, because I believe
> that showing that the fix works for CO_BROADCAST shows that the others work,
> too. Because the four others do not have any special handling in their
> implementation in trans_intrinsic. Or do you mean other coarray-routines
> besides the five handled by conv_co_collective()?
Well, that relates more to the first point – for -fcoarray=lib, it
likely makes a difference. For -fcoarray=single not. If the former is
skipped, it is much less relevant for the second.
> If it is ok for you, I would apply the patch as is, or do you see a reason to
> add more tests?
OK.
Although, I am not that sure that libcaf_single gets that much testing.
On the other hand, -fcoarray=lib with -lcaf_single is also not that
relevant in the real world, either.
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-22 8:37 ` Tobias Burnus
@ 2021-06-23 8:23 ` Andre Vehreschild
2021-06-23 9:21 ` Tobias Burnus
0 siblings, 1 reply; 9+ messages in thread
From: Andre Vehreschild @ 2021-06-23 8:23 UTC (permalink / raw)
To: GCC-Patches-ML, GCC-Fortran-ML
Cc: Tobias Burnus, Brad Richardson, Damian Rouson
Hi all,
the fix for PR100337 was submitted as da13e4ebebb07a47d5fb50eab8893f8fe38683df.
Thanks for the review Tobias.
@Tobias: You are right, caf_single does not get much testing. But this part
(not providing a stat) is tested multiple times, because of the laziness. Nearly
none of the tests in the testsuite provides a variable for stat.
Will wait two weeks for any errors introduced by this patch before backporting
to gcc-11, ok?
Regards,
Andre
On Tue, 22 Jun 2021 10:37:27 +0200
Tobias Burnus <tobias@codesourcery.com> wrote:
> Hi Andre,
>
> On 22.06.21 09:40, Andre Vehreschild via Fortran wrote:
> > To the questions:
> > - I added a test only for -fcoarray=single because in the library case the
> > optional stat is just propagated to the library, which is already tested
> > a lot of times and which needs to handle the optional stat in any case. So
> > an error there would have been detected in one of the earlier tests. I did
> > not want to add unnecessary test overhead given that the tests already run
> > for a long time.
> Fair point.
> > - I did not add tests for the other CO_* routines, i.e. CO_MIN, CO_MAX,
> > CO_REDUCE or CO_SUM, that are also handled by this routine, because I
> > believe that showing that the fix works for CO_BROADCAST shows that the
> > others work, too. Because the four others do not have any special handling
> > in their implementation in trans_intrinsic. Or do you mean other
> > coarray-routines besides the five handled by conv_co_collective()?
> Well, that relates more to the first point – for -fcoarray=lib, it
> likely makes a difference. For -fcoarray=single not. If the former is
> skipped, it is much less relevant for the second.
> > If it is ok for you, I would apply the patch as is, or do you see a reason
> > to add more tests?
>
> OK.
>
> Although, I am not that sure that libcaf_single gets that much testing.
> On the other hand, -fcoarray=lib with -lcaf_single is also not that
> relevant in the real world, either.
>
> Tobias
>
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank
> Thürauf
--
Andre Vehreschild * Email: vehre ad gmx dot de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-23 8:23 ` Andre Vehreschild
@ 2021-06-23 9:21 ` Tobias Burnus
2022-02-14 15:50 ` [Backport gcc-11, " Andre Vehreschild
0 siblings, 1 reply; 9+ messages in thread
From: Tobias Burnus @ 2021-06-23 9:21 UTC (permalink / raw)
To: Andre Vehreschild, GCC-Patches-ML, GCC-Fortran-ML
Cc: Brad Richardson, Damian Rouson
On 23.06.21 10:23, Andre Vehreschild wrote:
> Will wait two weeks for any errors introduced by this patch before backporting
> to gcc-11, ok?
Fine with me.
Thanks again for the patch.
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Backport gcc-11, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
2021-06-23 9:21 ` Tobias Burnus
@ 2022-02-14 15:50 ` Andre Vehreschild
0 siblings, 0 replies; 9+ messages in thread
From: Andre Vehreschild @ 2022-02-14 15:50 UTC (permalink / raw)
To: GCC-Patches-ML; +Cc: GCC-Fortran-ML, Damian Rouson
Hi everyone,
sorry for missing out on the gcc-11 backport, but better late than never.
Committed backport as ae57aae60d1.
Regards,
Andre
On Wed, 23 Jun 2021 11:21:45 +0200
Tobias Burnus <tobias@codesourcery.com> wrote:
> On 23.06.21 10:23, Andre Vehreschild wrote:
>
> > Will wait two weeks for any errors introduced by this patch before
> > backporting to gcc-11, ok?
>
> Fine with me.
>
> Thanks again for the patch.
>
> Tobias
>
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank
> Thürauf
--
Andre Vehreschild * Email: vehre ad gmx dot de
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-02-14 15:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 13:33 [Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST Andre Vehreschild
2021-06-04 16:05 ` [Ping, Patch, " Andre Vehreschild
2021-06-19 11:23 ` [Ping^2, " Andre Vehreschild
2021-06-21 12:30 ` Tobias Burnus
2021-06-22 7:40 ` Andre Vehreschild
2021-06-22 8:37 ` Tobias Burnus
2021-06-23 8:23 ` Andre Vehreschild
2021-06-23 9:21 ` Tobias Burnus
2022-02-14 15:50 ` [Backport gcc-11, " Andre Vehreschild
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).