public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hp@axis.com>
To: <oliva@adacore.com>, <gcc-patches@gcc.gnu.org>
Cc: <botcazou@adacore.com>, <rguenther@suse.de>,
	<jeffreyalaw@gmail.com>, <ro@CeBiTec.Uni-Bielefeld.DE>,
	<mikestump@comcast.net>
Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32
Date: Fri, 1 Dec 2023 04:41:05 +0100	[thread overview]
Message-ID: <20231201034105.3DAEA20437@pchp3.se.axis.com> (raw)
In-Reply-To: <20231130170910.5B7C720442@pchp3.se.axis.com> (message from Hans-Peter Nilsson on Thu, 30 Nov 2023 18:09:10 +0100)

> From: Hans-Peter Nilsson <hp@axis.com>
> Date: Thu, 30 Nov 2023 18:09:10 +0100

> I intend to post two alternative patches to get this
> resolved:

> 2: gcc.dg/tree-ssa/scev-[3-5].c skipped for arm*, xfailed
>    only on h8300-*-* and ia32.

(Except as mentioned, the XPASS issue does not apply to
h8300; it's "i16lp32".  It remains in the set of targets
that were tested though.)

Subject: [PATCH 2/2] testsuite: Fix XPASS for gcc.dg/tree-ssa/scev-3.c, -4.c and -5.c [PR112786]

This is the second alternative, slightly more trivial than the first.

Tested cris-elf, arm-eabi (default), x86_64-linux, ditto -m32,
h8300-elf and shle-linux; xpassing, skipped and passing as
applicable and intended.

Ok to commit?
-- >8 --
Results differ between ARM sub-targets, thus better to skip these
tests.  They are known to fail only for ia32-elf.

	PR testsuite/112786
	* gcc.dg/tree-ssa/scev-3.c, gcc.dg/tree-ssa/scev-4.c,
	gcc.dg/tree-ssa/scev-5.c: Revert last change.  Instead, skip dump
	match for arm*.
---
 gcc/testsuite/gcc.dg/tree-ssa/scev-3.c | 3 +--
 gcc/testsuite/gcc.dg/tree-ssa/scev-4.c | 3 +--
 gcc/testsuite/gcc.dg/tree-ssa/scev-5.c | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
index beea9aed9fe9..6e9733504014 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
@@ -40,5 +40,4 @@ __BB(6):
 
 }
 
-/* Not all 32-bit systems fail this, but several do.  */
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { target { ! arm*-*-* } xfail ia32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
index a97f75f81f65..a0cf171f01be 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
@@ -45,5 +45,4 @@ __BB(6):
 
 }
 
-/* Not all 32-bit systems fail this, but several do.  */
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { target { ! arm*-*-* } xfail ia32 } } } */
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
index 08f4260403c4..0bd743cc6be6 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
@@ -40,5 +40,4 @@ __BB(6):
 
 }
 
-/* Not all 32-bit systems fail this, but several do.  */
-/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
+/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { target { ! arm*-*-* } xfail ia32 } } } */
-- 
2.30.2


      parent reply	other threads:[~2023-12-01  3:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19  7:30 Alexandre Oliva
2023-11-19 15:12 ` Jeff Law
2023-11-20  7:35   ` Richard Biener
2023-11-28 15:13     ` Rainer Orth
2023-11-29 18:00       ` Hans-Peter Nilsson
2023-11-30  4:41         ` Alexandre Oliva
2023-11-30  8:32           ` Richard Biener
2023-11-30 17:09           ` Hans-Peter Nilsson
2023-12-01  2:38             ` Hans-Peter Nilsson
2023-12-01  3:35             ` Hans-Peter Nilsson
2023-12-01  7:07               ` Richard Biener
2023-12-01 23:18                 ` Hans-Peter Nilsson
2023-12-04 11:58                   ` Richard Biener
2023-12-07 16:33                     ` Hans-Peter Nilsson
2023-12-07 21:03                       ` Jeff Law
2023-12-08  6:46                       ` Richard Biener
2023-12-01  3:41             ` Hans-Peter Nilsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231201034105.3DAEA20437@pchp3.se.axis.com \
    --to=hp@axis.com \
    --cc=botcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=mikestump@comcast.net \
    --cc=oliva@adacore.com \
    --cc=rguenther@suse.de \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).