Re: [PATCH] testsuite: scev: expect fail on ilp32

[Richard Biener <rguenther@suse.de>]

On Fri, 1 Dec 2023, Hans-Peter Nilsson wrote:

> > From: Hans-Peter Nilsson <hp@axis.com>
> > Date: Thu, 30 Nov 2023 18:09:10 +0100
> 
>     Richard B.:
> > > > In the end we might need to move/duplicate the test to some
> > > > gcc.target/* dir and restrict it to a specific tuning.
> > 
> > I intend to post two alternative patches to get this
> > resolved:
> > 1: Move the tests to gcc.target/i386/scev-[3-5].c
> 
> Subject: [PATCH 1/2] testsuite: Fix XPASS for gcc.dg/tree-ssa/scev-3.c, -4.c and -5.c [PR112786]
> 
> This is the first alternative, perhaps the more appropriate one.
> 
> Tested cris-elf, arm-eabi (default), x86_64-linux, ditto -m32,
> h8300-elf and shle-linux; xpassing, skipped and passing as
> applicable and intended.
> 
> Ok to commit?

Digging in history reveals the testcases were added by
Jiangning Liu <jiangning.liu@arm.com>, not for any
particular bugreport but "The problem is originally from a real benchmark,
and the test case only tries to detect the GIMPLE level changes."

I'm not sure we can infer the testcase should be moved to
gcc.target/arm/ because of that, but it does seem plausible.

I read from your messages that the testcases pass on arm*-*-*?

Richard.

> -- >8 --
> 	PR testsuite/112786
> 	* gcc.dg/tree-ssa/scev-3.c, gcc.dg/tree-ssa/scev-4.c,
> 	gcc.dg/tree-ssa/scev-5.c: Revert last change and move...
> 	* gcc.target/i386/scev-3.c, gcc.target/i386/scev-4.c:
> 	gcc.target/i386/scev-5.c: ...here.
> ---
>  gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-3.c | 3 +--
>  gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-4.c | 3 +--
>  gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-5.c | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)
>  rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-3.c (80%)
>  rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-4.c (81%)
>  rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-5.c (81%)
> 
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.target/i386/scev-3.c
> similarity index 80%
> rename from gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
> rename to gcc/testsuite/gcc.target/i386/scev-3.c
> index beea9aed9fe9..ac8c8d4519e3 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c
> +++ b/gcc/testsuite/gcc.target/i386/scev-3.c
> @@ -40,5 +40,4 @@ __BB(6):
>  
>  }
>  
> -/* Not all 32-bit systems fail this, but several do.  */
> -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
> +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.target/i386/scev-4.c
> similarity index 81%
> rename from gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
> rename to gcc/testsuite/gcc.target/i386/scev-4.c
> index a97f75f81f65..b0d594053019 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c
> +++ b/gcc/testsuite/gcc.target/i386/scev-4.c
> @@ -45,5 +45,4 @@ __BB(6):
>  
>  }
>  
> -/* Not all 32-bit systems fail this, but several do.  */
> -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
> +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
> diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.target/i386/scev-5.c
> similarity index 81%
> rename from gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
> rename to gcc/testsuite/gcc.target/i386/scev-5.c
> index 08f4260403c4..c911a9298866 100644
> --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c
> +++ b/gcc/testsuite/gcc.target/i386/scev-5.c
> @@ -40,5 +40,4 @@ __BB(6):
>  
>  }
>  
> -/* Not all 32-bit systems fail this, but several do.  */
> -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */
> +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH,
Frankenstrasse 146, 90461 Nuernberg, Germany;
GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)