From: Richard Biener <rguenther@suse.de>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Alexandre Oliva <oliva@adacore.com>,
gcc-patches@gcc.gnu.org,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32
Date: Mon, 20 Nov 2023 07:35:13 +0000 (UTC) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2311200733270.8772@jbgna.fhfr.qr> (raw)
In-Reply-To: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com>
On Sun, 19 Nov 2023, Jeff Law wrote:
>
>
> On 11/19/23 00:30, Alexandre Oliva wrote:
> >
> > I've recently patched scev-3.c and scev-5.c because it only passed by
> > accident on ia32. It also fails on some (but not all) arm-eabi
> > variants. It seems hard to characterize the conditions in which the
> > optimization is supposed to pass, but expecting them to fail on ilp32
> > targets, though probably a little excessive and possibly noisy, is not
> > quite as alarming as getting a fail in test reports, so I propose
> > changing the xfail marker from ia32 to ilp32.
> >
> > I'm also proposing to add a similar marker to scev-4.c. Though it
> > doesn't appear to be failing for me, I've got reports that suggest it
> > still does for others, and it certainly did for us as well.
> >
> > Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default
> > cpu on trunk, and with tms570 on gcc-13. Ok to install?
> >
> >
> > for gcc/testsuite/ChangeLog
> >
> > * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets,
> > though some of these do pass.
> > * gcc.dg/tree-ssa/scev-4.c: Likewise.
> > * gcc.dg/tree-ssa/scev-5.c: Likewise.
> OK. Though hopefully someone will figure out what properties actually cause
> the differences so that we can do the right thing without the noisy XPASS at
> some point.
The tests all test IVOPTs induction variable selecting results
(assuming every target would come to the "obvious" conclusion),
so it's probably not only target but also sub-target (aka -mtune)
sensitive ...
In the end we might need to move/duplicate the test to some
gcc.target/* dir and restrict it to a specific tuning.
Richard.
next prev parent reply other threads:[~2023-11-20 7:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 7:30 Alexandre Oliva
2023-11-19 15:12 ` Jeff Law
2023-11-20 7:35 ` Richard Biener [this message]
2023-11-28 15:13 ` Rainer Orth
2023-11-29 18:00 ` Hans-Peter Nilsson
2023-11-30 4:41 ` Alexandre Oliva
2023-11-30 8:32 ` Richard Biener
2023-11-30 17:09 ` Hans-Peter Nilsson
2023-12-01 2:38 ` Hans-Peter Nilsson
2023-12-01 3:35 ` Hans-Peter Nilsson
2023-12-01 7:07 ` Richard Biener
2023-12-01 23:18 ` Hans-Peter Nilsson
2023-12-04 11:58 ` Richard Biener
2023-12-07 16:33 ` Hans-Peter Nilsson
2023-12-07 21:03 ` Jeff Law
2023-12-08 6:46 ` Richard Biener
2023-12-01 3:41 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2311200733270.8772@jbgna.fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=mikestump@comcast.net \
--cc=oliva@adacore.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).