* [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
@ 2023-07-11 10:37 Andre Vieira (lists)
2023-07-11 22:28 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Andre Vieira (lists) @ 2023-07-11 10:37 UTC (permalink / raw)
To: gcc-patches; +Cc: jakub, Andrew Pinski
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hi,
This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
list, as insn-opinit.h is now required by internal-fn.h. This will lead
to insn-opinit.h, among the other OPTABS_H header files, being installed
in the plugin directory.
Bootstrapped aarch64-unknown-linux-gnu.
@Jakub: could you check to see if it also addresses PR 110284?
gcc/ChangeLog:
PR 110610
* Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
[-- Attachment #2: pr110610.patch --]
[-- Type: text/plain, Size: 656 bytes --]
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index c478ec852013eae65b9f3ec0a443e023c7d8b452..d3ff210ee04414f4e238c087400dd21e1cb0fc18 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h
BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \
gtm-builtins.def sanitizer.def
INTERNAL_FN_DEF = internal-fn.def
-INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF)
+INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) $(OPTABS_H)
TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \
c-family/c-common.def $(lang_tree_files) \
$(BUILTINS_DEF) $(INPUT_H) statistics.h \
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
2023-07-11 10:37 [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610] Andre Vieira (lists)
@ 2023-07-11 22:28 ` Jeff Law
2023-07-17 11:55 ` Andre Vieira (lists)
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Law @ 2023-07-11 22:28 UTC (permalink / raw)
To: Andre Vieira (lists), gcc-patches; +Cc: jakub, Andrew Pinski
On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
> Hi,
>
> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
> list, as insn-opinit.h is now required by internal-fn.h. This will lead
> to insn-opinit.h, among the other OPTABS_H header files, being installed
> in the plugin directory.
>
> Bootstrapped aarch64-unknown-linux-gnu.
>
> @Jakub: could you check to see if it also addresses PR 110284?
>
>
> gcc/ChangeLog:
>
> PR 110610
> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h
and insn-codes.h and neither of those #include other headers do they?
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
2023-07-11 22:28 ` Jeff Law
@ 2023-07-17 11:55 ` Andre Vieira (lists)
2023-07-17 14:27 ` Jeff Law
0 siblings, 1 reply; 4+ messages in thread
From: Andre Vieira (lists) @ 2023-07-17 11:55 UTC (permalink / raw)
To: Jeff Law, gcc-patches; +Cc: jakub, Andrew Pinski
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On 11/07/2023 23:28, Jeff Law wrote:
>
>
> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
>> Hi,
>>
>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
>> list, as insn-opinit.h is now required by internal-fn.h. This will
>> lead to insn-opinit.h, among the other OPTABS_H header files, being
>> installed in the plugin directory.
>>
>> Bootstrapped aarch64-unknown-linux-gnu.
>>
>> @Jakub: could you check to see if it also addresses PR 110284?
>>
>>
>> gcc/ChangeLog:
>>
>> PR 110610
>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h
> and insn-codes.h and neither of those #include other headers do they?
>
>
Yeah, there was no particular reason other than I just felt the Makefile
structure sort of lend itself that way. I checked genopinit.cc and it
seems insn-opinit.h doesn't include any other header files, only the
sources do, so I've changed the patch to only add insn-opinit.h to
INTERNAL_FN_H.
-------------------
This patch fixes PR110610 by including insn-opinit.h in the
INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h.
This will lead to insn-opinit.h, among the other OPTABS_H header files,
being installed in the plugin directory.
Bootstrapped aarch64-unknown-linux-gnu.
gcc/ChangeLog:
PR 110610
* Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.
[-- Attachment #2: pr110610_2.patch --]
[-- Type: text/plain, Size: 658 bytes --]
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index c478ec852013eae65b9f3ec0a443e023c7d8b452..683774ad446d545362644d2dbdc37723eea55bc3 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -976,7 +976,7 @@ READ_MD_H = $(OBSTACK_H) $(HASHTAB_H) read-md.h
BUILTINS_DEF = builtins.def sync-builtins.def omp-builtins.def \
gtm-builtins.def sanitizer.def
INTERNAL_FN_DEF = internal-fn.def
-INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF)
+INTERNAL_FN_H = internal-fn.h $(INTERNAL_FN_DEF) insn-opinit.h
TREE_CORE_H = tree-core.h $(CORETYPES_H) all-tree.def tree.def \
c-family/c-common.def $(lang_tree_files) \
$(BUILTINS_DEF) $(INPUT_H) statistics.h \
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610]
2023-07-17 11:55 ` Andre Vieira (lists)
@ 2023-07-17 14:27 ` Jeff Law
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Law @ 2023-07-17 14:27 UTC (permalink / raw)
To: Andre Vieira (lists), gcc-patches; +Cc: jakub, Andrew Pinski
On 7/17/23 05:55, Andre Vieira (lists) wrote:
>
>
> On 11/07/2023 23:28, Jeff Law wrote:
>>
>>
>> On 7/11/23 04:37, Andre Vieira (lists) via Gcc-patches wrote:
>>> Hi,
>>>
>>> This patch fixes PR110610 by including OPTABS_H in the INTERNAL_FN_H
>>> list, as insn-opinit.h is now required by internal-fn.h. This will
>>> lead to insn-opinit.h, among the other OPTABS_H header files, being
>>> installed in the plugin directory.
>>>
>>> Bootstrapped aarch64-unknown-linux-gnu.
>>>
>>> @Jakub: could you check to see if it also addresses PR 110284?
>>>
>>>
>>> gcc/ChangeLog:
>>>
>>> PR 110610
>>> * Makefile.in (INTERNAL_FN_H): Add OPTABS_H.
>> Why use OPTABS_H here? Isn't the new dependency just on insn-opinit.h
>> and insn-codes.h and neither of those #include other headers do they?
>>
>>
>
> Yeah, there was no particular reason other than I just felt the Makefile
> structure sort of lend itself that way. I checked genopinit.cc and it
> seems insn-opinit.h doesn't include any other header files, only the
> sources do, so I've changed the patch to only add insn-opinit.h to
> INTERNAL_FN_H.
>
> -------------------
>
> This patch fixes PR110610 by including insn-opinit.h in the
> INTERNAL_FN_H list, as insn-opinit.h is now required by internal-fn.h.
> This will lead to insn-opinit.h, among the other OPTABS_H header files,
> being installed in the plugin directory.
>
> Bootstrapped aarch64-unknown-linux-gnu.
>
> gcc/ChangeLog:
> PR 110610
> * Makefile.in (INTERNAL_FN_H): Add insn-opinit.h.
OK
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-17 14:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 10:37 [PATCH] Include insn-opinit.h in PLUGIN_H [PR110610] Andre Vieira (lists)
2023-07-11 22:28 ` Jeff Law
2023-07-17 11:55 ` Andre Vieira (lists)
2023-07-17 14:27 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).