From: Kito Cheng <kito.cheng@gmail.com>
To: Jiawei <jiawei@iscas.ac.cn>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com,
palmer@dabbelt.com, christoph.muellner@vrull.eu,
jeremy.bennett@embecosm.com, mary.bennett@embecosm.com,
nandni.jamnadas@embecosm.com, charlie.keaney@embecosm.com,
simon.cook@embecosm.com, tariq.kurd@codasip.com,
ibrahim.abu.kharmeh1@huawei.com, sinan.lin@linux.alibaba.com,
wuwei2016@iscas.ac.cn, shihua@iscas.ac.cn,
shiyulong@iscas.ac.cn, chenyixuan@iscas.ac.cn
Subject: Re: [PATCH 1/5] RISC-V: Minimal support for ZC extensions.
Date: Thu, 4 May 2023 16:33:41 +0800 [thread overview]
Message-ID: <CA+yXCZANB1OxVswpn9aFj+7AAARUaNuyFnwQXN8j0AUDKmo0=A@mail.gmail.com> (raw)
In-Reply-To: <20230406062118.47431-2-jiawei@iscas.ac.cn>
> @@ -1151,14 +1169,26 @@ riscv_subset_list::parse (const char *arch, location_t loc)
> subset_list->handle_implied_ext (itr);
> }
>
> + /* Zce only imply zcf when 'f' extension exist. */
Grammarly and gmail told me it should be "Zce only implies zcf when
'f' extension exist." :P
> + if (subset_list->lookup ("zce") != NULL
> + && subset_list->lookup ("f") != NULL
> + && subset_list->lookup ("zcf") == NULL)
Wait, add zce if f not implied here, but how about rv64if_zce?
it will become rv64if_zce_zcf and then error later.
> + subset_list->add ("zcf", false);
> +
> subset_list->handle_combine_ext ();
>
> + if (subset_list->lookup ("zcf") && subset_list->m_xlen == 64)
> + error_at (loc, "%<-march=%s%>: zcf extension supports in rv32 only"
> + , arch);
> +
> if (subset_list->lookup ("zfinx") && subset_list->lookup ("f"))
> error_at (loc, "%<-march=%s%>: z*inx conflicts with floating-point "
> "extensions", arch);
>
> return subset_list;
>
> +
> +
Plz drop these two extra blank lines.
next prev parent reply other threads:[~2023-05-04 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 6:21 [PATCH 0/5] RISC-V: Support ZC* extensions Jiawei
2023-04-06 6:21 ` [PATCH 1/5] RISC-V: Minimal support for ZC extensions Jiawei
2023-05-04 8:33 ` Kito Cheng [this message]
2023-04-06 6:21 ` [PATCH 2/5] RISC-V: Enable compressible features when use ZC* extensions Jiawei
2023-04-06 6:21 ` [PATCH 3/5] RISC-V: Add ZC* test for march args being passed Jiawei
2023-05-04 8:37 ` Kito Cheng
2023-04-06 6:21 ` [PATCH 4/5] RISC-V: Add Zcmp extension supports Jiawei
2023-05-04 9:03 ` Kito Cheng
[not found] ` <07720619-dd69-4816-987e-ff0e14d9a348.>
2023-05-12 8:53 ` Sinan
2023-04-06 6:21 ` [PATCH 5/5] RISC-V: Add ZCMP push/pop testcases Jiawei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+yXCZANB1OxVswpn9aFj+7AAARUaNuyFnwQXN8j0AUDKmo0=A@mail.gmail.com' \
--to=kito.cheng@gmail.com \
--cc=charlie.keaney@embecosm.com \
--cc=chenyixuan@iscas.ac.cn \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=ibrahim.abu.kharmeh1@huawei.com \
--cc=jeremy.bennett@embecosm.com \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@sifive.com \
--cc=mary.bennett@embecosm.com \
--cc=nandni.jamnadas@embecosm.com \
--cc=palmer@dabbelt.com \
--cc=shihua@iscas.ac.cn \
--cc=shiyulong@iscas.ac.cn \
--cc=simon.cook@embecosm.com \
--cc=sinan.lin@linux.alibaba.com \
--cc=tariq.kurd@codasip.com \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).