* [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V
@ 2022-05-04 0:27 Palmer Dabbelt
2022-05-11 1:31 ` Kito Cheng
0 siblings, 1 reply; 4+ messages in thread
From: Palmer Dabbelt @ 2022-05-04 0:27 UTC (permalink / raw)
To: gcc-patches
Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with
-m32"), RISC-V needs to be told not to put symbols in the
sdata/srodata/sbss sections.
gcc/testsuite/ChangeLog
* debug/btf/btf-datasec-1.c: Don't use small data on RISC-V.
---
gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
index dbb236bbda1..77df88648c5 100644
--- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
+++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
@@ -12,6 +12,7 @@
/* { dg-do compile ) */
/* { dg-options "-O0 -gbtf -dA" } */
/* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */
+/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */
/* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */
/* Check for two DATASEC entries with vlen 3, and one with vlen 1. */
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V
2022-05-04 0:27 [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V Palmer Dabbelt
@ 2022-05-11 1:31 ` Kito Cheng
2022-05-13 16:53 ` Palmer Dabbelt
2022-09-10 4:10 ` Mike Stump
0 siblings, 2 replies; 4+ messages in thread
From: Kito Cheng @ 2022-05-11 1:31 UTC (permalink / raw)
To: Palmer Dabbelt; +Cc: GCC Patches
LGTM, that's only added a new option for RISC-V and won't affect all
other targets, so I assume I can approve that.
On Wed, May 4, 2022 at 8:27 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with
> -m32"), RISC-V needs to be told not to put symbols in the
> sdata/srodata/sbss sections.
>
> gcc/testsuite/ChangeLog
>
> * debug/btf/btf-datasec-1.c: Don't use small data on RISC-V.
> ---
> gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
> index dbb236bbda1..77df88648c5 100644
> --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
> +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
> @@ -12,6 +12,7 @@
> /* { dg-do compile ) */
> /* { dg-options "-O0 -gbtf -dA" } */
> /* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */
> +/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */
> /* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */
>
> /* Check for two DATASEC entries with vlen 3, and one with vlen 1. */
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V
2022-05-11 1:31 ` Kito Cheng
@ 2022-05-13 16:53 ` Palmer Dabbelt
2022-09-10 4:10 ` Mike Stump
1 sibling, 0 replies; 4+ messages in thread
From: Palmer Dabbelt @ 2022-05-13 16:53 UTC (permalink / raw)
To: Kito Cheng; +Cc: gcc-patches
On Tue, 10 May 2022 18:31:37 PDT (-0700), Kito Cheng wrote:
> LGTM, that's only added a new option for RISC-V and won't affect all
> other targets, so I assume I can approve that.
I always forget what the rules are, but someone recently reminded me and
yes that's the case. I committed this.
Thanks!
>
> On Wed, May 4, 2022 at 8:27 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> Similar to 37e65643d3e ("testsuite/101269: fix testcase when used with
>> -m32"), RISC-V needs to be told not to put symbols in the
>> sdata/srodata/sbss sections.
>>
>> gcc/testsuite/ChangeLog
>>
>> * debug/btf/btf-datasec-1.c: Don't use small data on RISC-V.
>> ---
>> gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> index dbb236bbda1..77df88648c5 100644
>> --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-1.c
>> @@ -12,6 +12,7 @@
>> /* { dg-do compile ) */
>> /* { dg-options "-O0 -gbtf -dA" } */
>> /* { dg-options "-O0 -gbtf -dA -msdata=none" { target { { powerpc*-*-* } && ilp32 } } } */
>> +/* { dg-options "-O0 -gbtf -dA -msmall-data-limit=0" { target { riscv*-*-* } } } */
>> /* { dg-options "-O0 -gbtf -dA -G0" { target { nios2-*-* } } } */
>>
>> /* Check for two DATASEC entries with vlen 3, and one with vlen 1. */
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V
2022-05-11 1:31 ` Kito Cheng
2022-05-13 16:53 ` Palmer Dabbelt
@ 2022-09-10 4:10 ` Mike Stump
1 sibling, 0 replies; 4+ messages in thread
From: Mike Stump @ 2022-09-10 4:10 UTC (permalink / raw)
To: Kito Cheng; +Cc: Palmer Dabbelt, GCC Patches
On May 10, 2022, at 6:31 PM, Kito Cheng via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> LGTM, that's only added a new option for RISC-V and won't affect all
> other targets, so I assume I can approve that.
Yes. Usual and customary for ports.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-10 4:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 0:27 [PATCH] testsuite: btf: Fix btf-datasec-1.c for RISC-V Palmer Dabbelt
2022-05-11 1:31 ` Kito Cheng
2022-05-13 16:53 ` Palmer Dabbelt
2022-09-10 4:10 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).