* [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics
@ 2022-08-22 17:02 H.J. Lu
2022-08-23 2:05 ` Hongtao Liu
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2022-08-22 17:02 UTC (permalink / raw)
To: gcc-patches
On 64-bit Windows, long is 32 bits and can't be used as stride in memory
operand when base is a pointer which is 64 bits. Cast stride to
__PTRDIFF_TYPE__, instead of long.
PR target/106714
* config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to
__PTRDIFF_TYPE__.
(_tile_stream_loadd_internal): Likewise.
(_tile_stored_internal): Likewise.
---
gcc/config/i386/amxtileintrin.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h
index 7b5a39eba72..06f18aa9bfb 100644
--- a/gcc/config/i386/amxtileintrin.h
+++ b/gcc/config/i386/amxtileintrin.h
@@ -62,7 +62,7 @@ _tile_release (void)
#define _tile_loadd_internal(dst,base,stride) \
__asm__ volatile \
("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \
- :: "r" ((const void*) (base)), "r" ((long) (stride)))
+ :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
#define _tile_stream_loadd(dst,base,stride) \
_tile_stream_loadd_internal (dst, base, stride)
@@ -70,7 +70,7 @@ _tile_release (void)
#define _tile_stream_loadd_internal(dst,base,stride) \
__asm__ volatile \
("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \
- :: "r" ((const void*) (base)), "r" ((long) (stride)))
+ :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
#define _tile_stored(dst,base,stride) \
_tile_stored_internal (dst, base, stride)
@@ -78,7 +78,7 @@ _tile_release (void)
#define _tile_stored_internal(src,base,stride) \
__asm__ volatile \
("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \
- :: "r" ((void*) (base)), "r" ((long) (stride)) \
+ :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \
: "memory")
#define _tile_zero(dst) \
--
2.37.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics
2022-08-22 17:02 [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics H.J. Lu
@ 2022-08-23 2:05 ` Hongtao Liu
2022-08-26 16:51 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Hongtao Liu @ 2022-08-23 2:05 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches, Uros Bizjak
On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On 64-bit Windows, long is 32 bits and can't be used as stride in memory
> operand when base is a pointer which is 64 bits. Cast stride to
> __PTRDIFF_TYPE__, instead of long.
Ok.
>
> PR target/106714
> * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to
> __PTRDIFF_TYPE__.
> (_tile_stream_loadd_internal): Likewise.
> (_tile_stored_internal): Likewise.
> ---
> gcc/config/i386/amxtileintrin.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h
> index 7b5a39eba72..06f18aa9bfb 100644
> --- a/gcc/config/i386/amxtileintrin.h
> +++ b/gcc/config/i386/amxtileintrin.h
> @@ -62,7 +62,7 @@ _tile_release (void)
> #define _tile_loadd_internal(dst,base,stride) \
> __asm__ volatile \
> ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \
> - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
>
> #define _tile_stream_loadd(dst,base,stride) \
> _tile_stream_loadd_internal (dst, base, stride)
> @@ -70,7 +70,7 @@ _tile_release (void)
> #define _tile_stream_loadd_internal(dst,base,stride) \
> __asm__ volatile \
> ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \
> - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
>
> #define _tile_stored(dst,base,stride) \
> _tile_stored_internal (dst, base, stride)
> @@ -78,7 +78,7 @@ _tile_release (void)
> #define _tile_stored_internal(src,base,stride) \
> __asm__ volatile \
> ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \
> - :: "r" ((void*) (base)), "r" ((long) (stride)) \
> + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \
> : "memory")
>
> #define _tile_zero(dst) \
> --
> 2.37.2
>
--
BR,
Hongtao
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics
2022-08-23 2:05 ` Hongtao Liu
@ 2022-08-26 16:51 ` H.J. Lu
2022-08-29 0:24 ` Hongtao Liu
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2022-08-26 16:51 UTC (permalink / raw)
To: Hongtao Liu; +Cc: GCC Patches, Uros Bizjak
On Mon, Aug 22, 2022 at 7:05 PM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On 64-bit Windows, long is 32 bits and can't be used as stride in memory
> > operand when base is a pointer which is 64 bits. Cast stride to
> > __PTRDIFF_TYPE__, instead of long.
> Ok.
> >
> > PR target/106714
> > * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to
> > __PTRDIFF_TYPE__.
> > (_tile_stream_loadd_internal): Likewise.
> > (_tile_stored_internal): Likewise.
> > ---
> > gcc/config/i386/amxtileintrin.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h
> > index 7b5a39eba72..06f18aa9bfb 100644
> > --- a/gcc/config/i386/amxtileintrin.h
> > +++ b/gcc/config/i386/amxtileintrin.h
> > @@ -62,7 +62,7 @@ _tile_release (void)
> > #define _tile_loadd_internal(dst,base,stride) \
> > __asm__ volatile \
> > ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \
> > - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
> >
> > #define _tile_stream_loadd(dst,base,stride) \
> > _tile_stream_loadd_internal (dst, base, stride)
> > @@ -70,7 +70,7 @@ _tile_release (void)
> > #define _tile_stream_loadd_internal(dst,base,stride) \
> > __asm__ volatile \
> > ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \
> > - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
> >
> > #define _tile_stored(dst,base,stride) \
> > _tile_stored_internal (dst, base, stride)
> > @@ -78,7 +78,7 @@ _tile_release (void)
> > #define _tile_stored_internal(src,base,stride) \
> > __asm__ volatile \
> > ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \
> > - :: "r" ((void*) (base)), "r" ((long) (stride)) \
> > + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \
> > : "memory")
> >
> > #define _tile_zero(dst) \
> > --
> > 2.37.2
> >
>
>
> --
> BR,
> Hongtao
OK to backport it to GCC 12 branch?
--
H.J.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics
2022-08-26 16:51 ` H.J. Lu
@ 2022-08-29 0:24 ` Hongtao Liu
0 siblings, 0 replies; 4+ messages in thread
From: Hongtao Liu @ 2022-08-29 0:24 UTC (permalink / raw)
To: H.J. Lu; +Cc: GCC Patches, Uros Bizjak
On Sat, Aug 27, 2022 at 12:51 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Aug 22, 2022 at 7:05 PM Hongtao Liu <crazylht@gmail.com> wrote:
> >
> > On Tue, Aug 23, 2022 at 1:02 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On 64-bit Windows, long is 32 bits and can't be used as stride in memory
> > > operand when base is a pointer which is 64 bits. Cast stride to
> > > __PTRDIFF_TYPE__, instead of long.
> > Ok.
> > >
> > > PR target/106714
> > > * config/i386/amxtileintrin.h (_tile_loadd_internal): Cast to
> > > __PTRDIFF_TYPE__.
> > > (_tile_stream_loadd_internal): Likewise.
> > > (_tile_stored_internal): Likewise.
> > > ---
> > > gcc/config/i386/amxtileintrin.h | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/gcc/config/i386/amxtileintrin.h b/gcc/config/i386/amxtileintrin.h
> > > index 7b5a39eba72..06f18aa9bfb 100644
> > > --- a/gcc/config/i386/amxtileintrin.h
> > > +++ b/gcc/config/i386/amxtileintrin.h
> > > @@ -62,7 +62,7 @@ _tile_release (void)
> > > #define _tile_loadd_internal(dst,base,stride) \
> > > __asm__ volatile \
> > > ("{tileloadd\t(%0,%1,1), %%tmm"#dst"|tileloadd\t%%tmm"#dst", [%0+%1*1]}" \
> > > - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
> > >
> > > #define _tile_stream_loadd(dst,base,stride) \
> > > _tile_stream_loadd_internal (dst, base, stride)
> > > @@ -70,7 +70,7 @@ _tile_release (void)
> > > #define _tile_stream_loadd_internal(dst,base,stride) \
> > > __asm__ volatile \
> > > ("{tileloaddt1\t(%0,%1,1), %%tmm"#dst"|tileloaddt1\t%%tmm"#dst", [%0+%1*1]}" \
> > > - :: "r" ((const void*) (base)), "r" ((long) (stride)))
> > > + :: "r" ((const void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)))
> > >
> > > #define _tile_stored(dst,base,stride) \
> > > _tile_stored_internal (dst, base, stride)
> > > @@ -78,7 +78,7 @@ _tile_release (void)
> > > #define _tile_stored_internal(src,base,stride) \
> > > __asm__ volatile \
> > > ("{tilestored\t%%tmm"#src", (%0,%1,1)|tilestored\t[%0+%1*1], %%tmm"#src"}" \
> > > - :: "r" ((void*) (base)), "r" ((long) (stride)) \
> > > + :: "r" ((void*) (base)), "r" ((__PTRDIFF_TYPE__) (stride)) \
> > > : "memory")
> > >
> > > #define _tile_zero(dst) \
> > > --
> > > 2.37.2
> > >
> >
> >
> > --
> > BR,
> > Hongtao
>
> OK to backport it to GCC 12 branch?
Ok.
>
>
> --
> H.J.
--
BR,
Hongtao
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-29 0:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-22 17:02 [PATCH] x86: Cast stride to __PTRDIFF_TYPE__ in AMX intrinsics H.J. Lu
2022-08-23 2:05 ` Hongtao Liu
2022-08-26 16:51 ` H.J. Lu
2022-08-29 0:24 ` Hongtao Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).