From: Iain Sandoe <iain@sandoe.co.uk>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Peter Bergner <bergner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH] rs6000: Rework option -mpowerpc64 handling [PR106680]
Date: Wed, 28 Sep 2022 07:37:23 +0100 [thread overview]
Message-ID: <FCF2C93B-71A7-4AB1-800F-E9D127593DCA@sandoe.co.uk> (raw)
In-Reply-To: <9d9f1f43-b528-387d-45a7-1d89400de0fc@linux.ibm.com>
Hi Kewen,
> On 28 Sep 2022, at 06:30, Kewen.Lin via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> PR106680 shows that -m32 -mpowerpc64 is different from
> -mpowerpc64 -m32, this is determined by the way how we
> handle option powerpc64 in rs6000_handle_option.
>
> Segher pointed out this difference should be taken as
> a bug and we should ensure that option powerpc64 is
> independent of -m32/-m64. So this patch removes the
> handlings in rs6000_handle_option and add some necessary
> supports in rs6000_option_override_internal instead.
>
> With this patch, if users specify -m{no-,}powerpc64, the
> specified value is honoured, otherwise, for 64bit it
> always enables OPTION_MASK_POWERPC64 while for 32bit
> it disables OPTION_MASK_POWERPC64 if OS_MISSING_POWERPC64.
>
> Bootstrapped and regress-tested on:
> - powerpc64-linux-gnu P7 and P8 {-m64,-m32}
> - powerpc64le-linux-gnu P9 and P10
> - powerpc-ibm-aix7.2.0.0 {-maix64,-maix32}
>
> Hi Iain, could you help to test this on darwin to ensure
> it won't break darwin's build and new tests are fine?
> Thanks in advance!
Will do, it will take a day or so, thanks,
Iain
next prev parent reply other threads:[~2022-09-28 6:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 5:30 Kewen.Lin
2022-09-28 6:37 ` Iain Sandoe [this message]
2022-09-28 16:18 ` Iain Sandoe
2022-09-28 19:09 ` Iain Sandoe
2022-09-29 5:45 ` Kewen.Lin
2022-09-29 8:16 ` Iain Sandoe
2022-09-29 9:12 ` Kewen.Lin
2022-09-29 16:14 ` Iain Sandoe
2022-09-29 17:04 ` Segher Boessenkool
2022-09-29 18:25 ` Iain Sandoe
2022-09-29 18:37 ` Segher Boessenkool
2022-09-30 9:26 ` Kewen.Lin
2022-09-29 17:11 ` Segher Boessenkool
2022-09-30 12:15 ` Kewen.Lin
2022-10-03 21:15 ` Segher Boessenkool
2022-10-10 2:15 ` Kewen.Lin
2022-10-10 13:58 ` Segher Boessenkool
2022-10-12 8:26 ` Kewen.Lin
2022-09-28 21:30 ` Segher Boessenkool
2022-09-28 23:04 ` Iain Sandoe
2022-09-28 23:16 ` Iain Sandoe
2022-09-29 17:26 ` Segher Boessenkool
2022-09-29 17:18 ` Segher Boessenkool
2022-09-29 18:33 ` Iain Sandoe
2022-09-29 18:50 ` Segher Boessenkool
2022-09-28 22:04 ` Segher Boessenkool
2022-09-29 6:16 ` Kewen.Lin
2022-09-29 18:56 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FCF2C93B-71A7-4AB1-800F-E9D127593DCA@sandoe.co.uk \
--to=iain@sandoe.co.uk \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).