Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[nathan]

Synopsis: g++ rejects legal code (regression from gcc 3.*)

Responsible-Changed-From-To: unassigned->austern
Responsible-Changed-By: nathan
Responsible-Changed-When: Fri Sep 13 09:37:29 2002
Responsible-Changed-Why:
    working
State-Changed-From-To: open->analyzed
State-Changed-By: nathan
State-Changed-When: Fri Sep 13 09:37:29 2002
State-Changed-Why:
    confirmed. Matt is working on a fix

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7858

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[ljrittle]

Synopsis: g++ rejects legal code (regression from gcc 3.*)

State-Changed-From-To: analyzed->closed
State-Changed-By: ljrittle
State-Changed-When: Wed Oct  9 15:34:33 2002
State-Changed-Why:
    Fixed on mainline according to PR submitter.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7858

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Pop Sébastian]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: =?iso-8859-1?Q?Pop_S=E9bastian?= <pop@gauvain.u-strasbg.fr>
To: nathan@gcc.gnu.org, austern@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
	gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org,
	schmid@snake.iap.physik.tu-darmstadt.de, gcc-gnats@gcc.gnu.org
Cc:  
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Wed, 9 Oct 2002 01:37:13 +0200

 On Fri, Sep 13, 2002 at 04:37:29PM -0000, nathan@gcc.gnu.org wrote:
 > State-Changed-Why:
 >     confirmed. Matt is working on a fix
 > 
 > http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7858
 
 As for PR#7828, 
 
 I cannot reproduce the error with
 gcc version 3.2.1 20020924 (Debian prerelease)
 
 nor with the last cvs:
 version gcc 3.3 20021007 (experimental)
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Andrew Pinski]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Andrew Pinski <pinskia@physics.uc.edu>
To: Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de>
Cc: Paolo Carlini <pcarlini@unitus.it>, <gcc-gnats@gcc.gnu.org>,
   <gcc-prs@gcc.gnu.org>, <gcc-bugs@gcc.gnu.org>, <nobody@gcc.gnu.org>
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Mon, 9 Sep 2002 16:23:53 -0400

 Here is more information on why this is invalid code:
 According to the ARM (2nd edition) r.5.4,
 "The result of a cast to a reference type is an lvalue; the results of 
 the other casts are not."
 
 
 Thanks,
 Andrew Pinski
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Peter Schmid]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de>
To: Paolo Carlini <pcarlini@unitus.it>
Cc: <gcc-gnats@gcc.gnu.org>, <gcc-prs@gcc.gnu.org>, <gcc-bugs@gcc.gnu.org>,
        <nobody@gcc.gnu.org>
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Mon, 9 Sep 2002 21:47:19 +0200 (CEST)

 On Mon, 9 Sep 2002, Paolo Carlini wrote:
 
 > Hi,
 >
 > I believe that the PR can be considered a duplicate of c++/7828. Do you
 > agree?
 >
 > Thanks, Paolo.
 >
 > http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7858
 >
 >
 
 The problem reported is nearly identical to PR c++/7868. The difference is
 that  PR c++/7848 is also a libstdc++-v3 related bugreport. If Andrew
 Pinski's  analysis is true the casts included in the binder code in the
 libstdc++ header file bits/stl_function.h have to be removed.
 
 Hope this helps,
 
 Peter Schmid
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Paolo Carlini]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Paolo Carlini <pcarlini@unitus.it>
To: gcc-gnats@gcc.gnu.org,  gcc-prs@gcc.gnu.org,  gcc-bugs@gcc.gnu.org, 
 nobody@gcc.gnu.org,  schmid@snake.iap.physik.tu-darmstadt.de
Cc:  
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Mon, 09 Sep 2002 21:25:59 +0200

 Hi,
 
 I believe that the PR can be considered a duplicate of c++/7828. Do you 
 agree?
 
 Thanks, Paolo.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=7858 
 
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Andrew Pinski]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Andrew Pinski <pinskia@physics.uc.edu>
To: Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de>
Cc: <gcc-gnats@gcc.gnu.org>, <bkoz@redhat.com>
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Sun, 8 Sep 2002 19:24:18 -0400

 Actually my argument is against using STLport because gcc now includes 
 a full c++ standard library there is no use for STLPort under gcc 3.3.
 And it looks like you can get rid of the static cast and it should work.
 
 I showed how to work around the "bug" in boost from the testcase.
 
 Thanks,
 Andrew Pinski
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Peter Schmid]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: <gcc-gnats@gcc.gnu.org>, <bkoz@redhat.com>
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Mon, 9 Sep 2002 00:58:03 +0200 (CEST)

 Dear Andrew Pinski,
 
 If you argument is true then the code in the header file
 bits/stl_function.h has to be corrected since the binder1st facility
 included in this PR is copied from this file.
 
 I do not understand the error message "error: non-lvalue in unary
 `&'". Could you please explain why the compiler emits this message?
 
 Furthermore, since about a week or so STLport does not
 compile. The file ../lib/obj/GCC-LINUX/ReleaseD/dll_main.cpp is
 rejected by the compiler with a "./stlport/stl/_string.h:773: error:
 non-lvalue in unary `&'" message. There are similar problems with
 boost. I extracted the testcase included in this PR from
 boost/libs/utility/indirect_iterator_example.cpp.
 
 Thanks,
 
 Peter Schmid
 
 
 
 

Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Andrew Pinski]

The following reply was made to PR c++/7858; it has been noted by GNATS.

From: Andrew Pinski <pinskia@physics.uc.edu>
To: Peter Schmid <schmid@snake.iap.physik.tu-darmstadt.de>
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: c++/7858: g++ rejects legal code (regression from gcc 3.*)
Date: Sun, 8 Sep 2002 15:05:00 -0400

 I do not think this is valid code.
 To make it valid try:
 
 template <class _Operation>
 inline binder1st<_Operation>
 bind1st(const _Operation& __fn, const typename 
 _Operation::first_argument_type& __x)
 {
    return binder1st<_Operation>(__fn, __x);
 }
 
 The problem was that g++ before a week ago accepted invalid code in 
 which
 you could take a pointer to a casted variable which is invalid.
 
 Thanks,
 Andrew Pinski
 

c++/7858: g++ rejects legal code (regression from gcc 3.*)

[Peter Schmid]

>Number:         7858
>Category:       c++
>Synopsis:       g++ rejects legal code (regression from gcc 3.*)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          rejects-legal
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 08 11:46:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Peter Schmid
>Release:        3.3 20020905 (experimental)
>Organization:
TU Darmstadt
>Environment:
System: Linux kiste 2.4.18 #8 Sat Mar 9 15:33:15 CET 2002 i686 unknown
Architecture: i686
GNU ld version 2.13.90.0.4 20020814
host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc/configure --enable-shared --disable-nls --enable-threads=posix --enable-languages=c,c++,f77,objc --enable-__cxa_atexit
>Description:
The g++ compiler built from current mainline cvs sources rejects the
following code tc1.C breaking boost and STLport. Previous g++ compilers,
including gcc 3.3 bootstrapped one week ago, compile this code normally.   
>How-To-Repeat:
source code tc1.C
namespace std
{
template <class _Arg, class _Result>
struct unary_function {
  typedef _Arg argument_type;   
  typedef _Result result_type;  
};

template <class _Arg1, class _Arg2, class _Result>
struct binary_function {
  typedef _Arg1 first_argument_type;   
  typedef _Arg2 second_argument_type;  
  typedef _Result result_type;         
};      

template <class _Tp>
struct plus : public binary_function<_Tp,_Tp,_Tp> {
  _Tp operator()(const _Tp& __x, const _Tp& __y) const { return __x + __y; }
};

template <class _Operation> 
class binder1st
  : public unary_function<typename _Operation::second_argument_type,
                          typename _Operation::result_type> {
protected:
  _Operation op;
  typename _Operation::first_argument_type value;
public:
  binder1st(const _Operation& __x,
            const typename _Operation::first_argument_type& __y)
      : op(__x), value(__y) {}
  typename _Operation::result_type
  operator()(const typename _Operation::second_argument_type& __x) const {
    return op(value, __x); 
  }
  typename _Operation::result_type
  operator()(typename _Operation::second_argument_type& __x) const {
    return op(value, __x); 
  }
};

template <class _Operation, class _Tp>
inline binder1st<_Operation> 
bind1st(const _Operation& __fn, const _Tp& __x) 
{
  typedef typename _Operation::first_argument_type _Arg1_type;
  return binder1st<_Operation>(__fn, _Arg1_type(__x));
}

} // namespace std

template<typename _InputIter, typename _OutputIter, typename _UnaryOperation>
    _OutputIter
    transform(_InputIter __first, _InputIter __last,
              _OutputIter __result, _UnaryOperation __unary_op)
    {

      for ( ; __first != __last; ++__first, ++__result)
        *__result = __unary_op(*__first);
      return __result;
    }

int main()
{
  char a[10];
  char b[10];

  transform(a, a+10,
	    b, std::bind1st(std::plus<char>(), 1));
}

compiling tc1.C
g++ -v tc1.C -W -Wall 
Reading specs from /usr/local/lib/gcc-lib/i686-pc-linux-gnu/3.3/specs
Configured with: ../gcc/configure --enable-shared --disable-nls --enable-threads=posix --enable-languages=c,c++,f77,objc --enable-__cxa_atexit
Thread model: posix
gcc version 3.3 20020905 (experimental)
 /usr/local/lib/gcc-lib/i686-pc-linux-gnu/3.3/cc1plus -quiet -v -D__GNUC__=3 -D__GNUC_MINOR__=3 -D__GNUC_PATCHLEVEL__=0 -D_GNU_SOURCE tc1.C -D__GNUG__=3 -quiet -dumpbase tc1.C -auxbase tc1 -W -Wall -version -o /tmp/cc9l1up9.s
GNU C++ version 3.3 20020905 (experimental) (i686-pc-linux-gnu)
	compiled by GNU C version 3.3 20020905 (experimental).
ignoring nonexistent directory "NONE/include"
ignoring nonexistent directory "/usr/local/i686-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include/c++/3.3
 /usr/local/include/c++/3.3/i686-pc-linux-gnu
 /usr/local/include/c++/3.3/backward
 /usr/local/include
 /usr/local/lib/gcc-lib/i686-pc-linux-gnu/3.3/include
 /usr/include
End of search list.
tc1.C: In function `std::binder1st<_Operation> std::bind1st(const _Operation&, 
   const _Tp&) [with _Operation = std::plus<char>, _Tp = int]':
tc1.C:69:   instantiated from here
tc1.C:47: error: non-lvalue in unary `&'

>Fix:
	
>Release-Note:
>Audit-Trail:
>Unformatted: