public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] sim: Suppress non-literal printf warning
Date: Mon, 24 Oct 2022 19:50:57 +0900	[thread overview]
Message-ID: <02420829-7289-3208-4a2f-123dd11a5626@irq.a4lg.com> (raw)
In-Reply-To: <Y1UyFq2l+/A2qoTU@vapier>

On 2022/10/23 21:22, Mike Frysinger wrote:
> On 06 Oct 2022 14:39, Tsukasa OI via Gdb-patches wrote:
>> On 2022/10/05 20:45, Andrew Burgess wrote:
>>> Tsukasa OI <research_trasio@irq.a4lg.com> writes:
>>>> Clang generates a warning if the format parameter of a printf-like function
>>>> is not a literal.  However, on hw_vabort, it's unavoidable to use non-
>>>> literal as a format string (unless we make huge redesign).
>>>>
>>>> We have "include/diagnostics.h" to suppress certain warnings only when
>>>> necessary.  Because DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL can suppress
>>>> warnings when the format parameter of a printf-like function is not a
>>>> literal, this commit adds this (only where necessary) to suppress this
>>>> error with "-Werror", the default configuration.
>>>>
>>>> sim/ChangeLog:
>>>>
>>>> 	* common/sim-hw.c (hw_vabort): Suppress non-literal printf warning
>>>> 	by using DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL.
>>>> ---
>>>>  sim/common/sim-hw.c | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c
>>>> index cece5638bc9..36f355d2262 100644
>>>> --- a/sim/common/sim-hw.c
>>>> +++ b/sim/common/sim-hw.c
>>>> @@ -425,10 +425,13 @@ hw_vabort (struct hw *me,
>>>>    strcat (msg, ": ");
>>>>    strcat (msg, fmt);
>>>>    /* report the problem */
>>>> +  DIAGNOSTIC_PUSH
>>>> +  DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL
>>>>    sim_engine_vabort (hw_system (me),
>>>>  		     STATE_HW (hw_system (me))->cpu,
>>>>  		     STATE_HW (hw_system (me))->cia,
>>>>  		     msg, ap);
>>>> +  DIAGNOSTIC_POP
>>>
>>> Rather than disabling diagnostics, I'd like to propose the patch below
>>> which expands FMT and AP within sim-hw.c, then passes the expanded
>>> string through to sim_engine_abort.  What do you think of this?
>>
>> Ah, It took a while to understand but makes sense to me.
>>
>> I just needed to add ATTRIBUTE_PRINTF (2, 0) to suppress "-Werror
>> -Wformat-nonliteral" but I prefer to use your patch instead.
> 
> adding ATTRIBUTE_PRINTF doesn't suppress warnings, it fixes them
> -mike

Correct.  I'm focusing on fixing "build failures caused by Clang
warnings" and I think I wrote commit messages without considering why
warnings are gone.

Thanks for pointing this out.
Tsukasa

  reply	other threads:[~2022-10-24 10:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13 12:57 [PATCH 0/4] sim/common: Suppress warnings if built with Clang Tsukasa OI
2022-09-13 12:57 ` [PATCH 1/4] sim: Add ATTRIBUTE_PRINTF Tsukasa OI
2022-09-13 12:57 ` [PATCH 2/4] sim: Remove self-assignments Tsukasa OI
2022-09-13 12:57 ` [PATCH 3/4] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-10-05 11:38   ` Andrew Burgess
2022-10-06  5:33     ` Tsukasa OI
2022-09-13 12:57 ` [PATCH 4/4] sim: Suppress non-literal printf warning Tsukasa OI
2022-10-05 11:45   ` Andrew Burgess
2022-10-06  5:39     ` Tsukasa OI
2022-10-23 12:22       ` Mike Frysinger
2022-10-24 10:50         ` Tsukasa OI [this message]
2022-09-25  8:42 ` [PATCH v2 0/5] sim: Suppress warnings if built with Clang Tsukasa OI
2022-09-25  8:42   ` [PATCH v2 1/5] sim: Remove self-assignments Tsukasa OI
2022-09-25  8:42   ` [PATCH v2 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-09-25  8:42   ` [PATCH v2 3/5] sim: Suppress non-literal printf warning Tsukasa OI
2022-09-25  8:42   ` [PATCH v2 4/5] sim: Check known getopt definition existence Tsukasa OI
2022-09-25  8:42   ` [PATCH v2 5/5] sim: Initialize pbb_br_* by default Tsukasa OI
2022-10-06  6:43   ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Tsukasa OI
2022-10-06  6:43     ` [PATCH v3 1/5] sim: Remove self-assignments Tsukasa OI
2022-10-11 14:21       ` Andrew Burgess
2022-10-11 14:29         ` Tsukasa OI
2022-10-06  6:43     ` [PATCH v3 2/5] sim: Make WITH_{TRACE,PROFILE}-based macros bool Tsukasa OI
2022-10-06  6:43     ` [PATCH v3 3/5] sim: Suppress non-literal printf warning Tsukasa OI
2022-10-11 14:22       ` Andrew Burgess
2022-10-06  6:43     ` [PATCH v3 4/5] sim: Check known getopt definition existence Tsukasa OI
2022-10-12 16:28       ` Tom de Vries
2022-10-12 17:03         ` Tsukasa OI
2022-10-12 17:08           ` Tom de Vries
2022-10-12 17:20             ` Tom de Vries
2022-10-13  9:50         ` Tsukasa OI
2022-10-23 12:16       ` Mike Frysinger
2022-10-27  2:02         ` Tsukasa OI
2023-01-03  3:12           ` Mike Frysinger
2023-01-03  8:47             ` Tsukasa OI
2022-10-06  6:43     ` [PATCH v3 5/5] sim: Initialize pbb_br_* by default Tsukasa OI
2022-10-11 14:20     ` [PATCH v3 0/5] sim: Suppress warnings if built with Clang Andrew Burgess
2022-10-11 16:40     ` Tom de Vries
2022-10-11 18:02       ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02420829-7289-3208-4a2f-123dd11a5626@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).