From: Eli Zaretskii <eliz@gnu.org>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read
Date: Wed, 13 Mar 2024 17:58:48 +0200 [thread overview]
Message-ID: <86zfv2azt3.fsf@gnu.org> (raw)
In-Reply-To: <990be8b42f1f6ca33ffed7a8ae7ead327009d847.1710343840.git.tankut.baris.aktemur@intel.com> (message from Tankut Baris Aktemur on Wed, 13 Mar 2024 16:35:45 +0100)
> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Date: Wed, 13 Mar 2024 16:35:45 +0100
>
> gdb/NEWS | 7 ++++++
> gdb/doc/gdb.texinfo | 29 +++++++++++++++++++++++++
> gdb/remote.c | 45 +++++++++++++++++++++++++++++++++------
> gdbserver/remote-utils.cc | 39 ++++++++++++++++++++++++++++-----
> gdbserver/remote-utils.h | 2 ++
> gdbserver/server.cc | 21 ++++++++++++++++++
> 6 files changed, 132 insertions(+), 11 deletions(-)
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -152,6 +152,13 @@ QThreadOptions in qSupported
> QThreadOptions packet, and the qSupported response can contain the
> set of thread options the remote stub supports.
>
> +x
> +
> + Given ADDR and LENGTH, fetch LENGTH units from the memory at address
> + ADDR and send the fetched data in binary format. This packet is
> + equivalent to 'm', except that the data in the response are in
> + binary format.
This part is OK, but I wonder whether it would have been better to
mention the packet parameters on the line that now says just "x"?
> +Read @var{length} addressable memory units starting at address @var{addr}
> +(@pxref{addressable memory unit}). Note that @var{addr} may not be aligned
> +to any particular boundary.
That "may not be aligned" could be misinterpreted to mean "must not be
aligned". I suggest to rephrase:
Note that @var{addr} does not have to be aligned to any particular
boundary.
> +The stub need not use any particular size or alignment when gathering
> +data from memory for the response; even if @var{addr} is word-aligned
> +and @var{length} is a multiple of the word size, the stub is free to
> +use byte accesses, or not. For this reason, this packet may not be
> +suitable for accessing memory-mapped I/O devices.
> +@cindex alignment of remote memory accesses
> +@cindex size of remote memory accesses
> +@cindex memory, alignment and size of remote accesses
These @cindex entries should be before the text they index, not after
it.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2024-03-13 15:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:35 [PATCH 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-13 15:35 ` [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-13 19:10 ` Tom Tromey
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-13 15:35 ` [PATCH 2/3] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-13 19:17 ` Tom Tromey
2024-03-13 15:35 ` [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-03-13 15:50 ` Luis Machado
2024-03-13 18:21 ` Aktemur, Tankut Baris
2024-03-14 10:01 ` Luis Machado
2024-03-13 15:58 ` Eli Zaretskii [this message]
2024-03-13 19:27 ` Tom Tromey
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-14 12:46 ` Tom Tromey
2024-03-15 9:59 ` Aktemur, Tankut Baris
2024-03-19 16:01 ` Tom Tromey
2024-03-20 17:32 ` Aktemur, Tankut Baris
2024-03-20 20:12 ` Tom Tromey
2024-04-05 13:05 ` Andrew Burgess
2024-04-05 14:09 ` Tom Tromey
2024-04-08 21:36 ` Andrew Burgess
2024-03-14 12:34 ` Aktemur, Tankut Baris
2024-03-14 13:07 ` [PATCH v2 0/4] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 1/4] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-03-14 15:06 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 2/4] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 3/4] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-14 13:46 ` Ciaran Woodward
2024-03-14 15:19 ` Aktemur, Tankut Baris
2024-04-05 12:59 ` Andrew Burgess
2024-03-14 15:07 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 4/4] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 1/3] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-04-09 9:27 ` Eli Zaretskii
2024-04-09 7:48 ` [PATCH v3 2/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zfv2azt3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).