From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Tom Tromey <tom@tromey.com>,
"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read
Date: Mon, 08 Apr 2024 22:36:40 +0100 [thread overview]
Message-ID: <87jzl71qqf.fsf@redhat.com> (raw)
In-Reply-To: <87il0vnbpb.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> The alternative to this would be to add a qSupported feature for the 'x'
> Andrew> packet and choose m/x based on the qSupported reply.
>
> That's what his original patch did. If you think that's best then it
> already exists. My view was that there didn't seem to be a need for
> this to be in qSupported and the qSupported responses are already
> getting pretty long.
No, I joined this party a little late, so I missed that this was the
original approach taken.
I think the best solution would be to add a prefix character to the
reply so that we never send back an empty packet (when this feature is
supported), then use the empty packet to represent the unsupported case.
Thanks,
Andrew
next prev parent reply other threads:[~2024-04-08 21:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:35 [PATCH 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-13 15:35 ` [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-13 19:10 ` Tom Tromey
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-13 15:35 ` [PATCH 2/3] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-13 19:17 ` Tom Tromey
2024-03-13 15:35 ` [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-03-13 15:50 ` Luis Machado
2024-03-13 18:21 ` Aktemur, Tankut Baris
2024-03-14 10:01 ` Luis Machado
2024-03-13 15:58 ` Eli Zaretskii
2024-03-13 19:27 ` Tom Tromey
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-14 12:46 ` Tom Tromey
2024-03-15 9:59 ` Aktemur, Tankut Baris
2024-03-19 16:01 ` Tom Tromey
2024-03-20 17:32 ` Aktemur, Tankut Baris
2024-03-20 20:12 ` Tom Tromey
2024-04-05 13:05 ` Andrew Burgess
2024-04-05 14:09 ` Tom Tromey
2024-04-08 21:36 ` Andrew Burgess [this message]
2024-03-14 12:34 ` Aktemur, Tankut Baris
2024-03-14 13:07 ` [PATCH v2 0/4] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 1/4] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-03-14 15:06 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 2/4] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 3/4] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-14 13:46 ` Ciaran Woodward
2024-03-14 15:19 ` Aktemur, Tankut Baris
2024-04-05 12:59 ` Andrew Burgess
2024-03-14 15:07 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 4/4] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 1/3] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-04-09 9:27 ` Eli Zaretskii
2024-04-09 7:48 ` [PATCH v3 2/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzl71qqf.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).