From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read
Date: Wed, 13 Mar 2024 13:27:03 -0600 [thread overview]
Message-ID: <87h6halypk.fsf@tromey.com> (raw)
In-Reply-To: <990be8b42f1f6ca33ffed7a8ae7ead327009d847.1710343840.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Wed, 13 Mar 2024 16:35:45 +0100")
>>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> Introduce an RSP packet, 'x', for reading from the remote server
> memory in binary format. The binary write packet, 'X' already exists.
> The 'x' packet is essentially the same as 'm', except that the
> returned data is in binary format. For transferring relatively large
> data (e.g. shared library files), the 'x' packet can reduce the
> transfer costs.
Thanks for the patch. I agree with the overall idea and the choice of
'x' as the packet.
> +@item x @var{addr},@var{length}
> +@anchor{x packet}
> +@cindex @samp{x} packet
> +Read @var{length} addressable memory units starting at address @var{addr}
> +(@pxref{addressable memory unit}). Note that @var{addr} may not be aligned
> +to any particular boundary.
I think it would be good to address the "short read" request here:
https://sourceware.org/bugzilla/show_bug.cgi?id=24751
that is, document what ought to happen in this case.
Now that 'E' must be quoted in binary packets, I think the "binary data"
section of the "Overview" node must be updated to mention that certain
replies -- and in particular this one -- must handle this properly.
> + /* Determine which packet format to use. */
> + char packet_format = 'm';
> +DIAGNOSTIC_PUSH
> +DIAGNOSTIC_ERROR_SWITCH
> + switch (m_features.packet_support (PACKET_x))
> + {
> + case PACKET_ENABLE:
> + packet_format = 'x';
> + break;
> + case PACKET_DISABLE:
> + packet_format = 'm';
> + break;
> + case PACKET_SUPPORT_UNKNOWN:
> + internal_error (_("remote_read_bytes_1: bad internal state"));
> + }
> +DIAGNOSTIC_POP
Can this possibly be done without the diagnostic stuff.
> + /* Binary memory read support. */
> + strcat (own_buf, ";x+");
One thing I don't really know about the remote protocol is whether we
prefer to add advertised features (like this) or just have gdb probe.
> + suppress_next_putpkt_log ();
Ok, I guess I see why you did it this way now. You can ignore that
earlier comment I guess.
Tom
next prev parent reply other threads:[~2024-03-13 19:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 15:35 [PATCH 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-13 15:35 ` [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-13 19:10 ` Tom Tromey
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-13 15:35 ` [PATCH 2/3] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-13 19:17 ` Tom Tromey
2024-03-13 15:35 ` [PATCH 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-03-13 15:50 ` Luis Machado
2024-03-13 18:21 ` Aktemur, Tankut Baris
2024-03-14 10:01 ` Luis Machado
2024-03-13 15:58 ` Eli Zaretskii
2024-03-13 19:27 ` Tom Tromey [this message]
2024-03-14 10:36 ` Aktemur, Tankut Baris
2024-03-14 12:46 ` Tom Tromey
2024-03-15 9:59 ` Aktemur, Tankut Baris
2024-03-19 16:01 ` Tom Tromey
2024-03-20 17:32 ` Aktemur, Tankut Baris
2024-03-20 20:12 ` Tom Tromey
2024-04-05 13:05 ` Andrew Burgess
2024-04-05 14:09 ` Tom Tromey
2024-04-08 21:36 ` Andrew Burgess
2024-03-14 12:34 ` Aktemur, Tankut Baris
2024-03-14 13:07 ` [PATCH v2 0/4] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 1/4] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-03-14 15:06 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 2/4] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-03-14 13:07 ` [PATCH v2 3/4] rsp: add 'E' to escaped characters Tankut Baris Aktemur
2024-03-14 13:46 ` Ciaran Woodward
2024-03-14 15:19 ` Aktemur, Tankut Baris
2024-04-05 12:59 ` Andrew Burgess
2024-03-14 15:07 ` Eli Zaretskii
2024-03-14 13:07 ` [PATCH v2 4/4] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 0/3] Introduce the 'x' RSP packet Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 1/3] doc: fine-tune the documentation of the 'm' " Tankut Baris Aktemur
2024-04-09 9:27 ` Eli Zaretskii
2024-04-09 7:48 ` [PATCH v3 2/3] gdbserver: allow suppressing the next putpkt remote-debug log Tankut Baris Aktemur
2024-04-09 7:48 ` [PATCH v3 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read Tankut Baris Aktemur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6halypk.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).