RE: [PATCH 1/3] gdbserver: allow suppressing the next putpkt remote-debug log

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Wednesday, March 13, 2024 8:10 PM, Tom Tromey wrote:
> >>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> 
> > When started with the --remote-debug flag, gdbserver enables the debug
> > logs for the received and sent remote packets.  If the packet contents
> > are too long or contain verbatim binary data, printing the contents
> > may create noise in the logs or even distortion in the terminal output.
> 
> I'm sort of meh about this patch.  However, there are already other ways
> to get more complete logs (my fave is "set remotelogfile", since that
> can be replayed), so I guess the concept is alright.

I'm also not so happy about this patch, but because of how the logging is done
in the lower-level RSP utility functions, this was the solution I had to come up
with.

> > +void
> > +suppress_next_putpkt_log ()
> > +{
> > +  suppressed_remote_debug = true;
> > +}
> 
> I think returning a scoped_restore here would be better.
> Or just letting clients do this directly.
> 
> > +  SCOPE_EXIT { suppressed_remote_debug = false; };
> 
> Then you wouldn't need a SCOPE_EXIT here.
> 
> Tom

Based on your comment later in the last patch, I concur that there isn't a change
request for this patch and I'll keep it the same in the next revision.  Please let
me know if I misunderstood.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928